Skip to contentSkip to conversation

scsi: csiostor: Fix a possible null-pointer dereference in csio_eh_lun_reset_handler()

PATCH New Tuo Li 1 participant 1 message Dec 18, 2025 SCSI

lore
Share & tools
lore

Tuo Li

author
#0 lore raw

PATCH 1/1 scsi: csiostor: Fix a possible null-pointer dereference in csio_eh_lun_reset_handler()

In this function, rn is checked by an if statement. If it is NULL, execution transfers to the fail label. However, rn may still be dereferenced later via the following macro:

  CSIO_INC_STATS(rn, n_lun_rst_fail);

To avoid a potential null-pointer dereference, return FAILED directly when rn is NULL, rather than transferring control to the common fail label.

---
 drivers/scsi/csiostor/csio_scsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/csiostor/csio_scsi.c +1 -1
index 34bde6650fae..feb1a9a9390b 100644
@@ -2074,7 +2074,7 @@ csio_eh_lun_reset_handler(struct scsi_cmnd *cmnd)
 	struct csio_scsi_level_data sld;
 
 	if (!rn)
-		goto fail;
+		return FAILED;
 
 	csio_dbg(hw, "Request to reset LUN:%llu (ssni:0x%x tgtid:%d)\n",
 		      cmnd->device->lun, rn->flowid, rn->scsi_id);
Signature · 1 line
2.43.0