Skip to contentSkip to conversation

ASoC: codecs: pm4125: clean up bind() device reference handling

PATCH In review Johan Hovold 3 participants 3 messages Dec 19, 2025 – Dec 22, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: codecs: pm4125: clean up bind() device reference handling

A recent change fixed a couple of device leaks on component bind failure and on unbind but did so in a confusing way by adding misleading initialisations at bind() and bogus NULL checks at unbind().

---
 sound/soc/codecs/pm4125.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)
sound/soc/codecs/pm4125.c +2 -9
index 8bc3b9994019..43dcafff6c77 100644
@@ -1505,10 +1505,6 @@ static int pm4125_bind(struct device *dev)
 	struct device_link *devlink;
 	int ret;
 
-	/* Initialize device pointers to NULL for safe cleanup */
-	pm4125->rxdev = NULL;
-	pm4125->txdev = NULL;
-
 	/* Give the soundwire subdevices some more time to settle */
 	usleep_range(15000, 15010);
 
@@ -1624,11 +1620,8 @@ static void pm4125_unbind(struct device *dev)
 	device_link_remove(dev, pm4125->rxdev);
 	device_link_remove(pm4125->rxdev, pm4125->txdev);
 
-	/* Release device references acquired in bind */
-	if (pm4125->txdev)
-		put_device(pm4125->txdev);
-	if (pm4125->rxdev)
-		put_device(pm4125->rxdev);
+	put_device(pm4125->txdev);
+	put_device(pm4125->rxdev);
 
 	component_unbind_all(dev, pm4125);
 }
Signature · 1 line
2.51.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Johan Hovold

A recent change fixed a couple of device leaks on component bind failure and on unbind but did so in a confusing way by adding misleading initialisations at bind() and bogus NULL checks at unbind().

---
 sound/soc/codecs/pm4125.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)
Signature · 2 lines
With best wishes
Dmitry
maintainer
#2 lore raw
In reply to Johan Hovold
Quoted 5 lines · Johan Hovold

A recent change fixed a couple of device leaks on component bind failure and on unbind but did so in a confusing way by adding misleading initialisations at bind() and bogus NULL checks at unbind().

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: codecs: pm4125: clean up bind() device reference handling

      commit: 97af54473f2a79f663bd14d7c75e97d04bd0e283

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark