Skip to contentSkip to conversation

Documentation: kernel-hacking: Remove comma

PATCH Applied Thorsten Blum 3 participants 6 messages Dec 19, 2025 – Dec 22, 2025 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation: kernel-hacking: Remove comma

The comma is wrong, remove it.

---
 Documentation/kernel-hacking/hacking.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/kernel-hacking/hacking.rst +1 -1
index 0042776a9e17..06fcb7c662d3 100644
@@ -49,7 +49,7 @@ User Context
 
 User context is when you are coming in from a system call or other trap:
 like userspace, you can be preempted by more important tasks and by
-interrupts. You can sleep, by calling :c:func:`schedule()`.
+interrupts. You can sleep by calling :c:func:`schedule()`.
 
 .. note::
 
Signature · 2 lines
Thorsten Blum <[email protected]>
GPG: 1D60 735E 8AEF 3BE4 73B6  9D84 7336 78FD 8DFE EAD4
reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Thorsten Blum

The comma is wrong, remove it.

Quoted 17 lines
---
 Documentation/kernel-hacking/hacking.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/kernel-hacking/hacking.rst +1 -1
index 0042776a9e17..06fcb7c662d3 100644
@@ -49,7 +49,7 @@ User Context
 
 User context is when you are coming in from a system call or other trap:
 like userspace, you can be preempted by more important tasks and by
-interrupts. You can sleep, by calling :c:func:`schedule()`.
+interrupts. You can sleep by calling :c:func:`schedule()`.
 
 .. note::
 
Signature · 1 line
~Randy
maintainer
#2 lore raw
In reply to Thorsten Blum
Quoted 12 lines · Thorsten Blum

The comma is wrong, remove it.

---
 Documentation/kernel-hacking/hacking.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/kernel-hacking/hacking.rst +0 -0
index 0042776a9e17..06fcb7c662d3 100644

Documentation/kernel-hacking/hacking.rst User Context · line 52

Quoted 5 lines
Documentation/kernel-hacking/hacking.rst +1 -1
@@ -49,7 +49,7 @@ User Context
 
 User context is when you are coming in from a system call or other trap:
 like userspace, you can be preempted by more important tasks and by
-interrupts. You can sleep, by calling :c:func:`schedule()`.
+interrupts. You can sleep by calling :c:func:`schedule()`.

That's a fine change, but can I prevail upon you to get rid of the usless :c:func: annotation while you're playing with that line?

Thanks,

jon

#3 lore raw
Quoted 14 lines · Jonathan Corbet
Quoted 13 lines · Thorsten Blum

The comma is wrong, remove it.

---
Documentation/kernel-hacking/hacking.rst | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/kernel-hacking/hacking.rst +0 -0
index 0042776a9e17..06fcb7c662d3 100644
@@ -49,7 +49,7 @@ User Context
 
Quoted 7 lines

Documentation/kernel-hacking/hacking.rst User Context · line 52

Quoted 4 lines

User context is when you are coming in from a system call or other trap:
like userspace, you can be preempted by more important tasks and by

Documentation/kernel-hacking/hacking.rst +1 -1
-interrupts. You can sleep, by calling :c:func:`schedule()`.
+interrupts. You can sleep by calling :c:func:`schedule()`.

That's a fine change, but can I prevail upon you to get rid of the usless :c:func: annotation while you're playing with that line?

So just schedule()?

:c:func: is used very often in the same file - maybe we should remove them all in a separate patch? I'm fine either way.

Thanks,
Thorsten

maintainer
#4 lore raw
Quoted 4 lines · Thorsten Blum
Quoted 2 lines

That's a fine change, but can I prevail upon you to get rid of the usless :c:func: annotation while you're playing with that line?

So just schedule()?

Yes. We should never use :c:func:, our automarkup code will do the right thing in its absence.

Quoted 2 lines

:c:func: is used very often in the same file - maybe we should remove them all in a separate patch? I'm fine either way.

If you want to do them all, a separate patch probably makes sense. That would be wonderful.

Thanks,

jon

maintainer Applied
#5 lore raw
In reply to Thorsten Blum
Quoted 12 lines · Thorsten Blum

The comma is wrong, remove it.

---
 Documentation/kernel-hacking/hacking.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/kernel-hacking/hacking.rst +0 -0
index 0042776a9e17..06fcb7c662d3 100644

Documentation/kernel-hacking/hacking.rst User Context · line 53

Quoted 6 lines
Documentation/kernel-hacking/hacking.rst +1 -1
@@ -49,7 +49,7 @@ User Context
 
 User context is when you are coming in from a system call or other trap:
 like userspace, you can be preempted by more important tasks and by
-interrupts. You can sleep, by calling :c:func:`schedule()`.
+interrupts. You can sleep by calling :c:func:`schedule()`.
 

Applied, thanks,

jon