mm/memtest: prevent arithmetic underflow in end pointer calculation
PATCH 1/1 mm/memtest: prevent arithmetic underflow in end pointer calculation
From: Kevin Lourenco <[email protected]>
The computation of the loop end pointer can underflow when size is smaller than the alignment offset:
(size - (start_phys_aligned - start_phys))
If size < offset, the unsigned subtraction wraps to ~0, causing a massive loop iteration that writes far beyond the intended region, leading to memory corruption during early boot.
While unlikely in practice (memblock regions are typically KB/MB), cost is negligible (one comparison), but it prevents catastrophic memory corruption in edge cases.
--- mm/memtest.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
mm/memtest.c +7 -2
@@ -41,12 +41,17 @@ static void __init memtest(u64 pattern, phys_addr_t start_phys, phys_addr_t size {u64 *p, *start, *end;phys_addr_t start_bad, last_bad; -phys_addr_t start_phys_aligned; +phys_addr_t start_phys_aligned, offset;const size_t incr =sizeof (pattern); start_phys_aligned =ALIGN (start_phys, incr); start =__va (start_phys_aligned); - end = start + (size - (start_phys_aligned - start_phys)) / incr; + + offset = start_phys_aligned - start_phys; +if (size < offset) +return ; + + end = start + (size - offset) / incr; start_bad =0 ; last_bad =0 ;
Signature · 1 line
2.47.3
Mike Rapoport
maintainerQuoted 8 lines · On Sat, Dec 20, 2025 at 04:10:19PM +0100, [email protected] wrote:
From: Kevin Lourenco <[email protected]>
The computation of the loop end pointer can underflow when size is smaller than the alignment offset:
(size - (
start_phys_aligned-start_phys))If size < offset, the unsigned subtraction wraps to ~0, causing a
Is it exactly ~0?
Quoted 17 lines
massive loop iteration that writes far beyond the intended region, leading to memory corruption during early boot.
While unlikely in practice (memblock regions are typically KB/MB), cost is negligible (one comparison), but it prevents catastrophic memory corruption in edge cases.
Signed-off-by Kevin Lourenco <[email protected]>--- mm/memtest.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)mm/memtest.c +0
-0
mm/memtest.c static void __init memtest(u64 pattern, phys_addr_t start_phys, phys_addr_t size · line 49
Quoted 10 lines
mm/memtest.c +1
-2@@ -41,12 +41,17 @@ static void __init memtest(u64 pattern, phys_addr_t start_phys, phys_addr_t size {u64 *p, *start, *end;phys_addr_t start_bad, last_bad; -phys_addr_t start_phys_aligned; +phys_addr_t start_phys_aligned, offset;const size_t incr =sizeof (pattern); start_phys_aligned =ALIGN (start_phys, incr); start =__va (start_phys_aligned); - end = start + (size - (start_phys_aligned - start_phys)) / incr;
I believe VM_WARN_ON_ONCE(size < start_phys_aligned - start_phys) is sufficient here to detect those theoretical edge cases.
Quoted 12 lines
mm/memtest.c +6
-0+ + offset = start_phys_aligned - start_phys; +if (size < offset) +return ; + + end = start + (size - offset) / incr; start_bad =0 ; last_bad =0 ;Signature · 1 line
2.47.3
Signature · 2 lines
Sincerely yours, Mike.
Hi Mike,
Quoted 1 line
Is it exactly ~0?
Not exactly - it's UINT64_MAX - (offset - size), but since offset is at most 7 bytes (from ALIGN), the result is in the range [~0 - 7, ~0], which after division by 8 still yields ~2^61 iterations.
Either way, if it happens, it's not great, WARN_ON_ONCE usage sounds good, I'll send a v2 patch.
Thanks for the feedback!
Quoted 60 lines · Mike Rapoport
Quoted 8 lines · On Sat, Dec 20, 2025 at 04:10:19PM +0100, [email protected] wrote:
From: Kevin Lourenco <[email protected]>
The computation of the loop end pointer can underflow when size is smaller than the alignment offset:
(size - (
start_phys_aligned-start_phys))If size < offset, the unsigned subtraction wraps to ~0, causing a
Is it exactly ~0?
Quoted 17 lines
massive loop iteration that writes far beyond the intended region, leading to memory corruption during early boot.
While unlikely in practice (memblock regions are typically KB/MB), cost is negligible (one comparison), but it prevents catastrophic memory corruption in edge cases.
Signed-off-by Kevin Lourenco <[email protected]>--- mm/memtest.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)mm/memtest.c +0
-0mm/memtest.c static void __init memtest(u64 pattern, phys_addr_t start_phys, phys_addr_t size · line 49
Quoted 10 lines
mm/memtest.c +1
-2@@ -41,12 +41,17 @@ static void __init memtest(u64 pattern, phys_addr_t start_phys, phys_addr_t size {u64 *p, *start, *end;phys_addr_t start_bad, last_bad; -phys_addr_t start_phys_aligned; +phys_addr_t start_phys_aligned, offset;const size_t incr =sizeof (pattern); start_phys_aligned =ALIGN (start_phys, incr); start =__va (start_phys_aligned); - end = start + (size - (start_phys_aligned - start_phys)) / incr;I believe
VM_WARN_ON_ONCE(size < start_phys_aligned - start_phys)is sufficient here to detect those theoretical edge cases.Quoted 10 lines
mm/memtest.c +6
-1+ + offset = start_phys_aligned - start_phys; +if (size < offset) +return ; + + end = start + (size - offset) / incr; start_bad =0 ; last_bad =0 ; --Quoted 2 lines
2.47.3
--
Sincerely yours,
Mike.
PATCH v2 1/1 mm/memtest: add underflow detection for size calculation
From: Kevin Lourenco <[email protected]>
The computation: end = start + (size - (start_phys_aligned - start_phys)) / incr could theoretically underflow if size < offset, leading to a massive iteration.
Add VM_WARN_ON_ONCE() to detect cases where the region size is smaller than the alignment offset. While this should never happen in practice due to memblock guarantees, the warning helps catch potential bugs in early memory initialization code.
--- mm/memtest.c | 1 + 1 file changed, 1 insertion(+)
mm/memtest.c +1 -0
@@ -46,6 +46,7 @@ static void __init memtest(u64 pattern, phys_addr_t start_phys, phys_addr_t size start_phys_aligned =ALIGN (start_phys, incr); start =__va (start_phys_aligned); +VM_WARN_ON_ONCE (size < start_phys_aligned - start_phys); end = start + (size - (start_phys_aligned - start_phys)) / incr; start_bad =0 ; last_bad =0 ;
Signature · 1 line
2.47.3
Re: [PATCH v2] mm/memtest: add underflow detection for size calculation
Quoted 10 lines · On Mon, 29 Dec 2025 17:13:21 +0100, [email protected] wrote:
The computation: end = start + (size - (
start_phys_aligned-start_phys)) / incr could theoretically underflow if size < offset, leading to a massive iteration.Add
VM_WARN_ON_ONCE()to detect cases where the region size is smaller than the alignment offset. While this should never happen in practice due to memblock guarantees, the warning helps catch potential bugs in early memory initialization code.[...]
Applied to for-next branch of memblock.git tree, thanks!
I massaged the changelog a bit and moved VM_WARN_ON_ONCE() down while applying.
[1/1] mm/memtest: add underflow detection for size calculation
commit: acd8aed2f2b6ce4bcc4f20e48ae88882b1b29fc3
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rppt/memblock
branch: for-next
--
Sincerely yours,
Mike.