Skip to contentSkip to conversation

Patch "usb: usb-storage: No additional quirks need to be added to the EL-R12 optical drive." has been added to the 6.18-stable tree

DISCUSSION Applied Alan Stern 2 participants 2 messages Dec 27, 2025 – Dec 29, 2025 1 message not in the archive Stable branch

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Alan Stern

author
#1 lore raw
Quoted 7 lines · Sasha Levin

This is a note to let you know that I've just added the patch titled

usb: usb-storage: No additional quirks need to be added to the EL-R12 optical drive.

to the 6.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 6 lines

The filename of the patch is:
usb-usb-storage-no-additional-quirks-need-to-be-adde.patch
and it can be found in the queue-6.18 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

This commit will be modified by commit 0831269b5f71 ("usb: usb-storage:
Maintain minimal modifications to the bcdDevice range.") in Greg's usb-linus branch, which has not yet been merged into the mainline kernel. The two commits should be added to the -stable kernels at the same time, if possible, which probably means holding off on this one until the next round.

Alan Stern

Quoted 57 lines

commit 4846de73fe267ccffe66a5bff7c7def201c34df1

Author: Chen Changcheng <[email protected]>
Date:   Fri Nov 21 14:40:20 2025 +0800
    usb: usb-storage: No additional quirks need to be added to the EL-R12 optical drive.
    
    [ Upstream commit 955a48a5353f4fe009704a9a4272a3adf627cd35 ]
    
    The optical drive of EL-R12 has the same vid and pid as INIC-3069,
    as follows:
    T:  Bus=02 Lev=02 Prnt=02 Port=01 Cnt=01 Dev#=  3 Spd=5000 MxCh= 0
    D:  Ver= 3.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 9 #Cfgs=  1
    P:  Vendor=13fd ProdID=3940 Rev= 3.10
    S:  Manufacturer=HL-DT-ST
    S:  Product= DVD+-RW GT80N
    S:  SerialNumber=423349524E4E38303338323439202020
    C:* #Ifs= 1 Cfg#= 1 Atr=80 MxPwr=144mA
    I:* If#= 0 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=02 Prot=50 Driver=usb-storage
    E:  Ad=83(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms
    E:  Ad=0a(O) Atr=02(Bulk) MxPS=1024 Ivl=0ms
    
    This will result in the optical drive device also adding
    the quirks of US_FL_NO_ATA_1X. When performing an erase operation,
    it will fail, and the reason for the failure is as follows:
    [  388.967742] sr 5:0:0:0: [sr0] tag#0 Send: scmd 0x00000000d20c33a7
    [  388.967742] sr 5:0:0:0: [sr0] tag#0 CDB: ATA command pass through(12)/Blank a1 11 00 00 00 00 00 00 00 00 00 00
    [  388.967773] sr 5:0:0:0: [sr0] tag#0 Done: SUCCESS Result: hostbyte=DID_TARGET_FAILURE driverbyte=DRIVER_OK cmd_age=0s
    [  388.967773] sr 5:0:0:0: [sr0] tag#0 CDB: ATA command pass through(12)/Blank a1 11 00 00 00 00 00 00 00 00 00 00
    [  388.967803] sr 5:0:0:0: [sr0] tag#0 Sense Key : Illegal Request [current]
    [  388.967803] sr 5:0:0:0: [sr0] tag#0 Add. Sense: Invalid field in cdb
    [  388.967803] sr 5:0:0:0: [sr0] tag#0 scsi host busy 1 failed 0
    [  388.967803] sr 5:0:0:0: Notifying upper driver of completion (result 8100002)
    [  388.967834] sr 5:0:0:0: [sr0] tag#0 0 sectors total, 0 bytes done.
    
    For the EL-R12 standard optical drive, all operational commands
    and usage scenarios were tested without adding the IGNORE_RESIDUE quirks,
    and no issues were encountered. It can be reasonably concluded
    that removing the IGNORE_RESIDUE quirks has no impact.
    
    Signed-off-by: Chen Changcheng <[email protected]>
    Link: https://patch.msgid.link/[email protected]
    Signed-off-by: Greg Kroah-Hartman <[email protected]>
    Signed-off-by: Sasha Levin <[email protected]>
drivers/usb/storage/unusual_uas.h +1 -1
index 1477e31d7763..b695f5ba9a40 100644
@@ -98,7 +98,7 @@ UNUSUAL_DEV(0x125f, 0xa94a, 0x0160, 0x0160,
 		US_FL_NO_ATA_1X),
 
 /* Reported-by: Benjamin Tissoires <[email protected]> */
-UNUSUAL_DEV(0x13fd, 0x3940, 0x0000, 0x9999,
+UNUSUAL_DEV(0x13fd, 0x3940, 0x0309, 0x0309,
 		"Initio Corporation",
 		"INIC-3069",
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
maintainer Applied
#2 lore raw
Quoted 15 lines · Alan Stern
Quoted 7 lines · Sasha Levin

This is a note to let you know that I've just added the patch titled

usb: usb-storage: No additional quirks need to be added to the EL-R12 optical drive.

to the 6.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 6 lines

The filename of the patch is:
usb-usb-storage-no-additional-quirks-need-to-be-adde.patch
and it can be found in the queue-6.18 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 6 lines

This commit will be modified by commit 0831269b5f71 ("usb: usb-storage:
Maintain minimal modifications to the bcdDevice range.") in Greg's usb-linus branch, which has not yet been merged into the mainline kernel. The two commits should be added to the -stable kernels at the same time, if possible, which probably means holding off on this one until the next round.

I've picked this up now, thanks.

greg k-h