Add initial support for Metanoia MT5824 EVB
cover Add initial support for Metanoia MT5824 EVB
- Add RISC-V target for MT5824
- Add board defconfig and DTS for MT5824 EVB
- Add SPL and U-Boot board support for MT5824 EVB
- Add DDR init for MT5824 EVB
Jun Chang (1):
board: mt5824: Add initial support for Metanoia MT5824 EVB
arch/riscv/Kconfig | 4 + arch/riscv/dts/mt5824-evb.dts | 232 +++++++++++++++++ board/metanoia/mt5824/Kconfig | 49 ++++ board/metanoia/mt5824/MAINTAINERS | 7 + board/metanoia/mt5824/Makefile | 7 + board/metanoia/mt5824/lpddr4.h | 91 +++++++ board/metanoia/mt5824/lpddr4_helper.c | 352 ++++++++++++++++++++++++++ board/metanoia/mt5824/lpddr4_init.c | 115 +++++++++ board/metanoia/mt5824/mt5824.c | 188 ++++++++++++++ board/metanoia/mt5824/mt5824.h | 21 ++ board/metanoia/mt5824/mt5824_ddr.c | 54 ++++ board/metanoia/mt5824/mt5824_ddr.h | 12 + board/metanoia/mt5824/mt5824_spl.c | 141 +++++++++++ configs/mt5824_evb_defconfig | 61 +++++ include/configs/mt5824.h | 130 ++++++++++ 15 files changed, 1464 insertions(+) create mode 100644 arch/riscv/dts/mt5824-evb.dts create mode 100644 board/metanoia/mt5824/Kconfig create mode 100644 board/metanoia/mt5824/MAINTAINERS create mode 100644 board/metanoia/mt5824/Makefile create mode 100644 board/metanoia/mt5824/lpddr4.h create mode 100644 board/metanoia/mt5824/lpddr4_helper.c create mode 100644 board/metanoia/mt5824/lpddr4_init.c create mode 100644 board/metanoia/mt5824/mt5824.c create mode 100644 board/metanoia/mt5824/mt5824.h create mode 100644 board/metanoia/mt5824/mt5824_ddr.c create mode 100644 board/metanoia/mt5824/mt5824_ddr.h create mode 100644 board/metanoia/mt5824/mt5824_spl.c create mode 100644 configs/mt5824_evb_defconfig create mode 100644 include/configs/mt5824.h
Signature · 1 line
2.43.0
PATCH 1/1 board: mt5824: Add initial support for Metanoia MT5824 EVB
- Add RISC-V target for MT5824
- Add board defconfig and DTS for MT5824 EVB
- Add SPL and U-Boot board support for MT5824 EVB
- Add DDR init for MT5824 EVB
--- arch/riscv/Kconfig | 4 + arch/riscv/dts/mt5824-evb.dts | 232 +++++++++++++++++ board/metanoia/mt5824/Kconfig | 49 ++++ board/metanoia/mt5824/MAINTAINERS | 7 + board/metanoia/mt5824/Makefile | 7 + board/metanoia/mt5824/lpddr4.h | 91 +++++++ board/metanoia/mt5824/lpddr4_helper.c | 352 ++++++++++++++++++++++++++ board/metanoia/mt5824/lpddr4_init.c | 115 +++++++++ board/metanoia/mt5824/mt5824.c | 188 ++++++++++++++ board/metanoia/mt5824/mt5824.h | 21 ++ board/metanoia/mt5824/mt5824_ddr.c | 54 ++++ board/metanoia/mt5824/mt5824_ddr.h | 12 + board/metanoia/mt5824/mt5824_spl.c | 141 +++++++++++ configs/mt5824_evb_defconfig | 61 +++++ include/configs/mt5824.h | 130 ++++++++++ 15 files changed, 1464 insertions(+) create mode 100644 arch/riscv/dts/mt5824-evb.dts create mode 100644 board/metanoia/mt5824/Kconfig create mode 100644 board/metanoia/mt5824/MAINTAINERS create mode 100644 board/metanoia/mt5824/Makefile create mode 100644 board/metanoia/mt5824/lpddr4.h create mode 100644 board/metanoia/mt5824/lpddr4_helper.c create mode 100644 board/metanoia/mt5824/lpddr4_init.c create mode 100644 board/metanoia/mt5824/mt5824.c create mode 100644 board/metanoia/mt5824/mt5824.h create mode 100644 board/metanoia/mt5824/mt5824_ddr.c create mode 100644 board/metanoia/mt5824/mt5824_ddr.h create mode 100644 board/metanoia/mt5824/mt5824_spl.c create mode 100644 configs/mt5824_evb_defconfig create mode 100644 include/configs/mt5824.h
arch/riscv/Kconfig +4 -0
@@ -23,6 +23,9 @@ config TARGET_K230_CANMV config TARGET_LICHEERV_NANO bool "Support LicheeRV Nano Board" +config TARGET_METANOIA_MT5824 + bool "Support Metanoia MT5824 Chipset" + config TARGET_MICROCHIP_GENERIC bool "Support Microchip PolarFire-SoC Boards"
@@ -108,6 +111,7 @@ source "board/andestech/voyager/Kconfig" source "board/aspeed/ibex_ast2700/Kconfig" source "board/canaan/k230_canmv/Kconfig" source "board/emulation/qemu-riscv/Kconfig" +source "board/metanoia/mt5824/Kconfig" source "board/microchip/mpfs_generic/Kconfig" source "board/openpiton/riscv64/Kconfig" source "board/sifive/unleashed/Kconfig"
arch/riscv/dts/mt5824-evb.dts new file +232 -0
232 lines not on this page · raw message
board/metanoia/mt5824/Kconfig new file +49 -0
49 lines not on this page · raw message
board/metanoia/mt5824/MAINTAINERS new file +7 -0
@@ -0,0 +1,7 @@ +Metanoia MT5824 EVB +M: Jun Chang <[email protected]> +S: Maintained +F: board/metanoia/mt5824/ +F: include/configs/mt5824.h +F: configs/mt5824_evb_defconfig +F: arch/riscv/dts/mt5824-evb.dts
board/metanoia/mt5824/Makefile new file +7 -0
@@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0+ +# +# Copyright (C) 2025 Metanoia Communications Inc., +# Jun Chang, Metanoia Communications Inc. <[email protected]> + +obj-y := mt5824.o +obj-$(CONFIG_SPL_BUILD) += mt5824_spl.o mt5824_ddr.o lpddr4_init.o lpddr4_helper.o
board/metanoia/mt5824/lpddr4.h new file +91 -0
92 lines not on this page · raw message
board/metanoia/mt5824/lpddr4_helper.c new file +352 -0
353 lines not on this page · raw message
board/metanoia/mt5824/lpddr4_init.c new file +115 -0
115 lines not on this page · raw message
board/metanoia/mt5824/mt5824.c new file +188 -0
188 lines not on this page · raw message
board/metanoia/mt5824/mt5824.h new file +21 -0
@@ -0,0 +1,21 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* +* Copyright (C) 2025 Metanoia Communications Inc., +* Jun Chang, Metanoia Communications Inc. <[email protected]> +*/ + +#ifndef __METANOIA_MT5824_H__ +#define __METANOIA_MT5824_H__ + +#include <linux/types.h> + +enum boot_source { +BOOT_SOURCE_RESERVED =0 , +BOOT_SOURCE_QSPI_NOR , +BOOT_SOURCE_SD , +BOOT_SOURCE_EMMC , +}; + +enum boot_source get_boot_src (void ); + +#endif /* __METANOIA_MT5824_H__ */
board/metanoia/mt5824/mt5824_ddr.c new file +54 -0
54 lines not on this page · raw message
board/metanoia/mt5824/mt5824_ddr.h new file +12 -0
@@ -0,0 +1,12 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* +* Copyright (C) 2025 Metanoia Communications Inc., +* Jun Chang, Metanoia Communications Inc. <[email protected]> +*/ + +#ifndef __METANOIA_MT5824_DDR_H__ +#define __METANOIA_MT5824_DDR_H__ + +int mt5824_ddr_init (void ); + +#endif /* __METANOIA_MT5824_DDR_H__ */
board/metanoia/mt5824/mt5824_spl.c new file +141 -0
141 lines not on this page · raw message
configs/mt5824_evb_defconfig new file +61 -0
61 lines not on this page · raw message
include/configs/mt5824.h new file +130 -0
130 lines not on this page · raw message
Signature · 1 line
2.43.0
Re: [PATCH 1/1] board: mt5824: Add initial support for Metanoia MT5824 EVB
Quoted 9 lines · Jun Chang
- Add RISC-V target for MT5824
- Add board defconfig and DTS for MT5824 EVB
- Add SPL and U-Boot board support for MT5824 EVB
- Add DDR init for MT5824 EVBSigned-off-by Jun Chang <[email protected]>--- arch/riscv/Kconfig | 4 + arch/riscv/dts/mt5824-evb.dts | 232 +++++++++++++++++
What is the status on upstreaming this device tree?
[snip]
Quoted 15 lines
board/metanoia/mt5824/lpddr4.h new file +9
-0@@ -0,0 +1,91 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* +* Copyright (C) 2025 Metanoia Communications Inc., +* Jun Chang, Metanoia Communications Inc. <[email protected]> +*/ + +#ifndef __COBRA_DDR_H +#define __COBRA_DDR_H +
board/metanoia/mt5824/lpddr4.h line 19
Quoted 10 lines
board/metanoia/mt5824/lpddr4.h new file +10
-0+#include <asm/io.h> + +#define UMCTL2_REGS_BASE_ADDR 0x10060000 + +#define reg8_write (addr, data) \ + writeb((uint8_t)(data), (volatile void __iomem *)(addr)) +#define reg16_write (addr, data) \ + writew((uint16_t)(data), (volatile void __iomem *)(addr)) +#define reg32_write (addr, data) \ + writel((uint32_t)(data), (volatile void __iomem *)(addr))
We really don't already have an appropriate macro here to use?
[snip]
board/metanoia/mt5824/lpddr4.h line 91
Quoted 2 lines
board/metanoia/mt5824/lpddr4.h new file +1
-0+#endif /* __COBRA_DDR_H */
Please fix that globally.
Quoted 5 lines
board/metanoia/mt5824/lpddr4_helper.c new file +0
-0
[snip]
board/metanoia/mt5824/lpddr4_helper.c line 224
Quoted 5 lines
board/metanoia/mt5824/lpddr4_helper.c new file +5
-0+#if 0 /* Enable for debugging */ +if (i <10 ) { +printf (" [%02d] 0x%08x = 0x%08x\n" , i, reg_addr, reg_value); + } +#endif
Just use debug() here? And remove other "if 0" or commented out code globally.
[snip]
Quoted 20 lines
board/metanoia/mt5824/mt5824.c new file +14
-0@@ -0,0 +1,188 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* +* Copyright (C) 2025 Metanoia Communications Inc., +* Jun Chang, Metanoia Communications Inc. <[email protected]> +*/ + +#include <log.h> +#include <asm/csr.h> +#include <asm/sbi.h> +#include <config.h> +#include <cpu_func.h> +#include <image.h> +#include <init.h> +#include <net.h>
board/metanoia/mt5824/mt5824.c line 24
Quoted 10 lines
board/metanoia/mt5824/mt5824.c new file +10
-0+#include <asm/global_data.h> +#include <linux/io.h> +#include <fdtdec.h> +#include <dm.h> +#include <hang.h> +#include <misc.h> +#include <hexdump.h> +#include <env_internal.h> +#include <linux/delay.h> +#include <asm/io.h>
Globally, please audit your include list.
[snip]
configs/mt5824_evb_defconfig line 5
Quoted 11 lines
configs/mt5824_evb_defconfig new file +5
-0@@ -0,0 +1,61 @@ +CONFIG_RISCV=y +CONFIG_RISCV_ANDES=y +CONFIG_ARCH_RV64I=y +CONFIG_RISCV_SMODE=y +
Please re-generate this with "make savedefconfig".
[snip]
Quoted 5 lines
include/configs/mt5824.h new file +0
-0
[snip]
Quoted 46 lines
include/configs/mt5824.h new file +46
-0+/* environments */ + +/* SPI FLASH */ + +/* +* For booting Linux, the board info and command line data +* have to be in the first 16 MB of memory, since this is +* the maximum mapped by the Linux kernel during initialization. +*/ + +/* Initial Memory map for Linux*/ +#define CFG_SYS_BOOTMAPSZ (64 << 20) +/* Increase max gunzip size */ + +/* Support autoboot from RAM (kernel image is loaded via debug port) */ +#define BOOTENV_DEV_NAME_RAM (devtypeu, devtypel, instance) \ + "ram " + +#define BOOTENV_DEV_RAM (devtypeu, devtypel, instance) \ + "bootcmd_ram=" \ + "bootm ${fit_addr}\0" + +#define BOOTENV_DEV_LEGACY_MMC (devtypeu, devtypel, instance) \ + "bootcmd_" #devtypel #instance "=" \ + "setenv mmcdev " #instance"; "\ + "setenv bootpart " #instance":2 ; "\ + "run mmcboot\0" + +#define BOOTENV_DEV_NAME_LEGACY_MMC (devtypeu, devtypel, instance) \ + #devtypel #instance " " + +#define BOOTENV_DEV_NAME_TFTP (devtypeu, devtypel, instance) \ + #devtypel " " + +#define BOOTENV_DEV_TFTP (devtypeu, devtypel, instance) \ + "bootcmd_" #devtypel "=" \ + "tftpboot ${fit_addr} $serverip:fitImage-dev-image-initramfs; " \ + "bootm ${fit_addr}\0" + +/* Enable distro boot */ +#define BOOT_TARGET_DEVICES (func) \ + func(TFTP, tftp, na) \ + func(RAM, ram, na) + +#include <config_distro_bootcmd.h> +
include/configs/mt5824.h line 119
Quoted 10 lines
include/configs/mt5824.h new file +10
-0+#define CFG_EXTRA_ENV_SETTINGS \ + "bootcmd=bootm 90000000\0" \ + "kernel_addr_r=82000000\0" \ + "pxefile_addr_r=0x83f00000\0" \ + "scriptaddr=0x83f00000\0" \ + "fdt_addr_r=0x68010000\0" \ + "ramdisk_addr_r=0x83000000\0" \ + "fit_addr=0x83000000\0" \ + "initrd_high=0x100000000\0" \ + BOOTENV
Please switch to plain text environment and consider standard boot, thanks.
Signature · 1 line
Tom
Re: [PATCH 1/1] board: mt5824: Add initial support for Metanoia MT5824 EVB
Quoted 7 lines · Tom Rini
Quoted 5 lines · Jun Chang
- Add RISC-V target for MT5824
- Add board defconfig and DTS for MT5824 EVB
- Add SPL and U-Boot board support for MT5824 EVB
- Add DDR init for MT5824 EVB
Quoted 6 lines
Quoted 4 lines
Signed-off-by Jun Chang <[email protected]>--- arch/riscv/Kconfig | 4 + arch/riscv/dts/mt5824-evb.dts | 232 +++++++++++++++++What is the status on upstreaming this device tree?
The device tree is able to boot to U-Boot with shell prompt by the JTAG.
Quoted 21 lines
[snip]
Quoted 19 lines
board/metanoia/mt5824/lpddr4.h new file +13
-0@@ -0,0 +1,91 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* +* Copyright (C) 2025 Metanoia Communications Inc., +* Jun Chang, Metanoia Communications Inc. <[email protected]> +*/ + +#ifndef __COBRA_DDR_H +#define __COBRA_DDR_H + +#include <asm/io.h> + +#define UMCTL2_REGS_BASE_ADDR 0x10060000 +
Quoted 8 lines
board/metanoia/mt5824/lpddr4.h line 19
Quoted 6 lines
board/metanoia/mt5824/lpddr4.h new file +6
-0+#define reg8_write (addr, data) \ + writeb((uint8_t)(data), (volatile void __iomem *)(addr)) +#define reg16_write (addr, data) \ + writew((uint16_t)(data), (volatile void __iomem *)(addr)) +#define reg32_write (addr, data) \ + writel((uint32_t)(data), (volatile void __iomem *)(addr))We really don't already have an appropriate macro here to use?
I'll change the macro to the static inline function like arch/arm/include/asm/arch-imx8m/ddr.h does.
Quoted 6 lines
[snip]
Quoted 2 lines
+#endif /*
__COBRA_DDR_H*/
\ No newline at end of filePlease fix that globally.
Got it.
Quoted 7 lines
Quoted 6 lines
board/metanoia/mt5824/lpddr4_helper.c new file +0
-0[snip]
Quoted 8 lines
board/metanoia/mt5824/lpddr4_helper.c line 224
Quoted 5 lines
board/metanoia/mt5824/lpddr4_helper.c new file +5
-0+#if 0 /* Enable for debugging */ +if (i <10 ) { +printf (" [%02d] 0x%08x = 0x%08x\n" , i, reg_addr, reg_value); + } +#endif Just use
debug()here? And remove other "if 0" or commented out code globally.
I'll remove them.
Quoted 26 lines
[snip]
Quoted 24 lines
board/metanoia/mt5824/mt5824.c new file +18
-0@@ -0,0 +1,188 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* +* Copyright (C) 2025 Metanoia Communications Inc., +* Jun Chang, Metanoia Communications Inc. <[email protected]> +*/ + +#include <log.h> +#include <asm/csr.h> +#include <asm/sbi.h> +#include <config.h> +#include <cpu_func.h> +#include <image.h> +#include <init.h> +#include <net.h> +#include <asm/global_data.h> +#include <linux/io.h> +#include <fdtdec.h> +#include <dm.h>
Quoted 8 lines
board/metanoia/mt5824/mt5824.c line 24
Quoted 6 lines
board/metanoia/mt5824/mt5824.c new file +6
-0+#include <hang.h> +#include <misc.h> +#include <hexdump.h> +#include <env_internal.h> +#include <linux/delay.h> +#include <asm/io.h> Globally, please audit your include list.
I'll remove the unnecessary inlcudes for my patch.
Quoted 15 lines
[snip]
configs/mt5824_evb_defconfig line 5
Quoted 11 lines
configs/mt5824_evb_defconfig new file +5
-0@@ -0,0 +1,61 @@ +CONFIG_RISCV=y +CONFIG_RISCV_ANDES=y +CONFIG_ARCH_RV64I=y +CONFIG_RISCV_SMODE=y +Please re-generate this with "make savedefconfig".
Thanks for the command. I'll re-generate the defconfig.
Quoted 59 lines
[snip]
Quoted 5 lines
include/configs/mt5824.h new file +0
-0[snip]
Quoted 51 lines
include/configs/mt5824.h new file +51
-0+/* environments */ + +/* SPI FLASH */ + +/* +* For booting Linux, the board info and command line data +* have to be in the first 16 MB of memory, since this is +* the maximum mapped by the Linux kernel during initialization. +*/ + +/* Initial Memory map for Linux*/ +#define CFG_SYS_BOOTMAPSZ (64 << 20) +/* Increase max gunzip size */ + +/* Support autoboot from RAM (kernel image is loaded via debug port) */ +#define BOOTENV_DEV_NAME_RAM (devtypeu, devtypel, instance) \ + "ram " + +#define BOOTENV_DEV_RAM (devtypeu, devtypel, instance) \ + "bootcmd_ram=" \ + "bootm ${fit_addr}\0" + +#define BOOTENV_DEV_LEGACY_MMC (devtypeu, devtypel, instance) \ + "bootcmd_" #devtypel #instance "=" \ + "setenv mmcdev " #instance"; "\ + "setenv bootpart " #instance":2 ; "\ + "run mmcboot\0" + +#define BOOTENV_DEV_NAME_LEGACY_MMC (devtypeu, devtypel, instance) \ + #devtypel #instance " " + +#define BOOTENV_DEV_NAME_TFTP (devtypeu, devtypel, instance) \ + #devtypel " " + +#define BOOTENV_DEV_TFTP (devtypeu, devtypel, instance) \ + "bootcmd_" #devtypel "=" \ + "tftpboot ${fit_addr} $serverip:fitImage-dev-image-initramfs; " \ + "bootm ${fit_addr}\0" + +/* Enable distro boot */ +#define BOOT_TARGET_DEVICES (func) \ + func(TFTP, tftp, na) \ + func(RAM, ram, na) + +#include <config_distro_bootcmd.h> + +#define CFG_EXTRA_ENV_SETTINGS \ + "bootcmd=bootm 90000000\0" \ + "kernel_addr_r=82000000\0" \ + "pxefile_addr_r=0x83f00000\0" \ + "scriptaddr=0x83f00000\0" \
Quoted 9 lines
include/configs/mt5824.h line 119
Quoted 5 lines
include/configs/mt5824.h new file +5
-0+"fdt_addr_r=0x68010000\0" \ +"ramdisk_addr_r=0x83000000\0" \ +"fit_addr=0x83000000\0" \ +"initrd_high=0x100000000\0" \ +BOOTENV Please switch to plain text environment and consider standard boot, thanks.
I'll clean up the config include to remove env settings and support the NOR flash boot.
Re: [PATCH 1/1] board: mt5824: Add initial support for Metanoia MT5824 EVB
Quoted 8 lines · Jun Chang
Quoted 7 lines · Tom Rini
Quoted 5 lines · Jun Chang
- Add RISC-V target for MT5824
- Add board defconfig and DTS for MT5824 EVB
- Add SPL and U-Boot board support for MT5824 EVB
- Add DDR init for MT5824 EVB
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Signed-off-by Jun Chang <[email protected]>--- arch/riscv/Kconfig | 4 + arch/riscv/dts/mt5824-evb.dts | 232 +++++++++++++++++What is the status on upstreaming this device tree?
The device tree is able to boot to U-Boot with shell prompt by the JTAG.
Since I wasn't clear enough, I meant the status on getting this in the linux kernel tree so that OF_UPSTREAM can be enabled and we use the copy found under dts/upstream/src/riscv instead.
Signature · 1 line
Tom
Re: [PATCH 1/1] board: mt5824: Add initial support for Metanoia MT5824 EVB
Quoted 14 lines · Tom Rini
Quoted 13 lines · Jun Chang
Quoted 12 lines · Tom Rini
Quoted 9 lines · Jun Chang
- Add RISC-V target for MT5824
- Add board defconfig and DTS for MT5824 EVB
- Add SPL and U-Boot board support for MT5824 EVB
- Add DDR init for MT5824 EVBSigned-off-by Jun Chang <[email protected]>--- arch/riscv/Kconfig | 4 + arch/riscv/dts/mt5824-evb.dts | 232 +++++++++++++++++
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
What is the status on upstreaming this device tree?
The device tree is able to boot to U-Boot with shell prompt by the JTAG.
Since I wasn't clear enough, I meant the status on getting this in the linux kernel tree so that
OF_UPSTREAMcan be enabled and we use the copy found under dts/upstream/src/riscv instead.
Thanks for the clarification.
The device tree for Linux kernel is not yet submitted to the upstream. We would like to go with the U-Boot first.
Re: [PATCH 1/1] board: mt5824: Add initial support for Metanoia MT5824 EVB
Quoted 24 lines · Jun Chang
Quoted 14 lines · Tom Rini
Quoted 13 lines · Jun Chang
Quoted 12 lines · Tom Rini
Quoted 9 lines · Jun Chang
- Add RISC-V target for MT5824
- Add board defconfig and DTS for MT5824 EVB
- Add SPL and U-Boot board support for MT5824 EVB
- Add DDR init for MT5824 EVBSigned-off-by Jun Chang <[email protected]>--- arch/riscv/Kconfig | 4 + arch/riscv/dts/mt5824-evb.dts | 232 +++++++++++++++++Quoted 8 lines
Quoted 3 lines
Quoted 1 line
What is the status on upstreaming this device tree?
The device tree is able to boot to U-Boot with shell prompt by the JTAG.
Since I wasn't clear enough, I meant the status on getting this in the linux kernel tree so that
OF_UPSTREAMcan be enabled and we use the copy found under dts/upstream/src/riscv instead.
Quoted 4 lines
Thanks for the clarification.
The device tree for Linux kernel is not yet submitted to the upstream. We would like to go with the U-Boot first.
It will need to be migrated over to OF_UPSTREAM and really should not just say in U-Boot only. Have you at least started the process internally and for example run "make CHECK_DTBS=1" in the kernel on this to catch obvious problems?
Signature · 1 line
Tom
Re: [PATCH 1/1] board: mt5824: Add initial support for Metanoia MT5824 EVB
Quoted 27 lines · Tom Rini
Quoted 26 lines · Jun Chang
Quoted 14 lines · Tom Rini
Quoted 13 lines · Jun Chang
Quoted 12 lines · Tom Rini
Quoted 9 lines · Jun Chang
- Add RISC-V target for MT5824
- Add board defconfig and DTS for MT5824 EVB
- Add SPL and U-Boot board support for MT5824 EVB
- Add DDR init for MT5824 EVBSigned-off-by Jun Chang <[email protected]>--- arch/riscv/Kconfig | 4 + arch/riscv/dts/mt5824-evb.dts | 232 +++++++++++++++++Quoted 8 lines
Quoted 3 lines
Quoted 1 line
What is the status on upstreaming this device tree?
The device tree is able to boot to U-Boot with shell prompt by the JTAG.
Since I wasn't clear enough, I meant the status on getting this in the linux kernel tree so that
OF_UPSTREAMcan be enabled and we use the copy found under dts/upstream/src/riscv instead.Thanks for the clarification.
Quoted 8 lines
Quoted 2 lines
The device tree for Linux kernel is not yet submitted to the upstream. We would like to go with the U-Boot first.
It will need to be migrated over to
OF_UPSTREAMand really should not just say in U-Boot only. Have you at least started the process internally and for example run "make CHECK_DTBS=1" in the kernel on this to catch obvious problems?
We will send a full functional and verified device tree to the U-Boot in the next patch. When our device tree patch be accepted by Linux kernel, it will be migrated over to OF_UPSTREAM.
Re: [PATCH 1/1] board: mt5824: Add initial support for Metanoia MT5824 EVB
Quoted 31 lines · Jun Chang
Quoted 30 lines · Tom Rini
Quoted 28 lines · Jun Chang
Quoted 14 lines · Tom Rini
Quoted 13 lines · Jun Chang
Quoted 12 lines · Tom Rini
Quoted 9 lines · Jun Chang
- Add RISC-V target for MT5824
- Add board defconfig and DTS for MT5824 EVB
- Add SPL and U-Boot board support for MT5824 EVB
- Add DDR init for MT5824 EVBSigned-off-by Jun Chang <[email protected]>--- arch/riscv/Kconfig | 4 + arch/riscv/dts/mt5824-evb.dts | 232 +++++++++++++++++Quoted 8 lines
Quoted 3 lines
Quoted 1 line
What is the status on upstreaming this device tree?
The device tree is able to boot to U-Boot with shell prompt by the JTAG.
Since I wasn't clear enough, I meant the status on getting this in the linux kernel tree so that
OF_UPSTREAMcan be enabled and we use the copy found under dts/upstream/src/riscv instead.Thanks for the clarification.
The device tree for Linux kernel is not yet submitted to the upstream. We would like to go with the U-Boot first.
Quoted 8 lines
Quoted 5 lines
It will need to be migrated over to
OF_UPSTREAMand really should not just say in U-Boot only. Have you at least started the process internally and for example run "make CHECK_DTBS=1" in the kernel on this to catch obvious problems?We will send a full functional and verified device tree to the U-Boot in the next patch. When our device tree patch be accepted by Linux kernel, it will be migrated over to
OF_UPSTREAM.
Sounds good, thanks!
Signature · 1 line
Tom