Skip to contentSkip to conversation

ASoC: es8328: Remove duplicate DAPM routes

PATCH In review Hsieh Hung-En 2 participants 2 messages Dec 31, 2025 – Jan 6

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: es8328: Remove duplicate DAPM routes

The DAPM routes for "Left Line Mux" and "Right Line Mux" are defined twice in es8328_dapm_routes[]. The redundant entries appear after the "Mic Bias" route and duplicate the definitions found earlier in the array.

Remove the duplicate entries to clean up the code.

Tested on Rockchip RK3588 with ES8328 codec. Verified that removing the duplicate routes does not alter the DAPM graph or the mixer controls. Both 'tinymix' output and DAPM widget lists remain identical to the baseline.

---
 sound/soc/codecs/es8328.c | 10 ----------
 1 file changed, 10 deletions(-)
sound/soc/codecs/es8328.c +0 -10
index 1e11175cfbbb..bd74e896d602 100644
@@ -406,16 +406,6 @@ static const struct snd_soc_dapm_route es8328_dapm_routes[] = {
 
 	{ "Mic Bias", NULL, "Mic Bias Gen" },
 
-	{ "Left Line Mux", "Line 1", "LINPUT1" },
-	{ "Left Line Mux", "Line 2", "LINPUT2" },
-	{ "Left Line Mux", "PGA", "Left PGA Mux" },
-	{ "Left Line Mux", "Differential", "Differential Mux" },
-
-	{ "Right Line Mux", "Line 1", "RINPUT1" },
-	{ "Right Line Mux", "Line 2", "RINPUT2" },
-	{ "Right Line Mux", "PGA", "Right PGA Mux" },
-	{ "Right Line Mux", "Differential", "Differential Mux" },
-
 	{ "Left Mixer", NULL, "Left DAC" },
 	{ "Left Mixer", "Left Bypass Switch", "Left Line Mux" },
 	{ "Left Mixer", "Right Playback Switch", "Right DAC" },
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 8 lines · Hsieh Hung-En

The DAPM routes for "Left Line Mux" and "Right Line Mux" are defined twice in es8328_dapm_routes[]. The redundant entries appear after the "Mic Bias" route and duplicate the definitions found earlier in the array.

Remove the duplicate entries to clean up the code.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: es8328: Remove duplicate DAPM routes

      commit: 52ddc0106c77ff0eacf07b309833ae6e6a4e8587

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark