Skip to contentSkip to conversation

net/nfb: remove unused flag

PATCH Applied Stephen Hemminger 2 participants 5 messages Jan 1 – Jan 12 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 net/nfb: remove unused flag

The configure callback does use the device argument.

---
 drivers/net/nfb/nfb_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/nfb/nfb_ethdev.c +1 -1
index 98119d70fd..5f1b11a961 100644
@@ -181,7 +181,7 @@ nfb_eth_dev_stop(struct rte_eth_dev *dev)
  *   0 on success, a negative errno value otherwise.
  */
 static int
-nfb_eth_dev_configure(struct rte_eth_dev *dev __rte_unused)
+nfb_eth_dev_configure(struct rte_eth_dev *dev)
 {
 	int ret;
 	struct pmd_internals *internals = dev->data->dev_private;
Signature · 1 line
2.51.0
#1 lore raw

PATCH 2/2 net/af_packet: remove unused attribute

The device configure callback does use the device argument.

---
 drivers/net/af_packet/rte_eth_af_packet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/af_packet/rte_eth_af_packet.c +1 -1
index ef11b8fb6b..c0ba3381ea 100644
@@ -374,7 +374,7 @@ eth_dev_stop(struct rte_eth_dev *dev)
 }
 
 static int
-eth_dev_configure(struct rte_eth_dev *dev __rte_unused)
+eth_dev_configure(struct rte_eth_dev *dev)
 {
 	struct rte_eth_conf *dev_conf = &dev->data->dev_conf;
 	const struct rte_eth_rxmode *rxmode = &dev_conf->rxmode;
Signature · 1 line
2.51.0
author Applied
#3 lore raw
In reply to Stephen Hemminger
Quoted 12 lines · On Thu, 1 Jan 2026 10:13:43 -0800 Stephen Hemminger…

The configure callback does use the device argument.

---
 drivers/net/nfb/nfb_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/nfb/nfb_ethdev.c +0 -0
index 98119d70fd..5f1b11a961 100644

drivers/net/nfb/nfb_ethdev.c nfb_eth_dev_stop(struct rte_eth_dev *dev) · line 187

Quoted 8 lines
drivers/net/nfb/nfb_ethdev.c +1 -1
@@ -181,7 +181,7 @@ nfb_eth_dev_stop(struct rte_eth_dev *dev)
  *   0 on success, a negative errno value otherwise.
  */
 static int
-nfb_eth_dev_configure(struct rte_eth_dev *dev __rte_unused)
+nfb_eth_dev_configure(struct rte_eth_dev *dev)
 {
 	int ret;
 	struct pmd_internals *internals = dev->data->dev_private;

Queued to next-net