Skip to contentSkip to conversation

asus-armoury: add support for GA403WM and improve GA403U

PATCH In review Denis Benato 2 participants 5 messages Jan 3 – Jan 5 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

cover asus-armoury: add support for GA403WM and improve GA403U

Hi all,

Happy new year! This series adds support for the ASUS ROG Zephyrus G14 GA403WM
model: the previous patch for GA403WM has probably slipped through because of me sending it as soon as I could and users adding models with only a few hours sifference from each other.

In addition I noticed people sending more GA403U ppt values: they are the same as GA403UI, but I want to be on the safe side so GA403U is now matching only GA403UI and I have added a new entry for GA403UV.

Denis Benato (3):
platform/x86: asus-armoury: add support for GA403WM
asus-armoury: fix ppt data for GA403U* renaming to GA403UI platform/x86: asus-armoury: add support for GA403UV

 drivers/platform/x86/asus-armoury.h | 66 ++++++++++++++++++++++++++++-
 1 file changed, 65 insertions(+), 1 deletion(-)
Signature · 1 line
2.52.0
#1 lore raw

PATCH 1/3 platform/x86: asus-armoury: add support for GA403WM

Add TDP data for laptop model GA403WM.

---
 drivers/platform/x86/asus-armoury.h | 32 +++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
drivers/platform/x86/asus-armoury.h +32 -0
index 3ac7aea37838..8184107e565f 100644
@@ -905,6 +905,38 @@ static const struct dmi_system_id power_limits[] = {
 			.requires_fan_curve = true,
 		},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GA403WM"),
+		},
+		.driver_data = &(struct power_data) {
+			.ac_data = &(struct power_limits) {
+				.ppt_pl1_spl_min = 15,
+				.ppt_pl1_spl_max = 80,
+				.ppt_pl2_sppt_min = 25,
+				.ppt_pl2_sppt_max = 80,
+				.ppt_pl3_fppt_min = 35,
+				.ppt_pl3_fppt_max = 80,
+				.nv_dynamic_boost_min = 0,
+				.nv_dynamic_boost_max = 15,
+				.nv_temp_target_min = 75,
+				.nv_temp_target_max = 87,
+				.nv_tgp_min = 55,
+				.nv_tgp_max = 85,
+			},
+			.dc_data = &(struct power_limits) {
+				.ppt_pl1_spl_min = 15,
+				.ppt_pl1_spl_max = 35,
+				.ppt_pl2_sppt_min = 25,
+				.ppt_pl2_sppt_max = 35,
+				.ppt_pl3_fppt_min = 35,
+				.ppt_pl3_fppt_max = 65,
+				.nv_temp_target_min = 75,
+				.nv_temp_target_max = 87,
+			},
+			.requires_fan_curve = true,
+		},
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_BOARD_NAME, "GA503QR"),
Signature · 1 line
2.52.0
#2 lore raw

PATCH 2/3 asus-armoury: fix ppt data for GA403U* renaming to GA403UI

In reply to Denis Benato

As some GA403U may have different limits restrict the DMI match to the specific GA403UI model.

Fixes 39ae6c50e599 ("platform/x86: asus-armoury: add ppt_* and nv_* tuning knobs")
---
 drivers/platform/x86/asus-armoury.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/asus-armoury.h +1 -1
index 8184107e565f..774aa696be4e 100644
@@ -843,7 +843,7 @@ static const struct dmi_system_id power_limits[] = {
 	},
 	{
 		.matches = {
-			DMI_MATCH(DMI_BOARD_NAME, "GA403U"),
+			DMI_MATCH(DMI_BOARD_NAME, "GA403UI"),
 		},
 		.driver_data = &(struct power_data) {
 			.ac_data = &(struct power_limits) {
Signature · 1 line
2.52.0
#3 lore raw

PATCH 3/3 platform/x86: asus-armoury: add support for GA403UV

In reply to Denis Benato

Add TDP data for laptop model GA403UV.

---
 drivers/platform/x86/asus-armoury.h | 32 +++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
drivers/platform/x86/asus-armoury.h +32 -0
index 774aa696be4e..bc8fb54c4af0 100644
@@ -873,6 +873,38 @@ static const struct dmi_system_id power_limits[] = {
 			.requires_fan_curve = true,
 		},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "GA403UV"),
+		},
+		.driver_data = &(struct power_data) {
+			.ac_data = &(struct power_limits) {
+				.ppt_pl1_spl_min = 15,
+				.ppt_pl1_spl_max = 80,
+				.ppt_pl2_sppt_min = 25,
+				.ppt_pl2_sppt_max = 80,
+				.ppt_pl3_fppt_min = 35,
+				.ppt_pl3_fppt_max = 80,
+				.nv_dynamic_boost_min = 5,
+				.nv_dynamic_boost_max = 25,
+				.nv_temp_target_min = 75,
+				.nv_temp_target_max = 87,
+				.nv_tgp_min = 55,
+				.nv_tgp_max = 65,
+			},
+			.dc_data = &(struct power_limits) {
+				.ppt_pl1_spl_min = 15,
+				.ppt_pl1_spl_max = 35,
+				.ppt_pl2_sppt_min = 25,
+				.ppt_pl2_sppt_max = 35,
+				.ppt_pl3_fppt_min = 35,
+				.ppt_pl3_fppt_max = 65,
+				.nv_temp_target_min = 75,
+				.nv_temp_target_max = 87,
+			},
+			.requires_fan_curve = true,
+		},
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_BOARD_NAME, "GA403WR"),
Signature · 1 line
2.52.0
maintainer
#4 lore raw
In reply to Denis Benato
Quoted 10 lines · Denis Benato

Happy new year! This series adds support for the ASUS ROG Zephyrus G14 GA403WM
model: the previous patch for GA403WM has probably slipped through because of me sending it as soon as I could and users adding models with only a few hours sifference from each other.

In addition I noticed people sending more GA403U ppt values: they are the same as GA403UI, but I want to be on the safe side so GA403U is now matching only GA403UI and I have added a new entry for GA403UV.

[...]

Thank you for your contribution, it has been applied to my local review-ilpo-fixes branch. Note it will show up in the public platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my local branch there, which might take a while.

The list of commits applied:
[1/3] platform/x86: asus-armoury: add support for GA403WM

      commit: f5fc40734b0fcd356eabb8ab5abd57b80c286da6
[2/3] asus-armoury: fix ppt data for GA403U* renaming to GA403UI
      commit: 487764a514e97e3b921c4eb13ab35920e09f6b7d
[3/3] platform/x86: asus-armoury: add support for GA403UV
      commit: a54e9902e7edf74d0f305fb9107d15daa6549c2c

--
i.