rcu-tasks: Remove unnecessary smp_store_release() in cblist_init_generic()
Zqiang
reviewerPATCH v2 1/1 rcu-tasks: Remove unnecessary smp_store_release() in cblist_init_generic()
The cblist_init_generic() is executed during the CPU early boot phase due to commit:30ef09635b9e ("rcu-tasks: Initialize callback lists at rcu_init() time"), at this time, only one boot CPU is online and the irq is disabled. this commit therefore use routine assignment replace of smp_store_release() and WRITE_ONCE() in the cblist_init_generic().
--- kernel/rcu/tasks.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/rcu/tasks.h +3 -3
@@ -290,9 +290,9 @@ static void cblist_init_generic(struct rcu_tasks *rtp) shift =ilog2 (rcu_task_cpu_ids / lim);if (((rcu_task_cpu_ids -1 ) >> shift) >= lim) shift++; -WRITE_ONCE (rtp->percpu_enqueue_shift, shift); -WRITE_ONCE (rtp->percpu_dequeue_lim, lim); -smp_store_release (&rtp->percpu_enqueue_lim, lim); + rtp->percpu_enqueue_shift = shift; + rtp->percpu_dequeue_lim = lim; + rtp->percpu_enqueue_lim = lim; pr_info("%s: Setting shift to %d and lim to %d rcu_task_cb_adjust=%d rcu_task_cpu_ids=%d.\n", rtp->name, data_race(rtp->percpu_enqueue_shift), data_race(rtp->percpu_enqueue_lim),
Signature · 1 line
2.48.1
Quoted 8 lines · Zqiang
The
cblist_init_generic()is executed during the CPU early boot phase due to commit:30ef09635b9e ("rcu-tasks: Initialize callback lists atrcu_init()time"), at this time, only one boot CPU is online and the irq is disabled. this commit therefore use routine assignment replace ofsmp_store_release()andWRITE_ONCE()in thecblist_init_generic().Signed-off-by Zqiang <[email protected]>
Very good!
Quoted 24 lines
--- kernel/rcu/tasks.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)kernel/rcu/tasks.h +3
-3@@ -290,9 +290,9 @@ static void cblist_init_generic(struct rcu_tasks *rtp) shift =ilog2 (rcu_task_cpu_ids / lim);if (((rcu_task_cpu_ids -1 ) >> shift) >= lim) shift++; -WRITE_ONCE (rtp->percpu_enqueue_shift, shift); -WRITE_ONCE (rtp->percpu_dequeue_lim, lim); -smp_store_release (&rtp->percpu_enqueue_lim, lim); + rtp->percpu_enqueue_shift = shift; + rtp->percpu_dequeue_lim = lim; + rtp->percpu_enqueue_lim = lim; pr_info("%s: Setting shift to %d and lim to %d rcu_task_cb_adjust=%d rcu_task_cpu_ids=%d.\n", rtp->name, data_race(rtp->percpu_enqueue_shift), data_race(rtp->percpu_enqueue_lim),Signature · 1 line
2.48.1
Joel Fernandes
maintainerQuoted 8 lines · Zqiang
The
cblist_init_generic()is executed during the CPU early boot phase due to commit:30ef09635b9e ("rcu-tasks: Initialize callback lists atrcu_init()time"), at this time, only one boot CPU is online and the irq is disabled. this commit therefore use routine assignment replace ofsmp_store_release()andWRITE_ONCE()in thecblist_init_generic().Signed-off-by Zqiang <[email protected]>
Applied for 7.1 with Paul's tag. Thanks!
--
Joel Fernandes
Quoted 24 lines
--- kernel/rcu/tasks.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)kernel/rcu/tasks.h +3
-3@@ -290,9 +290,9 @@ static void cblist_init_generic(struct rcu_tasks *rtp) shift =ilog2 (rcu_task_cpu_ids / lim);if (((rcu_task_cpu_ids -1 ) >> shift) >= lim) shift++; -WRITE_ONCE (rtp->percpu_enqueue_shift, shift); -WRITE_ONCE (rtp->percpu_dequeue_lim, lim); -smp_store_release (&rtp->percpu_enqueue_lim, lim); + rtp->percpu_enqueue_shift = shift; + rtp->percpu_dequeue_lim = lim; + rtp->percpu_enqueue_lim = lim; pr_info("%s: Setting shift to %d and lim to %d rcu_task_cb_adjust=%d rcu_task_cpu_ids=%d.\n", rtp->name, data_race(rtp->percpu_enqueue_shift), data_race(rtp->percpu_enqueue_lim),Signature · 1 line
2.48.1