Skip to contentSkip to conversation

arm64: dts: marvell: Add missing "#phy-cells" to "usb-nop-xceiv"

PATCH In review Rob Herring (Arm) 2 participants 2 messages Jan 5 – Jan 7

Subsystems (2)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 arm64: dts: marvell: Add missing "#phy-cells" to "usb-nop-xceiv"

The "usb-nop-xceiv" binding requires "#phy-cells" property with a value of 0 though it is not really used. Add it where missing from Marvell platforms.

---
 arch/arm64/boot/dts/marvell/armada-3720-db.dts                | 1 +
 arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 1 +
 arch/arm64/boot/dts/marvell/armada-8040-db.dts                | 2 ++
 arch/arm64/boot/dts/marvell/cn9130-crb.dtsi                   | 2 ++
 arch/arm64/boot/dts/marvell/cn9130-db.dtsi                    | 2 ++
 arch/arm64/boot/dts/marvell/cn9131-db.dtsi                    | 1 +
 arch/arm64/boot/dts/marvell/cn9132-db.dtsi                    | 2 ++
 7 files changed, 11 insertions(+)
arch/arm64/boot/dts/marvell/armada-3720-db.dts +1 -0
index bd4e61d5448e..06d4a3a93f84 100644
@@ -41,6 +41,7 @@ exp_usb3_vbus: usb3-vbus {
 
 	usb3_phy: usb3-phy {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 		vcc-supply = <&exp_usb3_vbus>;
 	};
 
arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts +1 -0
index 97a180c8dcd9..e82284888b9a 100644
@@ -37,6 +37,7 @@ reg_usb3_vbus: usb3-vbus {
 
 	usb3_phy: usb3-phy {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 		vcc-supply = <&reg_usb3_vbus>;
 	};
 
arch/arm64/boot/dts/marvell/armada-8040-db.dts +2 -0
index 21ecb9c12505..c7102f74d4d5 100644
@@ -51,6 +51,7 @@ cp0_reg_usb3_1_vbus: cp0-usb3-1-vbus {
 
 	cp0_usb3_0_phy: cp0-usb3-0-phy {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 		vcc-supply = <&cp0_reg_usb3_0_vbus>;
 	};
 
@@ -65,6 +66,7 @@ cp1_reg_usb3_0_vbus: cp1-usb3-0-vbus {
 
 	cp1_usb3_0_phy: cp1-usb3-0-phy {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 		vcc-supply = <&cp1_reg_usb3_0_vbus>;
 	};
 };
arch/arm64/boot/dts/marvell/cn9130-crb.dtsi +2 -0
index 5e7d6de3cdde..5689a8bdfd03 100644
@@ -47,10 +47,12 @@ cp0_reg_usb3_vbus1: regulator-2 {
 
 	cp0_usb3_0_phy0: usb-phy-1 {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 	};
 
 	cp0_usb3_0_phy1: usb-phy-2 {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 		vcc-supply = <&cp0_reg_usb3_vbus1>;
 	};
 
arch/arm64/boot/dts/marvell/cn9130-db.dtsi +2 -0
index 3cc320f569ad..7156739aa31a 100644
@@ -50,6 +50,7 @@ cp0_reg_usb3_vbus0: regulator-2 {
 
 	cp0_usb3_0_phy0: usb-phy-1 {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 		vcc-supply = <&cp0_reg_usb3_vbus0>;
 	};
 
@@ -64,6 +65,7 @@ cp0_reg_usb3_vbus1: regulator-3 {
 
 	cp0_usb3_0_phy1: usb-phy-2 {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 		vcc-supply = <&cp0_reg_usb3_vbus1>;
 	};
 
arch/arm64/boot/dts/marvell/cn9131-db.dtsi +1 -0
index 626042fce7e2..26dc91c88677 100644
@@ -31,6 +31,7 @@ cp1_reg_usb3_vbus0: regulator-6 {
 
 	cp1_usb3_0_phy0: usb-phy-3 {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 		vcc-supply = <&cp1_reg_usb3_vbus0>;
 	};
 
arch/arm64/boot/dts/marvell/cn9132-db.dtsi +2 -0
index f91fc69905b8..f82d45e62753 100644
@@ -28,6 +28,7 @@ cp2_reg_usb3_vbus0: regulator-7 {
 
 	cp2_usb3_0_phy0: usb-phy-4 {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 		vcc-supply = <&cp2_reg_usb3_vbus0>;
 	};
 
@@ -42,6 +43,7 @@ cp2_reg_usb3_vbus1: regulator-8 {
 
 	cp2_usb3_0_phy1: usb-phy-5 {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 		vcc-supply = <&cp2_reg_usb3_vbus1>;
 	};
 
Signature · 1 line
2.51.0
maintainer
#1 lore raw
Quoted 5 lines · Rob Herring (Arm)

The "usb-nop-xceiv" binding requires "#phy-cells" property with a value of 0 though it is not really used. Add it where missing from Marvell platforms.

Applied on mvebu/dt64

Thanks,

Gregory

Quoted 126 lines
---
 arch/arm64/boot/dts/marvell/armada-3720-db.dts                | 1 +
 arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 1 +
 arch/arm64/boot/dts/marvell/armada-8040-db.dts                | 2 ++
 arch/arm64/boot/dts/marvell/cn9130-crb.dtsi                   | 2 ++
 arch/arm64/boot/dts/marvell/cn9130-db.dtsi                    | 2 ++
 arch/arm64/boot/dts/marvell/cn9131-db.dtsi                    | 1 +
 arch/arm64/boot/dts/marvell/cn9132-db.dtsi                    | 2 ++
 7 files changed, 11 insertions(+)
arch/arm64/boot/dts/marvell/armada-3720-db.dts +1 -0
index bd4e61d5448e..06d4a3a93f84 100644
@@ -41,6 +41,7 @@ exp_usb3_vbus: usb3-vbus {
 
 	usb3_phy: usb3-phy {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 		vcc-supply = <&exp_usb3_vbus>;
 	};
 
arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts +1 -0
index 97a180c8dcd9..e82284888b9a 100644
@@ -37,6 +37,7 @@ reg_usb3_vbus: usb3-vbus {
 
 	usb3_phy: usb3-phy {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 		vcc-supply = <&reg_usb3_vbus>;
 	};
 
arch/arm64/boot/dts/marvell/armada-8040-db.dts +2 -0
index 21ecb9c12505..c7102f74d4d5 100644
@@ -51,6 +51,7 @@ cp0_reg_usb3_1_vbus: cp0-usb3-1-vbus {
 
 	cp0_usb3_0_phy: cp0-usb3-0-phy {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 		vcc-supply = <&cp0_reg_usb3_0_vbus>;
 	};
 
@@ -65,6 +66,7 @@ cp1_reg_usb3_0_vbus: cp1-usb3-0-vbus {
 
 	cp1_usb3_0_phy: cp1-usb3-0-phy {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 		vcc-supply = <&cp1_reg_usb3_0_vbus>;
 	};
 };
arch/arm64/boot/dts/marvell/cn9130-crb.dtsi +2 -0
index 5e7d6de3cdde..5689a8bdfd03 100644
@@ -47,10 +47,12 @@ cp0_reg_usb3_vbus1: regulator-2 {
 
 	cp0_usb3_0_phy0: usb-phy-1 {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 	};
 
 	cp0_usb3_0_phy1: usb-phy-2 {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 		vcc-supply = <&cp0_reg_usb3_vbus1>;
 	};
 
arch/arm64/boot/dts/marvell/cn9130-db.dtsi +2 -0
index 3cc320f569ad..7156739aa31a 100644
@@ -50,6 +50,7 @@ cp0_reg_usb3_vbus0: regulator-2 {
 
 	cp0_usb3_0_phy0: usb-phy-1 {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 		vcc-supply = <&cp0_reg_usb3_vbus0>;
 	};
 
@@ -64,6 +65,7 @@ cp0_reg_usb3_vbus1: regulator-3 {
 
 	cp0_usb3_0_phy1: usb-phy-2 {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 		vcc-supply = <&cp0_reg_usb3_vbus1>;
 	};
 
arch/arm64/boot/dts/marvell/cn9131-db.dtsi +1 -0
index 626042fce7e2..26dc91c88677 100644
@@ -31,6 +31,7 @@ cp1_reg_usb3_vbus0: regulator-6 {
 
 	cp1_usb3_0_phy0: usb-phy-3 {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 		vcc-supply = <&cp1_reg_usb3_vbus0>;
 	};
 
arch/arm64/boot/dts/marvell/cn9132-db.dtsi +2 -0
index f91fc69905b8..f82d45e62753 100644
@@ -28,6 +28,7 @@ cp2_reg_usb3_vbus0: regulator-7 {
 
 	cp2_usb3_0_phy0: usb-phy-4 {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 		vcc-supply = <&cp2_reg_usb3_vbus0>;
 	};
 
@@ -42,6 +43,7 @@ cp2_reg_usb3_vbus1: regulator-8 {
 
 	cp2_usb3_0_phy1: usb-phy-5 {
 		compatible = "usb-nop-xceiv";
+		#phy-cells = <0>;
 		vcc-supply = <&cp2_reg_usb3_vbus1>;
 	};
 
Signature · 1 line
2.51.0
Signature · 3 lines
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com