FAILED: patch "[PATCH] mm/damon/tests/core-kunit: handle alloc failures in" failed to apply to 6.6-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 6.6-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y
git checkout FETCH_HEAD
git cherry-pick -x 74d5969995d129fd59dd93b9c7daa6669cb6810f
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026010548-consent-fried-e16b@gregkh' --subject-prefix 'PATCH 6.6.y' HEAD^..
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 74d5969995d129fd59dd93b9c7daa6669cb6810f Mon Sep 17 00:00:00 2001
From: SeongJae Park <[email protected]>
Date: Sat, 1 Nov 2025 11:20:04 -0700
Subject: [PATCH] mm/damon/tests/core-kunit: handle alloc failures in
damon_test_set_regions()
damon_test_set_regions() is assuming all dynamic memory allocation in it will succeed. Those are indeed likely in the real use cases since those allocations are too small to fail, but theoretically those could fail. In the case, inappropriate memory access can happen. Fix it by appropriately cleanup pre-allocated memory and skip the execution of the remaining tests in the failure cases.
mm/damon/tests/core-kunit.h +15 -2
@@ -368,13 +368,26 @@ static void damon_test_ops_registration(struct kunit *test)static void damon_test_set_regions (struct kunit *test) {struct damon_target *t =damon_new_target (); -struct damon_region *r1 =damon_new_region (4 ,16 ); -struct damon_region *r2 =damon_new_region (24 ,32 ); +struct damon_region *r1, *r2;struct damon_addr_range range = {.start =8 , .end =28 };unsigned long expects[] = {8 ,16 ,16 ,24 ,24 ,28 };int expect_idx =0 ;struct damon_region *r; +if (!t) +kunit_skip (test,"target alloc fail" ); + r1 =damon_new_region (4 ,16 ); +if (!r1) { +damon_free_target (t); +kunit_skip (test,"region alloc fail" ); + } + r2 =damon_new_region (24 ,32 ); +if (!r2) { +damon_free_target (t); +damon_free_region (r1); +kunit_skip (test,"second region alloc fail" ); + } +damon_add_region (r1, t);damon_add_region (r2, t);damon_set_regions (t, &range,1 ,DAMON_MIN_REGION );
SeongJae Park
maintainerPATCH 1/1 mm/damon/tests/core-kunit: handle alloc failures in damon_test_set_regions()
damon_test_set_regions() is assuming all dynamic memory allocation in it will succeed. Those are indeed likely in the real use cases since those allocations are too small to fail, but theoretically those could fail. In the case, inappropriate memory access can happen. Fix it by appropriately cleanup pre-allocated memory and skip the execution of the remaining tests in the failure cases.
--- mm/damon/core-test.h | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)
mm/damon/core-test.h +15 -2
@@ -270,13 +270,26 @@ static void damon_test_ops_registration(struct kunit *test)static void damon_test_set_regions (struct kunit *test) {struct damon_target *t =damon_new_target (); -struct damon_region *r1 =damon_new_region (4 ,16 ); -struct damon_region *r2 =damon_new_region (24 ,32 ); +struct damon_region *r1, *r2;struct damon_addr_range range = {.start =8 , .end =28 };unsigned long expects[] = {8 ,16 ,16 ,24 ,24 ,28 };int expect_idx =0 ;struct damon_region *r; +if (!t) +kunit_skip (test,"target alloc fail" ); + r1 =damon_new_region (4 ,16 ); +if (!r1) { +damon_free_target (t); +kunit_skip (test,"region alloc fail" ); + } + r2 =damon_new_region (24 ,32 ); +if (!r2) { +damon_free_target (t); +damon_free_region (r1); +kunit_skip (test,"second region alloc fail" ); + } +damon_add_region (r1, t);damon_add_region (r2, t);damon_set_regions (t, &range,1 );
Signature · 1 line
2.47.3