tests/migration-test: Small cleanup series on postcopy tests
cover tests/migration-test: Small cleanup series on postcopy tests
This series removes two unnecessary fields in MigrateCommon that was only for postcopy tests.
Comments welcomed, thanks.
Peter Xu (2):
tests/migration-test: Remove postcopy_data from MigrateCommon tests/migration-test: Remove postcopy_recovery_fail_stage from
MigrateCommon
tests/qtest/migration/framework.h | 7 ++----- tests/qtest/migration/framework.c | 25 ++++++++++++++----------- tests/qtest/migration/postcopy-tests.c | 12 ++++-------- tests/qtest/migration/tls-tests.c | 8 ++++---- 4 files changed, 24 insertions(+), 28 deletions(-)
Signature · 1 line
2.50.1
PATCH 1/2 tests/migration-test: Remove postcopy_data from MigrateCommon
Now postcopy is not the only user of start_hook / end_hook that will pass in a opaque pointer. It doesn't need to be defined in MigrateCommon as part of the framework, as all other hook users can pass hook_data around. Do it too for postcopy.
--- tests/qtest/migration/framework.h | 1 - tests/qtest/migration/framework.c | 18 ++++++++++-------- 2 files changed, 10 insertions(+), 9 deletions(-)
tests/qtest/migration/framework.h +0 -1
@@ -230,7 +230,6 @@ typedef struct {bool live;/* Postcopy specific fields */ -void *postcopy_data;PostcopyRecoveryFailStage postcopy_recovery_fail_stage; } MigrateCommon;
tests/qtest/migration/framework.c +10 -8
@@ -541,6 +541,7 @@ void migrate_end(QTestState *from, QTestState *to, bool test_dest)static int migrate_postcopy_prepare (QTestState **from_ptr,QTestState **to_ptr, +void **hook_data,MigrateCommon *args) {QTestState *from, *to;
@@ -554,7 +555,7 @@ static int migrate_postcopy_prepare(QTestState **from_ptr, }if (args->start_hook) { - args->postcopy_data = args->start_hook (from, to); + *hook_data = args->start_hook (from, to); }migrate_ensure_non_converge (from);
@@ -582,7 +583,7 @@ static int migrate_postcopy_prepare(QTestState **from_ptr, }static void migrate_postcopy_complete (QTestState *from,QTestState *to, -MigrateCommon *args) +void *hook_data,MigrateCommon *args) {MigrationTestEnv *env =migration_get_env ();
@@ -601,8 +602,7 @@ static void migrate_postcopy_complete(QTestState *from, QTestState *to, }if (args->end_hook) { - args->end_hook (from, to, args->postcopy_data); - args->postcopy_data =NULL ; + args->end_hook (from, to, hook_data); }migrate_end (from, to, true);
@@ -610,13 +610,14 @@ static void migrate_postcopy_complete(QTestState *from, QTestState *to,void test_postcopy_common (MigrateCommon *args) { +void *hook_data =NULL ;QTestState *from, *to; -if (migrate_postcopy_prepare (&from, &to, args)) { +if (migrate_postcopy_prepare (&from, &to, &hook_data, args)) {return ; }migrate_postcopy_start (from, to, &src_state); -migrate_postcopy_complete (from, to, args); +migrate_postcopy_complete (from, to, hook_data, args); }static void wait_for_postcopy_status (QTestState *one,const char *status)
@@ -742,6 +743,7 @@ void test_postcopy_recovery_common(MigrateCommon *args) {QTestState *from, *to; g_autofree char *uri = NULL; +void *hook_data =NULL ;/* * Always enable OOB QMP capability for recovery tests, migrate-recover is
@@ -752,7 +754,7 @@ void test_postcopy_recovery_common(MigrateCommon *args)/* Always hide errors for postcopy recover tests since they're expected */ args->start.hide_stderr = true; -if (migrate_postcopy_prepare (&from, &to, args)) { +if (migrate_postcopy_prepare (&from, &to, &hook_data, args)) {return ; }
@@ -808,7 +810,7 @@ void test_postcopy_recovery_common(MigrateCommon *args)/* Restore the postcopy bandwidth to unlimited */ migrate_set_parameter_int (from,"max-postcopy-bandwidth" ,0 ); -migrate_postcopy_complete (from, to, args); +migrate_postcopy_complete (from, to, hook_data, args); }int test_precopy_common (MigrateCommon *args)
Signature · 1 line
2.50.1
Re: [PATCH 1/2] tests/migration-test: Remove postcopy_data from MigrateCommon
Quoted 80 lines · Peter Xu
Now postcopy is not the only user of
start_hook/end_hookthat will pass in a opaque pointer. It doesn't need to be defined in MigrateCommon as part of the framework, as all other hook users can passhook_dataaround. Do it too for postcopy.Signed-off-by Peter Xu <[email protected]>--- tests/qtest/migration/framework.h | 1 - tests/qtest/migration/framework.c | 18 ++++++++++-------- 2 files changed, 10 insertions(+), 9 deletions(-)tests/qtest/migration/framework.h +0
-1@@ -230,7 +230,6 @@ typedef struct {bool live;/* Postcopy specific fields */ -void *postcopy_data;PostcopyRecoveryFailStage postcopy_recovery_fail_stage; } MigrateCommon;tests/qtest/migration/framework.c +7
-6@@ -541,6 +541,7 @@ void migrate_end(QTestState *from, QTestState *to, bool test_dest)static int migrate_postcopy_prepare (QTestState **from_ptr,QTestState **to_ptr, +void **hook_data,MigrateCommon *args) {QTestState *from, *to;@@ -554,7 +555,7 @@ static int migrate_postcopy_prepare(QTestState **from_ptr, }if (args->start_hook) { - args->postcopy_data = args->start_hook (from, to); + *hook_data = args->start_hook (from, to); }migrate_ensure_non_converge (from);@@ -582,7 +583,7 @@ static int migrate_postcopy_prepare(QTestState **from_ptr, }static void migrate_postcopy_complete (QTestState *from,QTestState *to, -MigrateCommon *args) +void *hook_data,MigrateCommon *args) {MigrationTestEnv *env =migration_get_env ();@@ -601,8 +602,7 @@ static void migrate_postcopy_complete(QTestState *from, QTestState *to, }if (args->end_hook) { - args->end_hook (from, to, args->postcopy_data); - args->postcopy_data =NULL ; + args->end_hook (from, to, hook_data); }migrate_end (from, to, true);@@ -610,13 +610,14 @@ static void migrate_postcopy_complete(QTestState *from, QTestState *to,void test_postcopy_common (MigrateCommon *args) { +void *hook_data =NULL ;QTestState *from, *to; -if (migrate_postcopy_prepare (&from, &to, args)) { +if (migrate_postcopy_prepare (&from, &to, &hook_data, args)) {return ; }migrate_postcopy_start (from, to, &src_state); -migrate_postcopy_complete (from, to, args); +migrate_postcopy_complete (from, to, hook_data, args); }static void wait_for_postcopy_status (QTestState *one,const char *status)
tests/qtest/migration/framework.c void test_postcopy_recovery_common(MigrateCommon *args) · line 746
Quoted 4 lines
tests/qtest/migration/framework.c +1
-0@@ -742,6 +743,7 @@ void test_postcopy_recovery_common(MigrateCommon *args) {QTestState *from, *to; g_autofree char *uri = NULL; +void *hook_data =NULL ;
* Should 'hook_data' pointer be g_autofree too? Where is it free'd otherwise?
Quoted 12 lines
tests/qtest/migration/framework.c +1
-1/* * Always enable OOB QMP capability for recovery tests, migrate-recover is @@ -752,7 +754,7 @@ void test_postcopy_recovery_common(MigrateCommon *args)/* Always hide errors for postcopy recover tests since they're expected */ args->start.hide_stderr = true; -if (migrate_postcopy_prepare (&from, &to, args)) { +if (migrate_postcopy_prepare (&from, &to, &hook_data, args)) {return ; }
tests/qtest/migration/framework.c void test_postcopy_recovery_common(MigrateCommon *args) · line 816
Quoted 8 lines
tests/qtest/migration/framework.c +1
-1@@ -808,7 +810,7 @@ void test_postcopy_recovery_common(MigrateCommon *args)/* Restore the postcopy bandwidth to unlimited */ migrate_set_parameter_int (from,"max-postcopy-bandwidth" ,0 ); -migrate_postcopy_complete (from, to, args); +migrate_postcopy_complete (from, to, hook_data, args); }int test_precopy_common (MigrateCommon *args)
* The changes look okay; But if tests define hook_data = NULL; Where does it get populated?
Thank you.
---
- Prasad
Re: [PATCH 1/2] tests/migration-test: Remove postcopy_data from MigrateCommon
Quoted 79 lines · Prasad Pandit
Quoted 78 lines · Peter Xu
Now postcopy is not the only user of
start_hook/end_hookthat will pass in a opaque pointer. It doesn't need to be defined in MigrateCommon as part of the framework, as all other hook users can passhook_dataaround. Do it too for postcopy.Signed-off-by Peter Xu <[email protected]>--- tests/qtest/migration/framework.h | 1 - tests/qtest/migration/framework.c | 18 ++++++++++-------- 2 files changed, 10 insertions(+), 9 deletions(-)tests/qtest/migration/framework.h +0
-1@@ -230,7 +230,6 @@ typedef struct {bool live;/* Postcopy specific fields */ -void *postcopy_data;PostcopyRecoveryFailStage postcopy_recovery_fail_stage; } MigrateCommon;tests/qtest/migration/framework.c +7
-6@@ -541,6 +541,7 @@ void migrate_end(QTestState *from, QTestState *to, bool test_dest)static int migrate_postcopy_prepare (QTestState **from_ptr,QTestState **to_ptr, +void **hook_data,MigrateCommon *args) {QTestState *from, *to;@@ -554,7 +555,7 @@ static int migrate_postcopy_prepare(QTestState **from_ptr, }if (args->start_hook) { - args->postcopy_data = args->start_hook (from, to); + *hook_data = args->start_hook (from, to); }migrate_ensure_non_converge (from);@@ -582,7 +583,7 @@ static int migrate_postcopy_prepare(QTestState **from_ptr, }static void migrate_postcopy_complete (QTestState *from,QTestState *to, -MigrateCommon *args) +void *hook_data,MigrateCommon *args) {MigrationTestEnv *env =migration_get_env ();@@ -601,8 +602,7 @@ static void migrate_postcopy_complete(QTestState *from, QTestState *to, }if (args->end_hook) { - args->end_hook (from, to, args->postcopy_data); - args->postcopy_data =NULL ; + args->end_hook (from, to, hook_data); }migrate_end (from, to, true);@@ -610,13 +610,14 @@ static void migrate_postcopy_complete(QTestState *from, QTestState *to,void test_postcopy_common (MigrateCommon *args) { +void *hook_data =NULL ;QTestState *from, *to; -if (migrate_postcopy_prepare (&from, &to, args)) { +if (migrate_postcopy_prepare (&from, &to, &hook_data, args)) {return ; }migrate_postcopy_start (from, to, &src_state); -migrate_postcopy_complete (from, to, args); +migrate_postcopy_complete (from, to, hook_data, args); }
Quoted 8 lines
tests/qtest/migration/framework.c void test_postcopy_recovery_common(MigrateCommon *args) · line 746
Quoted 6 lines
tests/qtest/migration/framework.c +1
-0static void wait_for_postcopy_status (QTestState *one,const char *status)@@ -742,6 +743,7 @@ void test_postcopy_recovery_common(MigrateCommon *args) {QTestState *from, *to; g_autofree char *uri = NULL; +void *hook_data =NULL ;* Should '
hook_data' pointer beg_autofreetoo? Where is it free'd otherwise?
hook_data is freed in end_hook(). This patch doesn't change that fact for postcopy. It's the smae to non-postcopy tests.
Quoted 16 lines
Quoted 16 lines
tests/qtest/migration/framework.c +1
-1/* * Always enable OOB QMP capability for recovery tests, migrate-recover is @@ -752,7 +754,7 @@ void test_postcopy_recovery_common(MigrateCommon *args)/* Always hide errors for postcopy recover tests since they're expected */ args->start.hide_stderr = true; -if (migrate_postcopy_prepare (&from, &to, args)) { +if (migrate_postcopy_prepare (&from, &to, &hook_data, args)) {return ; }@@ -808,7 +810,7 @@ void test_postcopy_recovery_common(MigrateCommon *args)/* Restore the postcopy bandwidth to unlimited */ migrate_set_parameter_int (from,"max-postcopy-bandwidth" ,0 );
Quoted 8 lines
tests/qtest/migration/framework.c void test_postcopy_recovery_common(MigrateCommon *args) · line 816
Quoted 5 lines
tests/qtest/migration/framework.c +1
-1-migrate_postcopy_complete (from, to, args); +migrate_postcopy_complete (from, to, hook_data, args); }int test_precopy_common (MigrateCommon *args)* The changes look okay; But if tests define
hook_data= NULL; Where does it get populated?
It's populated in start_hook() conditionally. When populated, it is always (and a must) to be released in end_hook().
Thanks,
Signature · 1 line
Peter Xu
Prasad Pandit
Reviewed-byRe: [PATCH 1/2] tests/migration-test: Remove postcopy_data from MigrateCommon
Quoted 10 lines · Peter Xu
Quoted 1 line
* Should '
hook_data' pointer beg_autofreetoo? Where is it free'd otherwise?
hook_datais freed inend_hook(). This patch doesn't change that fact for postcopy. It's the smae to non-postcopy tests.Quoted 2 lines
* The changes look okay; But if tests define
hook_data= NULL; Where does it get populated?It's populated in
start_hook()conditionally. When populated, it is always (and a must) to be released inend_hook().
===
$ grep -Eri 'test_postcopy_common|test_postcopy_recovery_common' tests/qtest/migration/ -l tests/qtest/migration/framework.h tests/qtest/migration/framework.c tests/qtest/migration/tls-tests.c tests/qtest/migration/postcopy-tests.c ===
* Only tls-tests above seem to define and use these hooks properly along with the hook_data. Postcopy-tests and all other users of start_hook/end_hook don't seem to use [postcopy|hook]_data at all. Do we really need this hook_data parameter? Couldn't it be defined as a tls-tests specific object. (just wondering)
Thank you.
---
- Prasad
Re: [PATCH 1/2] tests/migration-test: Remove postcopy_data from MigrateCommon
Quoted 21 lines · Prasad Pandit
Quoted 10 lines · Peter Xu
Quoted 1 line
* Should '
hook_data' pointer beg_autofreetoo? Where is it free'd otherwise?
hook_datais freed inend_hook(). This patch doesn't change that fact for postcopy. It's the smae to non-postcopy tests.Quoted 2 lines
* The changes look okay; But if tests define
hook_data= NULL; Where does it get populated?It's populated in
start_hook()conditionally. When populated, it is always (and a must) to be released inend_hook().===
$ grep -Eri 'test_postcopy_common|test_postcopy_recovery_common' tests/qtest/migration/ -l tests/qtest/migration/framework.h tests/qtest/migration/framework.c tests/qtest/migration/tls-tests.c tests/qtest/migration/postcopy-tests.c ===
Quoted 5 lines
* Only tls-tests above seem to define and use these hooks properly along with the
hook_data. Postcopy-tests and all other users of start_hook/end_hook don't seem to use [postcopy|hook]_data at all. Do we really need thishook_dataparameter? Couldn't it be defined as a tls-tests specific object. (just wondering)
Sorry I don't follow. We need the hook_data for cleaning up tls objects later in end_hook, for either postcopy or other tls tests.
Quoted 2 lines
Reviewed-by Prasad Pandit <[email protected]>
Thanks,
Quoted 5 lines
Thank you.
---
- Prasad
Signature · 1 line
Peter Xu
Re: [PATCH 1/2] tests/migration-test: Remove postcopy_data from MigrateCommon
Quoted 2 lines · Peter Xu
Sorry I don't follow. We need the
hook_datafor cleaning up tls objects later inend_hook, for either postcopy or other tls tests.
* Yes, but only start_hook() in tls-tests.c seem to return *hook_data object and end_hook() there free it. postcopy-tests.c and other tests don't seem to use *hook_data object; Other start_hooks() functions return NULL, so there's nothing to free in the end_hook() function.
Thank you.
---
- Prasad
PATCH 2/2 tests/migration-test: Remove postcopy_recovery_fail_stage from MigrateCommon
In reply to Peter XuThe parameter can be instead passed into the function.
--- tests/qtest/migration/framework.h | 6 ++---- tests/qtest/migration/framework.c | 7 ++++--- tests/qtest/migration/postcopy-tests.c | 12 ++++-------- tests/qtest/migration/tls-tests.c | 8 ++++---- 4 files changed, 14 insertions(+), 19 deletions(-)
tests/qtest/migration/framework.h +2 -4
@@ -228,9 +228,6 @@ typedef struct {* refer to existing ones with live=true), or use live=off by default. */ bool live; - -/* Postcopy specific fields */ -PostcopyRecoveryFailStage postcopy_recovery_fail_stage; } MigrateCommon;void wait_for_serial (const char *side);
@@ -243,7 +240,8 @@ int migrate_start(QTestState **from, QTestState **to, const char *uri,void migrate_end (QTestState *from,QTestState *to,bool test_dest);void test_postcopy_common (MigrateCommon *args); -void test_postcopy_recovery_common (MigrateCommon *args); +void test_postcopy_recovery_common (MigrateCommon *args, +PostcopyRecoveryFailStage fail_stage);int test_precopy_common (MigrateCommon *args);void test_file_common (MigrateCommon *args,bool stop_src); void *migrate_hook_start_precopy_tcp_multifd_common(QTestState *from,
tests/qtest/migration/framework.c +4 -3
@@ -739,7 +739,8 @@ static void postcopy_recover_fail(QTestState *from, QTestState *to,#endif } -void test_postcopy_recovery_common (MigrateCommon *args) +void test_postcopy_recovery_common (MigrateCommon *args, +PostcopyRecoveryFailStage fail_stage) {QTestState *from, *to; g_autofree char *uri = NULL;
@@ -784,12 +785,12 @@ void test_postcopy_recovery_common(MigrateCommon *args)wait_for_postcopy_status (to,"postcopy-paused" );wait_for_postcopy_status (from,"postcopy-paused" ); -if (args->postcopy_recovery_fail_stage) { +if (fail_stage) {/* * Test when a wrong socket specified for recover, and then the * ability to kick it out, and continue with a correct socket. */ -postcopy_recover_fail (from, to, args->postcopy_recovery_fail_stage); +postcopy_recover_fail (from, to, fail_stage);/* continue with a good recovery */ }
tests/qtest/migration/postcopy-tests.c +4 -8
@@ -41,30 +41,26 @@ static void test_postcopy_preempt(char *name, MigrateCommon *args)static void test_postcopy_recovery (char *name,MigrateCommon *args) { -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_NONE ); }static void test_postcopy_recovery_fail_handshake (char *name,MigrateCommon *args) { - args->postcopy_recovery_fail_stage =POSTCOPY_FAIL_RECOVERY ; - -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_RECOVERY ); }static void test_postcopy_recovery_fail_reconnect (char *name,MigrateCommon *args) { - args->postcopy_recovery_fail_stage =POSTCOPY_FAIL_CHANNEL_ESTABLISH ; - -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_CHANNEL_ESTABLISH ); }static void test_postcopy_preempt_recovery (char *name,MigrateCommon *args) { args->start.caps[MIGRATION_CAPABILITY_POSTCOPY_PREEMPT ] = true; -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_NONE ); }static void migration_test_add_postcopy_smoke (MigrationTestEnv *env)
tests/qtest/migration/tls-tests.c +4 -4
@@ -385,7 +385,7 @@ static void test_postcopy_recovery_tls_psk(char *name, MigrateCommon *args) args->start_hook = migrate_hook_start_tls_psk_match; args->end_hook = migrate_hook_end_tls_psk; -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_NONE ); } static void test_multifd_postcopy_recovery_tls_psk(char *name,
@@ -396,7 +396,7 @@ static void test_multifd_postcopy_recovery_tls_psk(char *name, args->start.caps[MIGRATION_CAPABILITY_MULTIFD ] = true; -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_NONE ); }/* This contains preempt+recovery+tls test altogether */
@@ -407,7 +407,7 @@ static void test_postcopy_preempt_all(char *name, MigrateCommon *args) args->start.caps[MIGRATION_CAPABILITY_POSTCOPY_PREEMPT ] = true; -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_NONE ); } static void test_multifd_postcopy_preempt_recovery_tls_psk(char *name,
@@ -419,7 +419,7 @@ static void test_multifd_postcopy_preempt_recovery_tls_psk(char *name, args->start.caps[MIGRATION_CAPABILITY_MULTIFD ] = true; args->start.caps[MIGRATION_CAPABILITY_POSTCOPY_PREEMPT ] = true; -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_NONE ); }static void test_precopy_unix_tls_psk (char *name,MigrateCommon *args)
Signature · 1 line
2.50.1
Re: [PATCH 2/2] tests/migration-test: Remove postcopy_recovery_fail_stage from MigrateCommon
Quoted 1 line · Peter Xu
The parameter can be instead passed into the function.
* It'll help to include - why? pass the parameter instead.
Quoted 37 lines
Signed-off-by Peter Xu <[email protected]>--- tests/qtest/migration/framework.h | 6 ++---- tests/qtest/migration/framework.c | 7 ++++--- tests/qtest/migration/postcopy-tests.c | 12 ++++-------- tests/qtest/migration/tls-tests.c | 8 ++++---- 4 files changed, 14 insertions(+), 19 deletions(-)tests/qtest/migration/framework.h +2
-4@@ -228,9 +228,6 @@ typedef struct {* refer to existing ones with live=true), or use live=off by default. */ bool live; - -/* Postcopy specific fields */ -PostcopyRecoveryFailStage postcopy_recovery_fail_stage; } MigrateCommon;void wait_for_serial (const char *side);@@ -243,7 +240,8 @@ int migrate_start(QTestState **from, QTestState **to, const char *uri,void migrate_end (QTestState *from,QTestState *to,bool test_dest);void test_postcopy_common (MigrateCommon *args); -void test_postcopy_recovery_common (MigrateCommon *args); +void test_postcopy_recovery_common (MigrateCommon *args, +PostcopyRecoveryFailStage fail_stage);int test_precopy_common (MigrateCommon *args);void test_file_common (MigrateCommon *args,bool stop_src); void *migrate_hook_start_precopy_tcp_multifd_common(QTestState *from,tests/qtest/migration/framework.c +0
-0
tests/qtest/migration/framework.c static void postcopy_recover_fail(QTestState *from, QTestState *to, · line 743
Quoted 6 lines
tests/qtest/migration/framework.c +2
-1@@ -739,7 +739,8 @@ static void postcopy_recover_fail(QTestState *from, QTestState *to,#endif } -void test_postcopy_recovery_common (MigrateCommon *args) +void test_postcopy_recovery_common (MigrateCommon *args, +PostcopyRecoveryFailStage fail_stage)
===
static void postcopy_recover_fail(QTestState *from, QTestState
*to,
PostcopyRecoveryFailStage stage)
===
* To keep it consistent, maybe we can call the variable 'stage' as above?
Quoted 89 lines
tests/qtest/migration/framework.c +2
-2{QTestState *from, *to; g_autofree char *uri = NULL;@@ -784,12 +785,12 @@ void test_postcopy_recovery_common(MigrateCommon *args)wait_for_postcopy_status (to,"postcopy-paused" );wait_for_postcopy_status (from,"postcopy-paused" ); -if (args->postcopy_recovery_fail_stage) { +if (fail_stage) {/* * Test when a wrong socket specified for recover, and then the * ability to kick it out, and continue with a correct socket. */ -postcopy_recover_fail (from, to, args->postcopy_recovery_fail_stage); +postcopy_recover_fail (from, to, fail_stage);/* continue with a good recovery */ }tests/qtest/migration/postcopy-tests.c +4
-8@@ -41,30 +41,26 @@ static void test_postcopy_preempt(char *name, MigrateCommon *args)static void test_postcopy_recovery (char *name,MigrateCommon *args) { -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_NONE ); }static void test_postcopy_recovery_fail_handshake (char *name,MigrateCommon *args) { - args->postcopy_recovery_fail_stage =POSTCOPY_FAIL_RECOVERY ; - -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_RECOVERY ); }static void test_postcopy_recovery_fail_reconnect (char *name,MigrateCommon *args) { - args->postcopy_recovery_fail_stage =POSTCOPY_FAIL_CHANNEL_ESTABLISH ; - -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_CHANNEL_ESTABLISH ); }static void test_postcopy_preempt_recovery (char *name,MigrateCommon *args) { args->start.caps[MIGRATION_CAPABILITY_POSTCOPY_PREEMPT ] = true; -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_NONE ); }static void migration_test_add_postcopy_smoke (MigrationTestEnv *env)tests/qtest/migration/tls-tests.c +3
-3@@ -385,7 +385,7 @@ static void test_postcopy_recovery_tls_psk(char *name, MigrateCommon *args) args->start_hook = migrate_hook_start_tls_psk_match; args->end_hook = migrate_hook_end_tls_psk; -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_NONE ); } static void test_multifd_postcopy_recovery_tls_psk(char *name,@@ -396,7 +396,7 @@ static void test_multifd_postcopy_recovery_tls_psk(char *name, args->start.caps[MIGRATION_CAPABILITY_MULTIFD ] = true; -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_NONE ); }/* This contains preempt+recovery+tls test altogether */ @@ -407,7 +407,7 @@ static void test_postcopy_preempt_all(char *name, MigrateCommon *args) args->start.caps[MIGRATION_CAPABILITY_POSTCOPY_PREEMPT ] = true; -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_NONE ); } static void test_multifd_postcopy_preempt_recovery_tls_psk(char *name,
tests/qtest/migration/tls-tests.c static void test_multifd_postcopy_preempt_recovery_tls_psk(char *name, · line 425
Quoted 8 lines
tests/qtest/migration/tls-tests.c +1
-1@@ -419,7 +419,7 @@ static void test_multifd_postcopy_preempt_recovery_tls_psk(char *name, args->start.caps[MIGRATION_CAPABILITY_MULTIFD ] = true; args->start.caps[MIGRATION_CAPABILITY_POSTCOPY_PREEMPT ] = true; -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_NONE ); }static void test_precopy_unix_tls_psk (char *name,MigrateCommon *args)
* Change looks okay otherwise.
Thank you.
---
- Prasad
Re: [PATCH 2/2] tests/migration-test: Remove postcopy_recovery_fail_stage from MigrateCommon
Quoted 4 lines · Prasad Pandit
Quoted 1 line · Peter Xu
The parameter can be instead passed into the function.
* It'll help to include - why? pass the parameter instead.
I want to remove special and unnecessary fields in MigrateCommon struct.
I'll add a sentence when repost.
Quoted 50 lines
Quoted 38 lines
Signed-off-by Peter Xu <[email protected]>--- tests/qtest/migration/framework.h | 6 ++---- tests/qtest/migration/framework.c | 7 ++++--- tests/qtest/migration/postcopy-tests.c | 12 ++++-------- tests/qtest/migration/tls-tests.c | 8 ++++---- 4 files changed, 14 insertions(+), 19 deletions(-)tests/qtest/migration/framework.h +2
-4@@ -228,9 +228,6 @@ typedef struct {* refer to existing ones with live=true), or use live=off by default. */ bool live; - -/* Postcopy specific fields */ -PostcopyRecoveryFailStage postcopy_recovery_fail_stage; } MigrateCommon;void wait_for_serial (const char *side);@@ -243,7 +240,8 @@ int migrate_start(QTestState **from, QTestState **to, const char *uri,void migrate_end (QTestState *from,QTestState *to,bool test_dest);void test_postcopy_common (MigrateCommon *args); -void test_postcopy_recovery_common (MigrateCommon *args); +void test_postcopy_recovery_common (MigrateCommon *args, +PostcopyRecoveryFailStage fail_stage);int test_precopy_common (MigrateCommon *args);void test_file_common (MigrateCommon *args,bool stop_src); void *migrate_hook_start_precopy_tcp_multifd_common(QTestState *from,tests/qtest/migration/framework.c +0
-0tests/qtest/migration/framework.c static void postcopy_recover_fail(QTestState *from, QTestState *to, · line 743
Quoted 6 lines
tests/qtest/migration/framework.c +2
-1@@ -739,7 +739,8 @@ static void postcopy_recover_fail(QTestState *from, QTestState *to,#endif } -void test_postcopy_recovery_common (MigrateCommon *args) +void test_postcopy_recovery_common (MigrateCommon *args, +PostcopyRecoveryFailStage fail_stage)===
static void postcopy_recover_fail(QTestState *from, QTestState
*to,
PostcopyRecoveryFailStage stage)
===
Quoted 1 line
* To keep it consistent, maybe we can call the variable 'stage' as above?
Personally I prefer fail_stage, e.g. fail_stage=NONE means it never fails. stage==NONE is less clear.
Thanks,
Quoted 105 lines
Quoted 90 lines
tests/qtest/migration/framework.c +2
-2{QTestState *from, *to; g_autofree char *uri = NULL;@@ -784,12 +785,12 @@ void test_postcopy_recovery_common(MigrateCommon *args)wait_for_postcopy_status (to,"postcopy-paused" );wait_for_postcopy_status (from,"postcopy-paused" ); -if (args->postcopy_recovery_fail_stage) { +if (fail_stage) {/* * Test when a wrong socket specified for recover, and then the * ability to kick it out, and continue with a correct socket. */ -postcopy_recover_fail (from, to, args->postcopy_recovery_fail_stage); +postcopy_recover_fail (from, to, fail_stage);/* continue with a good recovery */ }tests/qtest/migration/postcopy-tests.c +4
-8@@ -41,30 +41,26 @@ static void test_postcopy_preempt(char *name, MigrateCommon *args)static void test_postcopy_recovery (char *name,MigrateCommon *args) { -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_NONE ); }static void test_postcopy_recovery_fail_handshake (char *name,MigrateCommon *args) { - args->postcopy_recovery_fail_stage =POSTCOPY_FAIL_RECOVERY ; - -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_RECOVERY ); }static void test_postcopy_recovery_fail_reconnect (char *name,MigrateCommon *args) { - args->postcopy_recovery_fail_stage =POSTCOPY_FAIL_CHANNEL_ESTABLISH ; - -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_CHANNEL_ESTABLISH ); }static void test_postcopy_preempt_recovery (char *name,MigrateCommon *args) { args->start.caps[MIGRATION_CAPABILITY_POSTCOPY_PREEMPT ] = true; -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_NONE ); }static void migration_test_add_postcopy_smoke (MigrationTestEnv *env)tests/qtest/migration/tls-tests.c +3
-3@@ -385,7 +385,7 @@ static void test_postcopy_recovery_tls_psk(char *name, MigrateCommon *args) args->start_hook = migrate_hook_start_tls_psk_match; args->end_hook = migrate_hook_end_tls_psk; -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_NONE ); } static void test_multifd_postcopy_recovery_tls_psk(char *name,@@ -396,7 +396,7 @@ static void test_multifd_postcopy_recovery_tls_psk(char *name, args->start.caps[MIGRATION_CAPABILITY_MULTIFD ] = true; -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_NONE ); }/* This contains preempt+recovery+tls test altogether */ @@ -407,7 +407,7 @@ static void test_postcopy_preempt_all(char *name, MigrateCommon *args) args->start.caps[MIGRATION_CAPABILITY_POSTCOPY_PREEMPT ] = true; -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_NONE ); } static void test_multifd_postcopy_preempt_recovery_tls_psk(char *name,tests/qtest/migration/tls-tests.c static void test_multifd_postcopy_preempt_recovery_tls_psk(char *name, · line 425
Quoted 8 lines
tests/qtest/migration/tls-tests.c +1
-1@@ -419,7 +419,7 @@ static void test_multifd_postcopy_preempt_recovery_tls_psk(char *name, args->start.caps[MIGRATION_CAPABILITY_MULTIFD ] = true; args->start.caps[MIGRATION_CAPABILITY_POSTCOPY_PREEMPT ] = true; -test_postcopy_recovery_common (args); +test_postcopy_recovery_common (args,POSTCOPY_FAIL_NONE ); }static void test_precopy_unix_tls_psk (char *name,MigrateCommon *args)* Change looks okay otherwise.
Thank you.
---
- Prasad
Signature · 1 line
Peter Xu
Prasad Pandit
Reviewed-byRe: [PATCH 2/2] tests/migration-test: Remove postcopy_recovery_fail_stage from MigrateCommon
Quoted 9 lines · Peter Xu
Quoted 4 lines · Prasad Pandit
Quoted 1 line · Peter Xu
The parameter can be instead passed into the function.
* It'll help to include - why? pass the parameter instead.
I want to remove special and unnecessary fields in MigrateCommon struct.
I'll add a sentence when repost.
...
Quoted 4 lines
Quoted 1 line
* To keep it consistent, maybe we can call the variable 'stage' as above?
Personally I prefer
fail_stage, e.g. fail_stage=NONE means it never fails. stage==NONE is less clear.
* Let's make it fail_stage in both places then?
Thank you.
---
- Prasad
Re: [PATCH 2/2] tests/migration-test: Remove postcopy_recovery_fail_stage from MigrateCommon
Quoted 9 lines · Prasad Pandit
Quoted 8 lines · Peter Xu
Quoted 4 lines · Prasad Pandit
Quoted 1 line · Peter Xu
The parameter can be instead passed into the function.
* It'll help to include - why? pass the parameter instead.
I want to remove special and unnecessary fields in MigrateCommon struct.
Quoted 8 lines
Quoted 1 line
I'll add a sentence when repost.
...
Quoted 4 lines
Quoted 1 line
* To keep it consistent, maybe we can call the variable 'stage' as above?
Personally I prefer
fail_stage, e.g. fail_stage=NONE means it never fails. stage==NONE is less clear.* Let's make it
fail_stagein both places then?
Could you explain what's the 2nd place to use it besides the parameter in test_postcopy_recovery_common()?
Quoted 2 lines
Reviewed-by Prasad Pandit <[email protected]>
Thanks,
Quoted 5 lines
Thank you.
---
- Prasad
Signature · 1 line
Peter Xu
Re: [PATCH 2/2] tests/migration-test: Remove postcopy_recovery_fail_stage from MigrateCommon
Quoted 4 lines · Peter Xu
Quoted 1 line
* Let's make it
fail_stagein both places then?Could you explain what's the 2nd place to use it besides the parameter in
test_postcopy_recovery_common()?
===tests/qtest/migration/framework.c:
static void postcopy_recover_fail(QTestState *from, QTestState *to,
PostcopyRecoveryFailStage stage)
===
This one. ^^
Thank you.
---
- Prasad
Re: [PATCH 2/2] tests/migration-test: Remove postcopy_recovery_fail_stage from MigrateCommon
Quoted 11 lines · Prasad Pandit
Quoted 4 lines · Peter Xu
Quoted 1 line
* Let's make it
fail_stagein both places then?Could you explain what's the 2nd place to use it besides the parameter in
test_postcopy_recovery_common()?===
tests/qtest/migration/framework.c:
static void postcopy_recover_fail(QTestState *from, QTestState *to,
PostcopyRecoveryFailStage stage)
===
This one. ^^
I don't have a strong opinion, since that's unrelevant to the current change, IMHO we can keep it as is.
Thanks,
Signature · 1 line
Peter Xu