fgraph: Make sure fregs is non-null when accessing
PATCH 1/1 fgraph: Make sure fregs is non-null when accessing
From: sunliming <[email protected]>
Fix below smatch warnings:kernel/trace/fgraph.c:834 __ftrace_return_to_handler() error: we previously assumed 'fregs' could be null (see line 830)
Reported-by kernel test robot <[email protected]>
Reported-by Dan Carpenter <[email protected]>
Signed-off-by sunliming <[email protected]>
--- kernel/trace/fgraph.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/trace/fgraph.c +2 -1
@@ -837,7 +837,8 @@ __ftrace_return_to_handler(struct ftrace_regs *fregs, unsigned long frame_pointe goto out;#ifdef CONFIG_FUNCTION_GRAPH_RETVAL - trace.retval =ftrace_regs_get_return_value (fregs); +if (fregs) + trace.retval =ftrace_regs_get_return_value (fregs);#endif bitmap =get_bitmap_bits (current, offset);
Signature · 1 line
2.25.1
Quoted 6 lines · On Wed, 7 Jan 2026 09:51:25 +0800 [email protected] wrote:
From: sunliming <[email protected]>
Fix below smatch warnings:
kernel/trace/fgraph.c:834__ftrace_return_to_handler()error: we previously assumed 'fregs' could be null (see line 830)
NACK!
Quoted 3 lines
Reported-by kernel test robot <[email protected]>Reported-by Dan Carpenter <[email protected]>
Really? Did you not read this thread you are "closing"?
-- Steve
Quoted 19 lines
Signed-off-by sunliming <[email protected]>--- kernel/trace/fgraph.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)kernel/trace/fgraph.c +2
-1@@ -837,7 +837,8 @@ __ftrace_return_to_handler(struct ftrace_regs *fregs, unsigned long frame_pointe goto out;#ifdef CONFIG_FUNCTION_GRAPH_RETVAL - trace.retval =ftrace_regs_get_return_value (fregs); +if (fregs) + trace.retval =ftrace_regs_get_return_value (fregs);#endif bitmap =get_bitmap_bits (current, offset);