bpf: Reject BPF_MAP_TYPE_INSN_ARRAY in check_reg_const_str()
PATCH 1/1 bpf: Reject BPF_MAP_TYPE_INSN_ARRAY in check_reg_const_str()
BPF_MAP_TYPE_INSN_ARRAY maps store instruction pointers in their ips array, not string data. The map_direct_value_addr callback for this map type returns the address of the ips array, which is not suitable for use as a constant string argument.
When a BPF program passes a pointer to an insn_array map value as ARG_PTR_TO_CONST_STR (e.g., to bpf_snprintf), the verifier's null-termination check in check_reg_const_str() operates on the wrong memory region, and at runtime bpf_bprintf_prepare() can read out of bounds searching for a null terminator.
Reject BPF_MAP_TYPE_INSN_ARRAY in check_reg_const_str() since this map type is not designed to hold string data.
--- kernel/bpf/verifier.c | 5 +++++ 1 file changed, 5 insertions(+)
kernel/bpf/verifier.c +5 -0
@@ -9609,6 +9609,11 @@ static int check_reg_const_str(struct bpf_verifier_env *env,if (reg->type !=PTR_TO_MAP_VALUE )return -EINVAL ; +if (map->map_type ==BPF_MAP_TYPE_INSN_ARRAY ) { +verbose (env,"R%d points to insn_array map which cannot be used as const string\n" , regno); +return -EACCES ; + } +if (!bpf_map_is_rdonly (map)) {verbose (env,"R%d does not point to a readonly map'\n" , regno);return -EACCES ;
Signature · 1 line
2.43.0
Quoted 42 lines · Deepanshu Kartikey
BPF_MAP_TYPE_INSN_ARRAYmaps store instruction pointers in their ips array, not string data. Themap_direct_value_addrcallback for this map type returns the address of the ips array, which is not suitable for use as a constant string argument.When a BPF program passes a pointer to an
insn_arraymap value asARG_PTR_TO_CONST_STR(e.g., tobpf_snprintf), the verifier's null-termination check incheck_reg_const_str()operates on the wrong memory region, and at runtimebpf_bprintf_prepare()can read out of bounds searching for a null terminator.Reject
BPF_MAP_TYPE_INSN_ARRAYincheck_reg_const_str()since this map type is not designed to hold string data.Reported-by [email protected]Tested-by [email protected]Fixes 493d9e0d6083 ("bpf, x86: add support for indirect jumps")Signed-off-by Deepanshu Kartikey <[email protected]>--- kernel/bpf/verifier.c | 5 +++++ 1 file changed, 5 insertions(+)kernel/bpf/verifier.c +5
-0@@ -9609,6 +9609,11 @@ static int check_reg_const_str(struct bpf_verifier_env *env,if (reg->type !=PTR_TO_MAP_VALUE )return -EINVAL ; +if (map->map_type ==BPF_MAP_TYPE_INSN_ARRAY ) { +verbose (env,"R%d points to insn_array map which cannot be used as const string\n" , regno); +return -EACCES ; + } +if (!bpf_map_is_rdonly (map)) {verbose (env,"R%d does not point to a readonly map'\n" , regno);return -EACCES ;Signature · 1 line
2.43.0
This patch was applied to bpf/bpf.git (master) by Alexei Starovoitov <[email protected]>:
Hello:
This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <[email protected]>:
Quoted 5 lines · On Wed, 7 Jan 2026 07:40:37 +0530 you wrote:
BPF_MAP_TYPE_INSN_ARRAYmaps store instruction pointers in their ips array, not string data. Themap_direct_value_addrcallback for this map type returns the address of the ips array, which is not suitable for use as a constant string argument.
Quoted 7 lines
When a BPF program passes a pointer to an
insn_arraymap value asARG_PTR_TO_CONST_STR(e.g., tobpf_snprintf), the verifier's null-termination check incheck_reg_const_str()operates on the wrong memory region, and at runtimebpf_bprintf_prepare()can read out of bounds searching for a null terminator.[...]
Here is the summary with links:
- bpf: Reject BPF_MAP_TYPE_INSN_ARRAY in check_reg_const_str()
https://git.kernel.org/bpf/bpf/c/9df5fad801c5
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html