Skip to contentSkip to conversation

linux-next: build failure after merge of the leds-lj tree

DISCUSSION Stephen Rothwell 3 participants 8 messages Jan 9 – Feb 4 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the leds-lj tree, today's linux-next build (x86_64 allmodconfig) failed like this:

ERROR: modpost: missing MODULE_LICENSE() in drivers/leds/rgb/leds-lp5860-core.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/leds/rgb/leds-lp5860-core.o
ERROR: modpost: "lp5860_device_init" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!
ERROR: modpost: "lp5860_device_remove" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!

Caused by commit

51f7560294c9 ("leds: Add support for TI LP5860 LED driver chip")

I have used the led-lj tree from next-20160108 for today.

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 10 lines · Stephen Rothwell

Hi all,

After merging the leds-lj tree, today's linux-next build (x86_64 allmodconfig) failed like this:

ERROR: modpost: missing MODULE_LICENSE() in drivers/leds/rgb/leds-lp5860-core.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/leds/rgb/leds-lp5860-core.o
ERROR: modpost: "lp5860_device_init" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!
ERROR: modpost: "lp5860_device_remove" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!

Quoted 5 lines

Caused by commit

51f7560294c9 ("leds: Add support for TI LP5860 LED driver chip")

I have used the led-lj tree from next-20160108 for today.

Steffen,

Please provide a follow-up patch post-haste.

Signature · 1 line
Lee Jones [李琼斯]
maintainer
#2 lore raw
Quoted 7 lines · Lee Jones
Quoted 4 lines · Stephen Rothwell

ERROR: modpost: missing MODULE_LICENSE() in drivers/leds/rgb/leds-lp5860-core.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/leds/rgb/leds-lp5860-core.o
ERROR: modpost: "lp5860_device_init" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!
ERROR: modpost: "lp5860_device_remove" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!

Quoted 7 lines
Quoted 5 lines

Caused by commit

51f7560294c9 ("leds: Add support for TI LP5860 LED driver chip")

I have used the led-lj tree from next-20160108 for today.

Please provide a follow-up patch post-haste.

This issue is still present in today's -next.

#3 lore raw
Quoted 10 lines · Mark Brown
Quoted 8 lines · Lee Jones
Quoted 6 lines · Stephen Rothwell

ERROR: modpost: missing MODULE_LICENSE() in drivers/leds/rgb/leds-lp5860-core.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/leds/rgb/leds-lp5860-core.o
ERROR: modpost: "lp5860_device_init" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!
ERROR: modpost: "lp5860_device_remove" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!

Caused by commit

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

51f7560294c9 ("leds: Add support for TI LP5860 LED driver chip")

I have used the led-lj tree from next-20160108 for today.

Please provide a follow-up patch post-haste.

This issue is still present in today's -next.

Steffen,

Please provide a follow-up or I'll have to remove your patch.

This is blocking testing.

Signature · 1 line
Lee Jones [李琼斯]
maintainer
#4 lore raw
In reply to Stephen Rothwell
Quoted 9 lines · Stephen Rothwell

Hi all,

After merging the leds-lj tree, today's linux-next build (x86_64 allmodconfig) failed like this:

ERROR: modpost: missing MODULE_LICENSE() in drivers/leds/rgb/leds-lp5860-core.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/leds/rgb/leds-lp5860-core.o
ERROR: modpost: "lp5860_device_init" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!
ERROR: modpost: "lp5860_device_remove" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!

This issue is still present in today's -next.

maintainer
#5 lore raw
In reply to Stephen Rothwell
Quoted 4 lines · Stephen Rothwell

Hi all,

After merging the leds-lj tree, today's linux-next build (x86_64 allmodconfig) failed like this:

This issue is still present in today's -next, the leds-lj tree is still using the version from 8th January.

maintainer
#6 lore raw
Quoted 8 lines · Mark Brown
Quoted 4 lines · Stephen Rothwell

Hi all,

After merging the leds-lj tree, today's linux-next build (x86_64 allmodconfig) failed like this:

This issue is still present in today's -next, the leds-lj tree is still using the version from 8th January.

This means that these commits have never been in -next and we're at -rc8 now:

Daniel Mack (3):

      dt-bindings: leds: Add issi,is31fl3293 to leds-is31fl32xx
      leds: is31f132xx: Re-order code to remove forward declarations
      leds: is31f132xx: Add support for is31fl3293

Nam Tran (3):
dt-bindings: leds: add TI/National Semiconductor LP5812 LED Driver
leds: Add basic support for TI/National Semiconductor LP5812 LED Driver
docs: leds: Document TI LP5812 LED driver

Steffen Trumtrar (3):
dt-bindings: leds: Add LP5860 LED controller
leds: Add support for TI LP5860 LED driver chip
leds: lp5860: Fix unused-but-set-variable warning

Jishnu Prakash (2):
dt-bindings: leds: leds-qcom-lpg: Add support for PMH0101 PWM
dt-bindings: leds: qcom,spmi-flash-led: Add PMH0101 compatible

Lukas Timmermann (2):
dt-bindings: leds: Add new as3668 support
leds: as3668: Driver for the ams Osram 4-channel i2c LED driver

Duje Mihanović (1):
leds: expresswire: Fix chip state breakage

Haotian Zhang (1):
leds: qcom-lpg: Check the return value of regmap_bulk_write()

J. Neuschäfer (1):
dt-bindings: leds: Allow differently named multicolor LEDs

Krzysztof Kozlowski (1):
leds: lp55xx: Simplify with scoped for each OF child loop

Vivek BalachandharTN (1):
leds: lm3692x: Fix kernel-doc for struct lm3692x_led

The leds-lj tree in -next currently contains only:

Lukas Timmermann (2):
dt-bindings: leds: Add new as3668 support
leds: as3668: Driver for the ams Osram 4-channel i2c LED driver

#7 lore raw
Quoted 48 lines · Mark Brown
Quoted 8 lines · Mark Brown
Quoted 4 lines · Stephen Rothwell

Hi all,

After merging the leds-lj tree, today's linux-next build (x86_64 allmodconfig) failed like this:

This issue is still present in today's -next, the leds-lj tree is still using the version from 8th January.

This means that these commits have never been in -next and we're at -rc8 now:

Daniel Mack (3):

      dt-bindings: leds: Add issi,is31fl3293 to leds-is31fl32xx
      leds: is31f132xx: Re-order code to remove forward declarations
      leds: is31f132xx: Add support for is31fl3293

Nam Tran (3):
dt-bindings: leds: add TI/National Semiconductor LP5812 LED Driver
leds: Add basic support for TI/National Semiconductor LP5812 LED Driver
docs: leds: Document TI LP5812 LED driver

Steffen Trumtrar (3):
dt-bindings: leds: Add LP5860 LED controller
leds: Add support for TI LP5860 LED driver chip
leds: lp5860: Fix unused-but-set-variable warning

Jishnu Prakash (2):
dt-bindings: leds: leds-qcom-lpg: Add support for PMH0101 PWM
dt-bindings: leds: qcom,spmi-flash-led: Add PMH0101 compatible

Lukas Timmermann (2):
dt-bindings: leds: Add new as3668 support
leds: as3668: Driver for the ams Osram 4-channel i2c LED driver

Duje Mihanović (1):
leds: expresswire: Fix chip state breakage

Haotian Zhang (1):
leds: qcom-lpg: Check the return value of regmap_bulk_write()

J. Neuschäfer (1):
dt-bindings: leds: Allow differently named multicolor LEDs

Krzysztof Kozlowski (1):
leds: lp55xx: Simplify with scoped for each OF child loop

Quoted 8 lines

Vivek BalachandharTN (1):
leds: lm3692x: Fix kernel-doc for struct lm3692x_led

The leds-lj tree in -next currently contains only:

Lukas Timmermann (2):
dt-bindings: leds: Add new as3668 support
leds: as3668: Driver for the ams Osram 4-channel i2c LED driver

Apologies, I was on vacation all last week.

I have removed the offending commit.

Signature · 1 line
Lee Jones [李琼斯]