crypto: stm32 - Remove unnecessary checks before calling memcpy
Subsystems (2)
PATCH 1/1 crypto: stm32 - Remove unnecessary checks before calling memcpy
memcpy() can be safely called with size 0, which is a no-op. Remove the unnecessary checks before calling memcpy().
Signed-off-by Thorsten Blum <[email protected]>
--- drivers/crypto/stm32/stm32-hash.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/crypto/stm32/stm32-hash.c +2 -4
@@ -1115,8 +1115,7 @@ static int stm32_hash_copy_sgs(struct stm32_hash_request_ctx *rctx,return -ENOMEM ; } -if (state->bufcnt) -memcpy (buf, rctx->hdev->xmit_buf, state->bufcnt); +memcpy (buf, rctx->hdev->xmit_buf, state->bufcnt);scatterwalk_map_and_copy (buf + state->bufcnt, sg, rctx->offset,min (new_len, rctx->total) - state->bufcnt,0 );
@@ -1300,8 +1299,7 @@ static int stm32_hash_prepare_request(struct ahash_request *req) }/* copy buffer in a temporary one that is used for sg alignment */ -if (state->bufcnt) -memcpy (hdev->xmit_buf, state->buffer, state->bufcnt); +memcpy (hdev->xmit_buf, state->buffer, state->bufcnt); ret =stm32_hash_align_sgs (req->src, nbytes, bs, init, final, rctx);if (ret)
Signature · 2 lines
Thorsten Blum <[email protected]> GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4
Herbert Xu
maintainerQuoted 7 lines · Thorsten Blum
memcpy()can be safely called with size 0, which is a no-op. Remove the unnecessary checks before callingmemcpy().Signed-off-by Thorsten Blum <[email protected]>--- drivers/crypto/stm32/stm32-hash.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt