drm/mipi-dsi: add mipi_dsi_shutdown_peripheral_multi
Subsystems (3)
PATCH v2 1/2 drm/mipi-dsi: add mipi_dsi_shutdown_peripheral_multi
Add mipi_dsi_shutdown_peripheral_multi function and mark mipi_dsi_shutdown_peripheral fucntion as deprecated.
--- drivers/gpu/drm/drm_mipi_dsi.c | 28 ++++++++++++++++++++++++++++ include/drm/drm_mipi_dsi.h | 1 + 2 files changed, 29 insertions(+)
drivers/gpu/drm/drm_mipi_dsi.c +28 -0
@@ -587,6 +587,9 @@ EXPORT_SYMBOL(mipi_dsi_create_packet);* mipi_dsi_shutdown_peripheral() - sends a Shutdown Peripheral command * @dsi: DSI peripheral device * +* This function is deprecated. Use mipi_dsi_shutdown_peripheral_multi() +* instead. +* * Return: 0 on success or a negative error code on failure. */ int mipi_dsi_shutdown_peripheral (struct mipi_dsi_device *dsi)
@@ -1980,6 +1983,31 @@ void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_dsi_multi_context *ctx, }EXPORT_SYMBOL (mipi_dsi_dcs_set_tear_scanline_multi); +/** +* mipi_dsi_shutdown_peripheral_multi() - sends a Shutdown Peripheral command +* @ctx: Context for multiple DSI transactions +* +* Like mipi_dsi_shutdown_peripheral() but deals with errors in a way that +* makes it convienient to make seeral calls in a row. +*/ +void mipi_dsi_shutdown_peripheral_multi (struct mipi_dsi_multi_context *ctx) +{ +struct mipi_dsi_device *dsi = ctx->dsi; +struct device *dev = &dsi->dev; +int ret; + +if (ctx->accum_err) +return ; + + ret =mipi_dsi_shutdown_peripheral (dsi); +if (ret <0 ) { + ctx->accum_err = ret; +dev_err (dev,"Failed to shutdown peripheral: %d\n" , + ctx->accum_err); + } +} +EXPORT_SYMBOL (mipi_dsi_shutdown_peripheral_multi); +static int mipi_dsi_drv_probe (struct device *dev) {struct mipi_dsi_driver *drv =to_mipi_dsi_driver (dev->driver);
include/drm/drm_mipi_dsi.h +1 -0
@@ -389,6 +389,7 @@ void mipi_dsi_dcs_set_page_address_multi(struct mipi_dsi_multi_context *ctx,void mipi_dsi_dcs_set_tear_scanline_multi (struct mipi_dsi_multi_context *ctx,u16 scanline);void mipi_dsi_dcs_set_tear_off_multi (struct mipi_dsi_multi_context *ctx); +void mipi_dsi_shutdown_peripheral_multi (struct mipi_dsi_multi_context *ctx);/** * mipi_dsi_generic_write_seq_multi - transmit data using a generic write packet
Signature · 1 line
2.52.0
PATCH v2 2/2 drm/panel: panasonic-vvx10f034n00: transition to mipi_dsi wrapped functions
Changes the panasonic-vvx10f034n00 panel to multi
style functions for improved error handling.
--- .../gpu/drm/panel/panel-panasonic-vvx10f034n00.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)
drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c +12 -2
@@ -44,14 +44,24 @@ static inline struct wuxga_nt_panel *to_wuxga_nt_panel(struct drm_panel *panel)static int wuxga_nt_panel_on (struct wuxga_nt_panel *wuxga_nt) { -return mipi_dsi_turn_on_peripheral (wuxga_nt->dsi); +struct mipi_dsi_multi_context dsi_ctx = { + .dsi = wuxga_nt->dsi + }; + +mipi_dsi_turn_on_peripheral_multi (&dsi_ctx); +return dsi_ctx.accum_err; }static int wuxga_nt_panel_disable (struct drm_panel *panel) {struct wuxga_nt_panel *wuxga_nt =to_wuxga_nt_panel (panel); -return mipi_dsi_shutdown_peripheral (wuxga_nt->dsi); +struct mipi_dsi_multi_context dsi_ctx = { + .dsi = wuxga_nt->dsi + }; + +mipi_dsi_shutdown_peripheral_multi (&dsi_ctx); +return dsi_ctx.accum_err; }static int wuxga_nt_panel_unprepare (struct drm_panel *panel)
Signature · 1 line
2.52.0
Re: [PATCH v2 2/2] drm/panel: panasonic-vvx10f034n00: transition to mipi_dsi wrapped functions
Quoted 29 lines · Avinal Kumar
Changes the panasonic-vvx10f034n00 panel to multi
style functions for improved error handling.Signed-off-by Avinal Kumar <[email protected]>--- .../gpu/drm/panel/panel-panasonic-vvx10f034n00.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c +6
-1@@ -44,14 +44,24 @@ static inline struct wuxga_nt_panel *to_wuxga_nt_panel(struct drm_panel *panel)static int wuxga_nt_panel_on (struct wuxga_nt_panel *wuxga_nt) { -return mipi_dsi_turn_on_peripheral (wuxga_nt->dsi); +struct mipi_dsi_multi_context dsi_ctx = { + .dsi = wuxga_nt->dsi + }; + +mipi_dsi_turn_on_peripheral_multi (&dsi_ctx); +return dsi_ctx.accum_err; }static int wuxga_nt_panel_disable (struct drm_panel *panel) {struct wuxga_nt_panel *wuxga_nt =to_wuxga_nt_panel (panel);
drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c static inline struct wuxga_nt_panel *to_wuxga_nt_panel(struct drm_panel *panel) · line 67
Quoted 10 lines
drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c +6
-1-return mipi_dsi_shutdown_peripheral (wuxga_nt->dsi); +struct mipi_dsi_multi_context dsi_ctx = { + .dsi = wuxga_nt->dsi + }; + +mipi_dsi_shutdown_peripheral_multi (&dsi_ctx); +return dsi_ctx.accum_err; }static int wuxga_nt_panel_unprepare (struct drm_panel *panel)
Thanks,
Neil
Quoted 60 lines · Avinal Kumar
Add
mipi_dsi_shutdown_peripheral_multifunction and markmipi_dsi_shutdown_peripheralfucntion as deprecated.Signed-off-by Avinal Kumar <[email protected]>--- drivers/gpu/drm/drm_mipi_dsi.c | 28 ++++++++++++++++++++++++++++ include/drm/drm_mipi_dsi.h | 1 + 2 files changed, 29 insertions(+)drivers/gpu/drm/drm_mipi_dsi.c +28
-0@@ -587,6 +587,9 @@ EXPORT_SYMBOL(mipi_dsi_create_packet);* mipi_dsi_shutdown_peripheral() - sends a Shutdown Peripheral command * @dsi: DSI peripheral device * +* This function is deprecated. Use mipi_dsi_shutdown_peripheral_multi() +* instead. +* * Return: 0 on success or a negative error code on failure. */ int mipi_dsi_shutdown_peripheral (struct mipi_dsi_device *dsi)@@ -1980,6 +1983,31 @@ void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_dsi_multi_context *ctx, }EXPORT_SYMBOL (mipi_dsi_dcs_set_tear_scanline_multi); +/** +* mipi_dsi_shutdown_peripheral_multi() - sends a Shutdown Peripheral command +* @ctx: Context for multiple DSI transactions +* +* Like mipi_dsi_shutdown_peripheral() but deals with errors in a way that +* makes it convienient to make seeral calls in a row. +*/ +void mipi_dsi_shutdown_peripheral_multi (struct mipi_dsi_multi_context *ctx) +{ +struct mipi_dsi_device *dsi = ctx->dsi; +struct device *dev = &dsi->dev; +int ret; + +if (ctx->accum_err) +return ; + + ret =mipi_dsi_shutdown_peripheral (dsi); +if (ret <0 ) { + ctx->accum_err = ret; +dev_err (dev,"Failed to shutdown peripheral: %d\n" , + ctx->accum_err); + } +} +EXPORT_SYMBOL (mipi_dsi_shutdown_peripheral_multi); +static int mipi_dsi_drv_probe (struct device *dev) {struct mipi_dsi_driver *drv =to_mipi_dsi_driver (dev->driver);include/drm/drm_mipi_dsi.h +0
-0
include/drm/drm_mipi_dsi.h void mipi_dsi_dcs_set_page_address_multi(struct mipi_dsi_multi_context *ctx, · line 395
Quoted 7 lines
include/drm/drm_mipi_dsi.h +1
-0@@ -389,6 +389,7 @@ void mipi_dsi_dcs_set_page_address_multi(struct mipi_dsi_multi_context *ctx,void mipi_dsi_dcs_set_tear_scanline_multi (struct mipi_dsi_multi_context *ctx,u16 scanline);void mipi_dsi_dcs_set_tear_off_multi (struct mipi_dsi_multi_context *ctx); +void mipi_dsi_shutdown_peripheral_multi (struct mipi_dsi_multi_context *ctx);/** * mipi_dsi_generic_write_seq_multi - transmit data using a generic write packet
Thanks,
Neil
[email protected]
maintainerHi,
Quoted 2 lines · Avinal Kumar
Add
mipi_dsi_shutdown_peripheral_multifunction and markmipi_dsi_shutdown_peripheralfucntion as deprecated.
^^^^^^^^
Please fix typo
Quoted 22 lines
Signed-off-by Avinal Kumar <[email protected]>--- drivers/gpu/drm/drm_mipi_dsi.c | 28 ++++++++++++++++++++++++++++ include/drm/drm_mipi_dsi.h | 1 + 2 files changed, 29 insertions(+)drivers/gpu/drm/drm_mipi_dsi.c +3
-0@@ -587,6 +587,9 @@ EXPORT_SYMBOL(mipi_dsi_create_packet);* mipi_dsi_shutdown_peripheral() - sends a Shutdown Peripheral command * @dsi: DSI peripheral device * +* This function is deprecated. Use mipi_dsi_shutdown_peripheral_multi() +* instead. +* * Return: 0 on success or a negative error code on failure. */ int mipi_dsi_shutdown_peripheral (struct mipi_dsi_device *dsi)
drivers/gpu/drm/drm_mipi_dsi.c void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_dsi_multi_context *ctx, · line 1991
Quoted 9 lines
drivers/gpu/drm/drm_mipi_dsi.c +6
-0@@ -1980,6 +1983,31 @@ void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_dsi_multi_context *ctx, }EXPORT_SYMBOL (mipi_dsi_dcs_set_tear_scanline_multi); +/** +* mipi_dsi_shutdown_peripheral_multi() - sends a Shutdown Peripheral command +* @ctx: Context for multiple DSI transactions +* +* Like mipi_dsi_shutdown_peripheral() but deals with errors in a way that +* makes it convienient to make seeral calls in a row.
^^^^^^^^^^^
Please fix typo
Quoted 27 lines
drivers/gpu/drm/drm_mipi_dsi.c +19
-0+*/ +void mipi_dsi_shutdown_peripheral_multi (struct mipi_dsi_multi_context *ctx) +{ +struct mipi_dsi_device *dsi = ctx->dsi; +struct device *dev = &dsi->dev; +int ret; + +if (ctx->accum_err) +return ; + + ret =mipi_dsi_shutdown_peripheral (dsi); +if (ret <0 ) { + ctx->accum_err = ret; +dev_err (dev,"Failed to shutdown peripheral: %d\n" , + ctx->accum_err); + } +} +EXPORT_SYMBOL (mipi_dsi_shutdown_peripheral_multi); +static int mipi_dsi_drv_probe (struct device *dev) {struct mipi_dsi_driver *drv =to_mipi_dsi_driver (dev->driver);include/drm/drm_mipi_dsi.h +0
-0
include/drm/drm_mipi_dsi.h void mipi_dsi_dcs_set_page_address_multi(struct mipi_dsi_multi_context *ctx, · line 395
Quoted 7 lines
include/drm/drm_mipi_dsi.h +1
-0@@ -389,6 +389,7 @@ void mipi_dsi_dcs_set_page_address_multi(struct mipi_dsi_multi_context *ctx,void mipi_dsi_dcs_set_tear_scanline_multi (struct mipi_dsi_multi_context *ctx,u16 scanline);void mipi_dsi_dcs_set_tear_off_multi (struct mipi_dsi_multi_context *ctx); +void mipi_dsi_shutdown_peripheral_multi (struct mipi_dsi_multi_context *ctx);/** * mipi_dsi_generic_write_seq_multi - transmit data using a generic write packet
Please use scripts/checkpatch.pl on your patches
Thanks,
Neil