selftests/x86: clean up sysret_rip coding style
PATCH 1/1 selftests/x86: clean up sysret_rip coding style
Tidy up sysret_rip style (cast spacing, main(void), const placement). No functional change intended.
--- tools/testing/selftests/x86/sysret_rip.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
tools/testing/selftests/x86/sysret_rip.c +5 -7
@@ -31,7 +31,7 @@void test_syscall_ins (void );extern const char test_page[]; -static void const *current_test_page_addr = test_page; +static const void *current_test_page_addr = test_page;/* State used by our signal handlers. */ static gregset_t initial_regs;
@@ -40,7 +40,7 @@ static volatile unsigned long rip;static void sigsegv_for_sigreturn_test (int sig,siginfo_t *info,void *ctx_void) { -ucontext_t *ctx = (ucontext_t *)ctx_void; +ucontext_t *ctx = (ucontext_t *)ctx_void;if (rip != ctx->uc_mcontext.gregs[REG_RIP ]) { printf("[FAIL]\tRequested RIP=0x%lx but got RIP=0x%lx\n",
@@ -56,7 +56,7 @@ static void sigsegv_for_sigreturn_test(int sig, siginfo_t *info, void *ctx_void)static void sigusr1 (int sig,siginfo_t *info,void *ctx_void) { -ucontext_t *ctx = (ucontext_t *)ctx_void; +ucontext_t *ctx = (ucontext_t *)ctx_void;memcpy (&initial_regs, &ctx->uc_mcontext.gregs,sizeof (gregset_t));
@@ -69,8 +69,6 @@ static void sigusr1(int sig, siginfo_t *info, void *ctx_void) ctx->uc_mcontext.gregs[REG_R11]);sethandler (SIGSEGV , sigsegv_for_sigreturn_test,SA_RESETHAND ); - -return ; }static void test_sigreturn_to (unsigned long ip)
@@ -84,7 +82,7 @@ static jmp_buf jmpbuf;static void sigsegv_for_fallthrough (int sig,siginfo_t *info,void *ctx_void) { -ucontext_t *ctx = (ucontext_t *)ctx_void; +ucontext_t *ctx = (ucontext_t *)ctx_void;if (rip != ctx->uc_mcontext.gregs[REG_RIP ]) { printf("[FAIL]\tExpected SIGSEGV at 0x%lx but got RIP=0x%lx\n",
@@ -130,7 +128,7 @@ static void test_syscall_fallthrough_to(unsigned long ip)printf ("[OK]\tWe survived\n" ); } -int main () +int main (void ) {/* * When the kernel returns from a slow-path syscall, it will
Signature · 1 line
2.43.0
Borislav Petkov
maintainerQuoted 4 lines · neogulmanpassingby
Tidy up
sysret_ripstyle (cast spacing, main(void), const placement). No functional change intended.Signed-off-by neogulmanpassingby <[email protected]>
"then you just add a line saying:
using a known identity (sorry, no anonymous contributions.)"
^^^^^^^^^^^^^^
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquettePATCH v2 1/1 selftests/x86: clean up sysret_rip coding style
In reply to neogulmanpassingbyTidy up sysret_rip style (cast spacing, main(void), const placement). No functional change intended.
---
v2:
- Use real name in Signed-off-by (per feedback). No code changes.
tools/testing/selftests/x86/sysret_rip.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
tools/testing/selftests/x86/sysret_rip.c +5 -7
@@ -31,7 +31,7 @@void test_syscall_ins (void );extern const char test_page[]; -static void const *current_test_page_addr = test_page; +static const void *current_test_page_addr = test_page;/* State used by our signal handlers. */ static gregset_t initial_regs;
@@ -40,7 +40,7 @@ static volatile unsigned long rip;static void sigsegv_for_sigreturn_test (int sig,siginfo_t *info,void *ctx_void) { -ucontext_t *ctx = (ucontext_t *)ctx_void; +ucontext_t *ctx = (ucontext_t *)ctx_void;if (rip != ctx->uc_mcontext.gregs[REG_RIP ]) { printf("[FAIL]\tRequested RIP=0x%lx but got RIP=0x%lx\n",
@@ -56,7 +56,7 @@ static void sigsegv_for_sigreturn_test(int sig, siginfo_t *info, void *ctx_void)static void sigusr1 (int sig,siginfo_t *info,void *ctx_void) { -ucontext_t *ctx = (ucontext_t *)ctx_void; +ucontext_t *ctx = (ucontext_t *)ctx_void;memcpy (&initial_regs, &ctx->uc_mcontext.gregs,sizeof (gregset_t));
@@ -69,8 +69,6 @@ static void sigusr1(int sig, siginfo_t *info, void *ctx_void) ctx->uc_mcontext.gregs[REG_R11]);sethandler (SIGSEGV , sigsegv_for_sigreturn_test,SA_RESETHAND ); - -return ; }static void test_sigreturn_to (unsigned long ip)
@@ -84,7 +82,7 @@ static jmp_buf jmpbuf;static void sigsegv_for_fallthrough (int sig,siginfo_t *info,void *ctx_void) { -ucontext_t *ctx = (ucontext_t *)ctx_void; +ucontext_t *ctx = (ucontext_t *)ctx_void;if (rip != ctx->uc_mcontext.gregs[REG_RIP ]) { printf("[FAIL]\tExpected SIGSEGV at 0x%lx but got RIP=0x%lx\n",
@@ -130,7 +128,7 @@ static void test_syscall_fallthrough_to(unsigned long ip)printf ("[OK]\tWe survived\n" ); } -int main () +int main (void ) {/* * When the kernel returns from a slow-path syscall, it will
Signature · 1 line
2.43.0
[tip: x86/cleanups] selftests/x86: Clean up sysret_rip coding style
The following commit has been merged into the x86/cleanups branch of tip:
The following commit has been merged into the x86/cleanups branch of tip:
Commit-ID: 59cac9d52b885cbeba45fa455417b03dfb03eaa7 Gitweb: https://git.kernel.org/tip/59cac9d52b885cbeba45fa455417b03dfb03eaa7 Author: UYeol Jo <[email protected]> AuthorDate: Mon, 12 Jan 2026 06:01:26 +09:00 Committer: Borislav Petkov (AMD) <[email protected]> CommitterDate: Mon, 19 Jan 2026 12:06:11 +01:00
selftests/x86: Clean up sysret_rip coding style
Tidy up sysret_rip style (cast spacing, main(void), const placement). No functional change intended.
--- tools/testing/selftests/x86/sysret_rip.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
tools/testing/selftests/x86/sysret_rip.c +5 -7
@@ -31,7 +31,7 @@void test_syscall_ins (void );extern const char test_page[]; -static void const *current_test_page_addr = test_page; +static const void *current_test_page_addr = test_page;/* State used by our signal handlers. */ static gregset_t initial_regs;
@@ -40,7 +40,7 @@ static volatile unsigned long rip;static void sigsegv_for_sigreturn_test (int sig,siginfo_t *info,void *ctx_void) { -ucontext_t *ctx = (ucontext_t *)ctx_void; +ucontext_t *ctx = (ucontext_t *)ctx_void;if (rip != ctx->uc_mcontext.gregs[REG_RIP ]) { printf("[FAIL]\tRequested RIP=0x%lx but got RIP=0x%lx\n",
@@ -56,7 +56,7 @@ static void sigsegv_for_sigreturn_test(int sig, siginfo_t *info, void *ctx_void)static void sigusr1 (int sig,siginfo_t *info,void *ctx_void) { -ucontext_t *ctx = (ucontext_t *)ctx_void; +ucontext_t *ctx = (ucontext_t *)ctx_void;memcpy (&initial_regs, &ctx->uc_mcontext.gregs,sizeof (gregset_t));
@@ -69,8 +69,6 @@ static void sigusr1(int sig, siginfo_t *info, void *ctx_void) ctx->uc_mcontext.gregs[REG_R11]);sethandler (SIGSEGV , sigsegv_for_sigreturn_test,SA_RESETHAND ); - -return ; }static void test_sigreturn_to (unsigned long ip)
@@ -84,7 +82,7 @@ static jmp_buf jmpbuf;static void sigsegv_for_fallthrough (int sig,siginfo_t *info,void *ctx_void) { -ucontext_t *ctx = (ucontext_t *)ctx_void; +ucontext_t *ctx = (ucontext_t *)ctx_void;if (rip != ctx->uc_mcontext.gregs[REG_RIP ]) { printf("[FAIL]\tExpected SIGSEGV at 0x%lx but got RIP=0x%lx\n",
@@ -130,7 +128,7 @@ static void test_syscall_fallthrough_to(unsigned long ip)printf ("[OK]\tWe survived\n" ); } -int main () +int main (void ) {/* * When the kernel returns from a slow-path syscall, it will