Skip to contentSkip to conversation

nvme/host: fixup some typos

PATCH Superseded Wilfred Mallawa 3 participants 3 messages Jan 11 – Jan 13 NVMe

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 nvme/host: fixup some typos

From: Wilfred Mallawa <[email protected]>

Fix up some minor typos in the nvme host driver and a comment style to conform to the standard kernel style.

---
V3:
- Fixup the comment to standarn kernel style
- Drop french style spacing removal.

---
 drivers/nvme/host/tcp.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/nvme/host/tcp.c +3 -2
index 69cb04406b47..92749f6d0f96 100644
@@ -25,7 +25,8 @@
 
 struct nvme_tcp_queue;
 
-/* Define the socket priority to use for connections were it is desirable
+/*
+ * Define the socket priority to use for connections where it is desirable
  * that the NIC consider performing optimized packet processing or filtering.
  * A non-zero value being sufficient to indicate general consideration of any
  * possible optimization.  Making it a module param allows for alternative
@@ -926,7 +927,7 @@ static int nvme_tcp_recv_data(struct nvme_tcp_queue *queue, struct sk_buff *skb,
 			req->curr_bio = req->curr_bio->bi_next;
 
 			/*
-			 * If we don`t have any bios it means that controller
+			 * If we don't have any bios it means that controller
 			 * sent more data than we requested, hence error
 			 */
 			if (!req->curr_bio) {
Signature · 1 line
2.52.0
#1 lore raw
Quoted 30 lines · Wilfred Mallawa

From: Wilfred Mallawa <[email protected]>

Fix up some minor typos in the nvme host driver and a comment style to conform to the standard kernel style.

---
V3:
- Fixup the comment to standarn kernel style
- Drop french style spacing removal.

---
 drivers/nvme/host/tcp.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/nvme/host/tcp.c +2 -1
index 69cb04406b47..92749f6d0f96 100644
@@ -25,7 +25,8 @@
 
 struct nvme_tcp_queue;
 
-/* Define the socket priority to use for connections were it is desirable
+/*
+ * Define the socket priority to use for connections where it is desirable
  * that the NIC consider performing optimized packet processing or filtering.
  * A non-zero value being sufficient to indicate general consideration of any
  * possible optimization.  Making it a module param allows for alternative

drivers/nvme/host/tcp.c static int nvme_tcp_recv_data(struct nvme_tcp_queue *queue, struct sk_buff *skb, · line 930

Quoted 5 lines
drivers/nvme/host/tcp.c +1 -1
@@ -926,7 +927,7 @@ static int nvme_tcp_recv_data(struct nvme_tcp_queue *queue, struct sk_buff *skb,
 			req->curr_bio = req->curr_bio->bi_next;
 
 			/*
-			 * If we don`t have any bios it means that controller
+			 * If we don't have any bios it means that controller

Since you are correcting things, please do correct the grammar too:
...that the controller... :)

Personally, I prefer a more formal style, so I would also change "don't" into "do not".

Quoted 3 lines
drivers/nvme/host/tcp.c +0 -0
 			 * sent more data than we requested, hence error
 			 */
 			if (!req->curr_bio) {
Signature · 2 lines
Damien Le Moal
Western Digital Research