Skip to contentSkip to conversation

tests/qemu-iotests: Mark 182 as Linux-only

PATCH In review Thomas Huth 3 participants 3 messages Jan 13 – Jan 14

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/qemu-iotests: Mark 182 as Linux-only

From: Thomas Huth <[email protected]>

Running test 182 on FreeBSD fails with this error message in the output:

+warning: File lock requested but OFD locking syscall is unavailable, falling back to POSIX file locks +Due to the implementation, locks can be lost unexpectedly.

OFD locks seem to be only available on Linux, so let's mark this test as Linux-only to silence the failure.

---
 tests/qemu-iotests/182 | 1 +
 1 file changed, 1 insertion(+)
tests/qemu-iotests/182 +1 -0
index bbd1132b052..af5eeb599c1 100755
@@ -43,6 +43,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 
 _supported_fmt qcow2
 _supported_proto file
+_supported_os Linux
 
 size=32M
 
Signature · 1 line
2.52.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Thomas Huth

From: Thomas Huth <[email protected]>

Running test 182 on FreeBSD fails with this error message in the output:

+warning: File lock requested but OFD locking syscall is unavailable, falling back to POSIX file locks +Due to the implementation, locks can be lost unexpectedly.

Quoted 7 lines

OFD locks seem to be only available on Linux, so let's mark this test as Linux-only to silence the failure.

---
 tests/qemu-iotests/182 | 1 +
 1 file changed, 1 insertion(+)

With regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#2 lore raw
In reply to Thomas Huth
Quoted 9 lines · Thomas Huth

From: Thomas Huth <[email protected]>

Running test 182 on FreeBSD fails with this error message in the output:

+warning: File lock requested but OFD locking syscall is unavailable, falling back to POSIX file locks +Due to the implementation, locks can be lost unexpectedly.

OFD locks seem to be only available on Linux, so let's mark this test as Linux-only to silence the failure.

OFD locks are part of POSIX now, so eventually new-enough BSD will have them. Is it worth trying to be more specific and testing for the actual feature that we are depending on, rather than just limiting the test to an early-adopter OS? That said, I don't have any quick ideas on how to do a more-specific feature test, so I don't mind this going in as-is; we already know BSD gets less coverage for other reasons.

Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org