Skip to contentSkip to conversation

pwm: max7360: populate missing .sizeof_wfhw in max7360_pwm_ops

PATCH In review Richard Genoud 2 participants 2 messages Jan 13 – Jan 14

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pwm: max7360: populate missing .sizeof_wfhw in max7360_pwm_ops

The sizeof_wfhw field wasn't populated in max7360_pwm_ops so it was set to 0 by default.
While this is ok for now because:
sizeof(struct max7360_pwm_waveform) < PWM_WFHWSIZE
in the future, if struct max7360_pwm_waveform grows, it could lead to stack corruption.

Fixes d93a75d94b79 ("pwm: max7360: Add MAX7360 PWM support")
---
 drivers/pwm/pwm-max7360.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pwm/pwm-max7360.c +1 -0
index 16261958ce7f..732969303dd7 100644
@@ -153,6 +153,7 @@ static int max7360_pwm_read_waveform(struct pwm_chip *chip,
 }
 
 static const struct pwm_ops max7360_pwm_ops = {
+	.sizeof_wfhw = sizeof(struct max7360_pwm_waveform),
 	.request = max7360_pwm_request,
 	.round_waveform_tohw = max7360_pwm_round_waveform_tohw,
 	.round_waveform_fromhw = max7360_pwm_round_waveform_fromhw,

base-commit: 0f61b1860cc3f52aef9036d7235ed1f017632193

Signature · 1 line
2.47.3
#1 lore raw

Hello Richard,

Quoted 18 lines · Richard Genoud

The sizeof_wfhw field wasn't populated in max7360_pwm_ops so it was set to 0 by default.
While this is ok for now because:
sizeof(struct max7360_pwm_waveform) < PWM_WFHWSIZE
in the future, if struct max7360_pwm_waveform grows, it could lead to stack corruption.

Fixes d93a75d94b79 ("pwm: max7360: Add MAX7360 PWM support")
---
 drivers/pwm/pwm-max7360.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pwm/pwm-max7360.c +0 -0
index 16261958ce7f..732969303dd7 100644

drivers/pwm/pwm-max7360.c static int max7360_pwm_read_waveform(struct pwm_chip *chip, · line 159

Quoted 7 lines
drivers/pwm/pwm-max7360.c +1 -0
@@ -153,6 +153,7 @@ static int max7360_pwm_read_waveform(struct pwm_chip *chip,
 }
 
 static const struct pwm_ops max7360_pwm_ops = {
+	.sizeof_wfhw = sizeof(struct max7360_pwm_waveform),
 	.request = max7360_pwm_request,
 	.round_waveform_tohw = max7360_pwm_round_waveform_tohw,
 	.round_waveform_fromhw = max7360_pwm_round_waveform_fromhw,

good catch. For the reason stated in the commit log I'd not consider that urgent (so I won't bother Linus with it before 6.19).

I applied it as is to

https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next

. But I'm still taking review tags.

Best regards
Uwe