Skip to contentSkip to conversation

configure: Remove duplicated entry of --gdb in the help text

PATCH In review Thomas Huth 4 participants 6 messages Jan 14 – Feb 2

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configure: Remove duplicated entry of --gdb in the help text

From: Thomas Huth <[email protected]>

Since --gdb has recently been added to meson_options.txt, the help text shows up twice in the output of "./configure --help":

 $ ./configure --help | grep gdb
   --gdb=GDB-path           gdb to use for gdbstub tests [/usr/bin/gdb]
   --gdb=VALUE              Path to GDB

Remove the entry from "configure" to fix this duplication.

Fixes b46b3818cf8 ("tests/functional: Provide GDB to the functional tests")
---
 configure | 1 -
 1 file changed, 1 deletion(-)
configure +0 -1
index ef5157cf903..093dd7b01eb 100755
@@ -899,7 +899,6 @@ Advanced options (experts only):
   --cpu=CPU                Build for host CPU [$cpu]
   --disable-containers     don't use containers for cross-building
   --container-engine=TYPE  which container engine to use [$container_engine]
-  --gdb=GDB-path           gdb to use for gdbstub tests [$gdb_bin]
 EOF
   meson_options_help
 cat << EOF
Signature · 1 line
2.52.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Thomas Huth

From: Thomas Huth <[email protected]>

Since --gdb has recently been added to meson_options.txt, the help text shows up twice in the output of "./configure --help":

 $ ./configure --help | grep gdb
   --gdb=GDB-path           gdb to use for gdbstub tests [/usr/bin/gdb]
   --gdb=VALUE              Path to GDB
Quoted 7 lines

Remove the entry from "configure" to fix this duplication.

Fixes b46b3818cf8 ("tests/functional: Provide GDB to the functional tests")
---
 configure | 1 -
 1 file changed, 1 deletion(-)

With regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#2 lore raw
In reply to Thomas Huth
Quoted 8 lines · Thomas Huth

From: Thomas Huth <[email protected]>

Since --gdb has recently been added to meson_options.txt, the help text shows up twice in the output of "./configure --help":

 $ ./configure --help | grep gdb
   --gdb=GDB-path           gdb to use for gdbstub tests [/usr/bin/gdb]
   --gdb=VALUE              Path to GDB

It's a shame to loose the default value - is there anyway for the meson version to show the auto-detected value?

Quoted 21 lines

Remove the entry from "configure" to fix this duplication.

Fixes b46b3818cf8 ("tests/functional: Provide GDB to the functional tests")
---
 configure | 1 -
 1 file changed, 1 deletion(-)
configure +0 -1
index ef5157cf903..093dd7b01eb 100755
@@ -899,7 +899,6 @@ Advanced options (experts only):
   --cpu=CPU                Build for host CPU [$cpu]
   --disable-containers     don't use containers for cross-building
   --container-engine=TYPE  which container engine to use [$container_engine]
-  --gdb=GDB-path           gdb to use for gdbstub tests [$gdb_bin]
 EOF
   meson_options_help
 cat << EOF
Signature · 2 lines
Alex Bennée
Virtualisation Tech Lead @ Linaro
#3 lore raw
Quoted 7 lines · Alex Bennée
Quoted 5 lines · Thomas Huth

From: Thomas Huth <[email protected]>

Since --gdb has recently been added to meson_options.txt, the help text shows up twice in the output of "./configure --help":

Quoted 6 lines
Quoted 3 lines
  $ ./configure --help | grep gdb
    --gdb=GDB-path           gdb to use for gdbstub tests [/usr/bin/gdb]
    --gdb=VALUE              Path to GDB

It's a shame to loose the default value - is there anyway for the meson version to show the auto-detected value?

Maybe we can drop this line from meson but keep it in ./configure?

/mjt

#4 lore raw
Quoted 8 lines · Michael Tokarev
Quoted 7 lines · Alex Bennée
Quoted 5 lines · Thomas Huth

From: Thomas Huth <[email protected]>

Since --gdb has recently been added to meson_options.txt, the help text shows up twice in the output of "./configure --help":

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
  $ ./configure --help | grep gdb
    --gdb=GDB-path           gdb to use for gdbstub tests [/usr/bin/gdb]
    --gdb=VALUE              Path to GDB

It's a shame to loose the default value - is there anyway for the meson version to show the auto-detected value?

Maybe we can drop this line from meson but keep it in ./configure?

The meson stuff is generated automatically, so no clue how that could be done in a nice way?

Thomas

#5 lore raw
Quoted 13 lines · Thomas Huth
Quoted 12 lines · Michael Tokarev
Quoted 11 lines · Alex Bennée
Quoted 8 lines · Thomas Huth

From: Thomas Huth <[email protected]>

Since --gdb has recently been added to meson_options.txt, the help text shows up twice in the output of "./configure --help":

  $ ./configure --help | grep gdb
    --gdb=GDB-path           gdb to use for gdbstub tests [/usr/bin/gdb]
    --gdb=VALUE              Path to GDB
Quoted 6 lines
Quoted 3 lines
Quoted 2 lines

It's a shame to loose the default value - is there anyway for the meson version to show the auto-detected value?

Maybe we can drop this line from meson but keep it in ./configure?

The meson stuff is generated automatically, so no clue how that could be done in a nice way?

I tried the other way around and squashed the meson_options_help text with:

[email protected]

Quoted 2 lines

Thomas

Signature · 2 lines
Alex Bennée
Virtualisation Tech Lead @ Linaro