Skip to contentSkip to conversation

staging: fbtft: replace udelay with usleep_range

PATCH In review WooYoung Jeon 3 participants 3 messages Jan 15

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: fbtft: replace udelay with usleep_range

In the fb_ra8875 driver, udelay(100) is used for delay which causes busy-waiting. Replacing it with usleep_range(100, 120) allows the CPU to sleep during the delay, improving system resource efficiency.

This change was suggested by checkpatch.pl.

---
 drivers/staging/fbtft/fb_ra8875.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fb_ra8875.c +1 -1
index 0ab1de664..92c9e4e03 100644
@@ -210,7 +210,7 @@ static void write_reg8_bus8(struct fbtft_par *par, int len, ...)
 	}
 	len--;
 
-	udelay(100);
+	usleep_range(100, 120);
 
 	if (len) {
 		buf = (u8 *)par->buf;
Signature · 1 line
2.43.0
#1 lore raw
Quoted 6 lines · WooYoung Jeon

In the fb_ra8875 driver, udelay(100) is used for delay which causes busy-waiting. Replacing it with usleep_range(100, 120) allows the CPU to sleep during the delay, improving system resource efficiency.

This change was suggested by checkpatch.pl.

Without HW test it's no go. See the previous attempts to "fix" the same place over and over. (https://lore.kernel.org/ is at your service to dive into mail archives)

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
In reply to WooYoung Jeon
Quoted 28 lines · WooYoung Jeon

In the fb_ra8875 driver, udelay(100) is used for delay which causes busy-waiting. Replacing it with usleep_range(100, 120) allows the CPU to sleep during the delay, improving system resource efficiency.

This change was suggested by checkpatch.pl.

---
 drivers/staging/fbtft/fb_ra8875.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fb_ra8875.c +1 -1
index 0ab1de664..92c9e4e03 100644
@@ -210,7 +210,7 @@ static void write_reg8_bus8(struct fbtft_par *par, int len, ...)
 	}
 	len--;
 
-	udelay(100);
+	usleep_range(100, 120);
 
 	if (len) {
 		buf = (u8 *)par->buf;
Signature · 1 line
2.43.0

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- You sent a patch that has been sent multiple times in the past and is identical to ones that have been rejected. Please always look at the mailing list traffic to determine if you are duplicating other people's work.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot