f2fs: fix to unlock folio in f2fs_read_data_large_folio()
Chao Yu
maintainerPATCH v2 1/1 f2fs: fix to unlock folio in f2fs_read_data_large_folio()
We missed to unlock folio in error path of f2fs_read_data_large_folio(), fix it.
With below testcase, it can reproduce the bug.
touch /mnt/f2fs/file
truncate -s $((1024*1024*1024)) /mnt/f2fs/file f2fs_io setflags immutable /mnt/f2fs/file
sync
echo 3 > /proc/sys/vm/drop_caches
time dd if=/mnt/f2fs/file of=/dev/null bs=1M count=1024 f2fs_io clearflags immutable /mnt/f2fs/file echo 1 > /proc/sys/vm/drop_caches
time dd if=/mnt/f2fs/file of=/dev/null bs=1M count=1024 time dd if=/mnt/f2fs/file of=/dev/null bs=1M count=1024
---
v2:
- rebase to last dev-test branch
fs/f2fs/data.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-)
fs/f2fs/data.c +10 -12
@@ -2453,11 +2453,11 @@ static int f2fs_read_data_large_folio(struct inode *inode,int ret =0 ;bool folio_in_bio; -if (!IS_IMMUTABLE (inode)) -return -EOPNOTSUPP ; - -if (f2fs_compressed_file (inode)) +if (!IS_IMMUTABLE (inode) ||f2fs_compressed_file (inode)) { +if (folio) +folio_unlock (folio);return -EOPNOTSUPP ; + } map.m_seg_type =NO_CHECK_TYPE ;
@@ -2565,18 +2565,16 @@ static int f2fs_read_data_large_folio(struct inode *inode, last_block_in_bio = block_nr; }trace_f2fs_read_folio (folio,DATA ); +err_out: +if (!folio_in_bio) { +folio_end_read (folio, !ret); +if (ret) +return ret; + }if (rac) { -if (!folio_in_bio) -folio_end_read (folio, true); folio =readahead_folio (rac); goto next_folio; } -err_out: -/* Nothing was submitted. */ -if (!bio) { -folio_end_read (folio, !ret); -return ret; - } out:f2fs_submit_read_bio (F2FS_I_SB (inode), bio,DATA );if (ret) {
Signature · 1 line
2.40.1
This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:
Quoted 16 lines · On Fri, 16 Jan 2026 14:31:15 +0800 you wrote:
We missed to unlock folio in error path of
f2fs_read_data_large_folio(), fix it.With below testcase, it can reproduce the bug.
touch
/mnt/f2fs/file
truncate -s $((1024*1024*1024))/mnt/f2fs/filef2fs_iosetflags immutable/mnt/f2fs/file
sync
echo 3 >/proc/sys/vm/drop_caches
time dd if=/mnt/f2fs/file of=/dev/null bs=1M count=1024f2fs_ioclearflags immutable/mnt/f2fs/fileecho 1 >/proc/sys/vm/drop_caches
time dd if=/mnt/f2fs/file of=/dev/null bs=1M count=1024 time dd if=/mnt/f2fs/file of=/dev/null bs=1M count=1024
Quoted 1 line
[...]
Here is the summary with links:
- [f2fs-dev,v2] f2fs: fix to unlock folio in f2fs_read_data_large_folio()
https://git.kernel.org/jaegeuk/f2fs/c/a5d8b9d94e18
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html