Skip to contentSkip to conversation

most: core: fix leak on early registration failure

PATCH New Johan Hovold 1 participant 1 message Jan 16 Most(r) technology driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 most: core: fix leak on early registration failure

A recent commit fixed a resource leak on early registration failures but for some reason left out the first error path which still leaks the resources associated with the interface.

Fix up also the first error path so that the interface is always released on errors.

Fixes 1f4c9d8a1021 ("most: core: fix resource leak in most_register_interface error paths")
Fixes 723de0f9171e ("staging: most: remove device from interface structure")
Cc Christian Gromm <[email protected]>
Cc Navaneeth K <[email protected]>

---

This complements the above mentioned fix which is currently in the char-misc-next branch.

Johan

 drivers/most/core.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/most/core.c +7 -2
index 6277e6702ca8..40d63e38fef5 100644
@@ -1282,12 +1282,17 @@ int most_register_interface(struct most_interface *iface)
 	int id;
 	struct most_channel *c;
 
-	if (!iface || !iface->enqueue || !iface->configure ||
-	    !iface->poison_channel || (iface->num_channels > MAX_CHANNELS))
+	if (!iface)
 		return -EINVAL;
 
 	device_initialize(iface->dev);
 
+	if (!iface->enqueue || !iface->configure || !iface->poison_channel ||
+	    (iface->num_channels > MAX_CHANNELS)) {
+		put_device(iface->dev);
+		return -EINVAL;
+	}
+
 	id = ida_alloc(&mdev_id, GFP_KERNEL);
 	if (id < 0) {
 		dev_err(iface->dev, "Failed to allocate device ID\n");
Signature · 1 line
2.52.0