lib/test_min_heap: fix incorrect module description
PATCH 1/1 lib/test_min_heap: fix incorrect module description
The module description incorrectly mentions "min max heap", but the test module is specifically designed for testing the min heap implementation. Correct the metadata to match the code.
--- lib/test_min_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/test_min_heap.c +1 -1
@@ -218,5 +218,5 @@ static void __exit test_min_heap_exit(void) }module_exit (test_min_heap_exit); -MODULE_DESCRIPTION ("Test cases for the min max heap" ); +MODULE_DESCRIPTION ("Test cases for the min heap" );MODULE_LICENSE ("GPL" );
Signature · 1 line
2.43.0
Hi Nick,
Quoted 3 lines · Nick Huang
The module description incorrectly mentions "min max heap", but the test module is specifically designed for testing the min heap implementation. Correct the metadata to match the code.
Thanks for the patch, but I don't think this change is necessary.
As noted in commit 6e24628d78e4 ("lib: Introduce generic min-heap"), the implementation easily supports a max heap by simply inverting the comparison function.
Since this module explicitly tests both min heap and max heap scenarios, the current description accurately reflects the test coverage.
Regards,
Kuan-Wei
Quoted 20 lines
Signed-off-by Nick Huang <[email protected]>--- lib/test_min_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/test_min_heap.c +1
-1@@ -218,5 +218,5 @@ static void __exit test_min_heap_exit(void) }module_exit (test_min_heap_exit); -MODULE_DESCRIPTION ("Test cases for the min max heap" ); +MODULE_DESCRIPTION ("Test cases for the min heap" );MODULE_LICENSE ("GPL" );Signature · 1 line
2.43.0
A message that is not in the archive (sent off-list or not yet received): CABZAGRFuq7h=-Z0wYfasLV4a1nY_iaNtJHN9W3PpeJc6=OP3Qw@mail.gmail.com
Hi Nick,
Quoted 19 lines · Nick Huang
Kuan-Wei Chiu <[email protected]> 於 2026年1月19日週一 下午9:26寫道:
Quoted 17 lines
Hi Nick,
Quoted 3 lines · Nick Huang
The module description incorrectly mentions "min max heap", but the test module is specifically designed for testing the min heap implementation. Correct the metadata to match the code.
Thanks for the patch, but I don't think this change is necessary.
As noted in commit
6e24628d78e4("lib: Introduce generic min-heap"), the implementation easily supports a max heap by simply inverting the comparison function.Since this module explicitly tests both min heap and max heap scenarios, the current description accurately reflects the test coverage.
Quoted 8 lines
Quoted 3 lines
Regards,
Kuan-WeiHi Kuan-Wei
Thanks for your clarification!
For future reference, please ensure your emails are plain text only, without html or base64 encoding.
Regards,
Kuan-Wei
Kuan-Wei Chiu <[email protected]> 於 2026年1月19日週一 下午10:06寫道:
Quoted 29 lines
Hi Nick,
Quoted 25 lines · Nick Huang
Kuan-Wei Chiu <[email protected]> 於 2026年1月19日週一 下午9:26寫道:
Quoted 13 lines
Hi Nick,
Quoted 3 lines · Nick Huang
The module description incorrectly mentions "min max heap", but the test module is specifically designed for testing the min heap implementation. Correct the metadata to match the code.
Thanks for the patch, but I don't think this change is necessary.
As noted in commit
6e24628d78e4("lib: Introduce generic min-heap"), the implementation easily supports a max heap by simply inverting the comparison function.Quoted 7 lines
Since this module explicitly tests both min heap and max heap scenarios, the current description accurately reflects the test coverage.
Regards,
Kuan-WeiHi Kuan-Wei
Quoted 8 lines
Quoted 2 lines
Thanks for your clarification!
For future reference, please ensure your emails are plain text only, without html or base64 encoding.
Regards,
Kuan-Wei
Hi Kuan-Wei
Thanks for the reminder. I'll make sure to send my future emails in plain text only.
Regards,
Nick Huang