Skip to contentSkip to conversation

lib/test_min_heap: fix incorrect module description

PATCH In review Nick Huang 2 participants 4 messages Jan 19 – Jan 20 1 message not in the archive Library code

lore
Share & tools
lore

Nick Huang

author
#0 lore raw

PATCH 1/1 lib/test_min_heap: fix incorrect module description

The module description incorrectly mentions "min max heap", but the test module is specifically designed for testing the min heap implementation. Correct the metadata to match the code.

---
 lib/test_min_heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/test_min_heap.c +1 -1
index a9c4a74d3..9e42a805b 100644
@@ -218,5 +218,5 @@ static void __exit test_min_heap_exit(void)
 }
 module_exit(test_min_heap_exit);
 
-MODULE_DESCRIPTION("Test cases for the min max heap");
+MODULE_DESCRIPTION("Test cases for the min heap");
 MODULE_LICENSE("GPL");
Signature · 1 line
2.43.0
#1 lore raw

Hi Nick,

Quoted 3 lines · Nick Huang

The module description incorrectly mentions "min max heap", but the test module is specifically designed for testing the min heap implementation. Correct the metadata to match the code.

Thanks for the patch, but I don't think this change is necessary.

As noted in commit 6e24628d78e4 ("lib: Introduce generic min-heap"), the implementation easily supports a max heap by simply inverting the comparison function.

Since this module explicitly tests both min heap and max heap scenarios, the current description accurately reflects the test coverage.

Regards,
Kuan-Wei

Quoted 20 lines
---
 lib/test_min_heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/test_min_heap.c +1 -1
index a9c4a74d3..9e42a805b 100644
@@ -218,5 +218,5 @@ static void __exit test_min_heap_exit(void)
 }
 module_exit(test_min_heap_exit);
 
-MODULE_DESCRIPTION("Test cases for the min max heap");
+MODULE_DESCRIPTION("Test cases for the min heap");
 MODULE_LICENSE("GPL");
Signature · 1 line
2.43.0

A message that is not in the archive (sent off-list or not yet received): CABZAGRFuq7h=-Z0wYfasLV4a1nY_iaNtJHN9W3PpeJc6=OP3Qw@mail.gmail.com

#3 lore raw

Hi Nick,

Quoted 19 lines · Nick Huang

Kuan-Wei Chiu <[email protected]> 於 2026年1月19日週一 下午9:26寫道:

Quoted 17 lines

Hi Nick,

Quoted 3 lines · Nick Huang

The module description incorrectly mentions "min max heap", but the test module is specifically designed for testing the min heap implementation. Correct the metadata to match the code.

Thanks for the patch, but I don't think this change is necessary.

As noted in commit 6e24628d78e4 ("lib: Introduce generic min-heap"), the implementation easily supports a max heap by simply inverting the comparison function.

Since this module explicitly tests both min heap and max heap scenarios, the current description accurately reflects the test coverage.

Quoted 8 lines
Quoted 3 lines

Regards,
Kuan-Wei

Hi Kuan-Wei

Thanks for your clarification!

For future reference, please ensure your emails are plain text only, without html or base64 encoding.

Regards,
Kuan-Wei

author
#4 lore raw

Kuan-Wei Chiu <[email protected]> 於 2026年1月19日週一 下午10:06寫道:

Quoted 29 lines

Hi Nick,

Quoted 25 lines · Nick Huang

Kuan-Wei Chiu <[email protected]> 於 2026年1月19日週一 下午9:26寫道:

Quoted 13 lines

Hi Nick,

Quoted 3 lines · Nick Huang

The module description incorrectly mentions "min max heap", but the test module is specifically designed for testing the min heap implementation. Correct the metadata to match the code.

Thanks for the patch, but I don't think this change is necessary.

As noted in commit 6e24628d78e4 ("lib: Introduce generic min-heap"), the implementation easily supports a max heap by simply inverting the comparison function.

Quoted 7 lines

Since this module explicitly tests both min heap and max heap scenarios, the current description accurately reflects the test coverage.

Regards,
Kuan-Wei

Hi Kuan-Wei

Quoted 8 lines
Quoted 2 lines

Thanks for your clarification!

For future reference, please ensure your emails are plain text only, without html or base64 encoding.

Regards,
Kuan-Wei

Hi Kuan-Wei

Thanks for the reminder. I'll make sure to send my future emails in plain text only.

Regards,
Nick Huang