ASoC: SOF: Intel: hda: Remove MODULE_SOFTDEP for snd-hda-codec-hdmi
Subsystems (3)
Peter Ujfalusi
maintainerPATCH 1/1 ASoC: SOF: Intel: hda: Remove MODULE_SOFTDEP for snd-hda-codec-hdmi
The sofdep no longer works due to the reworked HDA audio stack and it was an incorrect way to try to work around system security policy blocking request_module use, even if they are legitimate.
Drop the softdep to stop the whack-a-mole hacking around system configuration issues.
Revert "ASoC: SOF: Intel: hda: add softdep pre to snd-hda-codec-hdmi module" This reverts commit 33b7dc7843dbdc9b90c91d11ba30b107f9138ffd.
--- sound/soc/sof/intel/hda-codec.c | 1 - 1 file changed, 1 deletion(-)
sound/soc/sof/intel/hda-codec.c +0 -1
@@ -451,7 +451,6 @@ int hda_codec_i915_exit(struct snd_sof_dev *sdev) }EXPORT_SYMBOL_NS_GPL (hda_codec_i915_exit,"SND_SOC_SOF_HDA_AUDIO_CODEC_I915" ); -MODULE_SOFTDEP ("pre: snd-hda-codec-hdmi" );#endif MODULE_LICENSE ("Dual BSD/GPL" );
Signature · 1 line
2.52.0
Mark Brown
maintainerQuoted 8 lines · Peter Ujfalusi
The sofdep no longer works due to the reworked HDA audio stack and it was an incorrect way to try to work around system security policy blocking
request_moduleuse, even if they are legitimate.Drop the softdep to stop the whack-a-mole hacking around system configuration issues.
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: SOF: Intel: hda: Remove MODULE_SOFTDEP for snd-hda-codec-hdmi
commit: 00ca2dd431fa2acb07b3ecc6ce49fb9a0a4d72cb
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark