Skip to contentSkip to conversation

ata: libata-core: Quirk INTEL SSDSC2KG480G8 max_sectors

PATCH Applied Niklas Cassel 3 participants 4 messages Jan 20 – Jan 26 1 message not in the archive libata

lore
Share & tools
lore

Niklas Cassel

author maintainer
#0 lore raw

PATCH 1/1 ata: libata-core: Quirk INTEL SSDSC2KG480G8 max_sectors

Commit 9b8b84879d4a ("block: Increase BLK_DEF_MAX_SECTORS_CAP") increased the default max_sectors_kb from 1280 KiB to 4096 KiB.

INTEL SSDSC2KG480G8 with FW rev XCV10120 times out when sending I/Os of size 4096 KiB.

Enable ATA_QUIRK_MAX_SEC, with value 8191 (sectors) for this device, since any I/O with more sectors than that lead to I/O timeouts.

With this, the INTEL SSDSC2KG480G8 is usable again.

Fixes 9b8b84879d4a ("block: Increase BLK_DEF_MAX_SECTORS_CAP")

---
Hello Wolf,

please test this patch and see if it works.

The patch is based on the for-next branch of:
git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git

 drivers/ata/libata-core.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/ata/libata-core.c +3 -0
index e888f2445692..8e41e8a33096 100644
@@ -4082,6 +4082,7 @@ static const struct ata_dev_quirk_value __ata_dev_max_sec_quirks[] = {
 	{ "LITEON CX1-JB*-HP",		NULL,		1024 },
 	{ "LITEON EP1-*",		NULL,		1024 },
 	{ "DELLBOSS VD",		"MV.R00-0",	8191 },
+	{ "INTEL SSDSC2KG480G8",	"XCV10120",	8191 },
 	{ },
 };
 
@@ -4336,6 +4337,8 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
 
 	{ "Micron*",			NULL,	ATA_QUIRK_ZERO_AFTER_TRIM },
 	{ "Crucial*",			NULL,	ATA_QUIRK_ZERO_AFTER_TRIM },
+	{ "INTEL SSDSC2KG480G8", "XCV10120",	ATA_QUIRK_ZERO_AFTER_TRIM |
+						ATA_QUIRK_MAX_SEC },
 	{ "INTEL*SSD*",			NULL,	ATA_QUIRK_ZERO_AFTER_TRIM },
 	{ "SSD*INTEL*",			NULL,	ATA_QUIRK_ZERO_AFTER_TRIM },
 	{ "Samsung*SSD*",		NULL,	ATA_QUIRK_ZERO_AFTER_TRIM },
Signature · 1 line
2.52.0
author maintainer
#2 lore raw
In reply to a message not in the archive

Hello Wolf,

Quoted 36 lines · Wolf
Quoted 32 lines

Hello Wolf,

please test this patch and see if it works.

The patch is based on the for-next branch of:
git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git

drivers/ata/libata-core.c | 3 +++

1 file changed, 3 insertions(+)
drivers/ata/libata-core.c +3 -1
index e888f2445692..8e41e8a33096 100644
@@ -4082,6 +4082,7 @@ static const struct ata_dev_quirk_value __ata_dev_max_sec_quirks[] = {
 { "LITEON CX1-JB*-HP", NULL, 1024 },
 { "LITEON EP1-", NULL, 1024 },
 { "DELLBOSS VD", "MV.R00-0", 8191 },
+ { "INTEL SSDSC2KG480G8", "XCV10120", 8191 },
 { },
 };
 
@@ -4336,6 +4337,8 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
 
 { "Micron", NULL, ATA_QUIRK_ZERO_AFTER_TRIM },
 { "Crucial*", NULL, ATA_QUIRK_ZERO_AFTER_TRIM },
+ { "INTEL SSDSC2KG480G8", "XCV10120", ATA_QUIRK_ZERO_AFTER_TRIM |
+ ATA_QUIRK_MAX_SEC },
 { "INTELSSD", NULL, ATA_QUIRK_ZERO_AFTER_TRIM },
 { "SSDINTEL", NULL, ATA_QUIRK_ZERO_AFTER_TRIM },
 { "SamsungSSD", NULL, ATA_QUIRK_ZERO_AFTER_TRIM },
--
Quoted 1 line

2.52.0

Hello Niklas,

Quoted 1 line

The patched linux/6.19.0~rc1 is working.

Thank you for testing!

Hopefully Damien can queue it up.

I suggest queueing it up for for-next,
since it depends on some patches there.

Kind regards,
Niklas

Reviewed-by on v1 1/1
#3 lore raw
In reply to Niklas Cassel

Niklas,

Quoted 8 lines

Commit 9b8b84879d4a ("block: Increase BLK_DEF_MAX_SECTORS_CAP") increased the default max_sectors_kb from 1280 KiB to 4096 KiB.

INTEL SSDSC2KG480G8 with FW rev XCV10120 times out when sending I/Os of size 4096 KiB.

Enable ATA_QUIRK_MAX_SEC, with value 8191 (sectors) for this device, since any I/O with more sectors than that lead to I/O timeouts.

Looks good.

Signature · 1 line
Martin K. Petersen
maintainer Applied
#4 lore raw
In reply to Niklas Cassel
Quoted 6 lines · Niklas Cassel

Commit 9b8b84879d4a ("block: Increase BLK_DEF_MAX_SECTORS_CAP") increased the default max_sectors_kb from 1280 KiB to 4096 KiB.

INTEL SSDSC2KG480G8 with FW rev XCV10120 times out when sending I/Os of size 4096 KiB.

Quoted 8 lines

Enable ATA_QUIRK_MAX_SEC, with value 8191 (sectors) for this device, since any I/O with more sectors than that lead to I/O timeouts.

With this, the INTEL SSDSC2KG480G8 is usable again.

Fixes 9b8b84879d4a ("block: Increase BLK_DEF_MAX_SECTORS_CAP")

Applied to for-6.20. Thanks !

Signature · 2 lines
Damien Le Moal
Western Digital Research