Skip to contentSkip to conversation

time64: Use consistent TIME defines

PATCH Superseded [email protected] 2 participants 2 messages Jan 20

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 time64: Use consistent TIME defines

From: Vyacheslav Yurkov <[email protected]>

Pipewire crashes when other dependent libraries are built with the different TIME and FILE_OFFSET defines. pw-v4l2/libcamera will most likely not work with 32-bits that have 64-bit time but that has to be fixed in the respective projects.

Related bug report:
https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/5055

---
 meta/conf/distro/include/time64.inc | 4 ----
 1 file changed, 4 deletions(-)
meta/conf/distro/include/time64.inc +0 -4
index 24a81c83f1..3ed0a4253d 100644
@@ -21,10 +21,6 @@ TARGET_CC_ARCH:append:x86 = "${@bb.utils.contains('TUNE_FEATURES', 'm32', '${GLI
 
 GLIBC_64BIT_TIME_FLAGS:pn-glibc = ""
 GLIBC_64BIT_TIME_FLAGS:pn-glibc-testsuite = ""
-# pipewire-v4l2 explicitly sets _FILE_OFFSET_BITS=32 to get access to
-# both 32 and 64 bit file APIs.  But it does not handle the time side?
-# Needs further investigation
-GLIBC_64BIT_TIME_FLAGS:pn-pipewire = ""
 # Undefines _FILE_OFFSET_BITS on purpose in
 # libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp
 GLIBC_64BIT_TIME_FLAGS:pn-gcc-sanitizers = ""
#1 lore raw

Hi

2026. 01. 20. 11:38 keltezéssel, [email protected] írta:

Quoted 4 lines

From: Vyacheslav Yurkov <[email protected]>

Pipewire crashes when other dependent libraries are built with the different TIME and FILE_OFFSET defines. pw-v4l2/libcamera will most

That is specifically about "libcameraify", which is a similar LD_PRELOAD library. I wouldn't mention it since this change does not affect the libcamera recipe.

Quoted 2 lines

likely not work with 32-bits that have 64-bit time but that has to be fixed in the respective projects.

As the removed comment correctly points out, __ioctl_time64, etc. is not handled in pw-v4l2. But I'm still not sure why the change was made originally in yocto since it won't make pw-v4l2 somehow work if an application uses __ioctl_time64.

In any case, the current situation is less than ideal, if pipewire and its dependencies (e.g. alsa-lib) disagree about the size of time_t, etc; as two people have already reported issues caused by this.

Regards,
Barnabás Pőcze

Quoted 25 lines

Related bug report:
https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/5055

---
  meta/conf/distro/include/time64.inc | 4 ----
  1 file changed, 4 deletions(-)
meta/conf/distro/include/time64.inc +0 -4
index 24a81c83f1..3ed0a4253d 100644
@@ -21,10 +21,6 @@ TARGET_CC_ARCH:append:x86 = "${@bb.utils.contains('TUNE_FEATURES', 'm32', '${GLI
 
  GLIBC_64BIT_TIME_FLAGS:pn-glibc = ""
  GLIBC_64BIT_TIME_FLAGS:pn-glibc-testsuite = ""
-# pipewire-v4l2 explicitly sets _FILE_OFFSET_BITS=32 to get access to
-# both 32 and 64 bit file APIs.  But it does not handle the time side?
-# Needs further investigation
-GLIBC_64BIT_TIME_FLAGS:pn-pipewire = ""
  # Undefines _FILE_OFFSET_BITS on purpose in
  # libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp
  GLIBC_64BIT_TIME_FLAGS:pn-gcc-sanitizers = ""