Skip to contentSkip to conversation

staging: most: dim2: replace macro with static function

PATCH In review Ethan Tidmore 2 participants 2 messages Jan 23

Subsystems (2)
Staging Most(r) technology driver
lore
Share & tools
lore

Ethan Tidmore

author
#0 lore raw

PATCH v2 1/1 staging: most: dim2: replace macro with static function

Replace unsafe macro with function to avoid side effects.

Signed-off-by Ethan Tidmore <[email protected]>

---
Changes in v2:
- Removed 'inline' keyword.
- Fix indentation alignment in return statement.

 drivers/staging/most/dim2/dim2.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
drivers/staging/most/dim2/dim2.c +7 -5
index dad2abe6c0c9..80af965356d0 100644
@@ -113,10 +113,12 @@ static inline struct dim2_hdm *iface_to_hdm(struct most_interface *iface)
 	return container_of(iface, struct dim2_hdm, most_iface);
 }
 
-/* Macro to identify a network status message */
-#define PACKET_IS_NET_INFO(p)  \
-	(((p)[1] == 0x18) && ((p)[2] == 0x05) && ((p)[3] == 0x0C) && \
-	 ((p)[13] == 0x3C) && ((p)[14] == 0x00) && ((p)[15] == 0x0A))
+/* Identify a network status message */
+static bool packet_is_net_info(const u8 *p)
+{
+	return p[1] == 0x18 && p[2] == 0x05 && p[3] == 0x0C &&
+	       p[13] == 0x3C && p[14] == 0x00 && p[15] == 0x0A;
+}
 
 static ssize_t state_show(struct device *dev, struct device_attribute *attr,
 			  char *buf)

@@ -304,7 +306,7 @@ static void service_done_flag(struct dim2_hdm *dev, int ch_idx)
 
 		if (hdm_ch->data_type == MOST_CH_ASYNC &&
 		    hdm_ch->direction == MOST_CH_RX &&
-		    PACKET_IS_NET_INFO(data)) {
+		    packet_is_net_info(data)) {
 			retrieve_netinfo(dev, mbo);
 
 			spin_lock_irqsave(&dim_lock, flags);
Signature · 1 line
2.52.0