Skip to contentSkip to conversation

net: usb: smsc95xx: use phy_do_ioctl_running function

PATCH Applied Ethan Nelson-Moore 3 participants 3 messages Jan 24 – Jan 27

Subsystems (5)
Networking Network drivers USB USB networking drivers +1 more subsystems
lore
Share & tools
lore

Ethan Nelson-Moore

author
#0 lore raw

PATCH 1/1 net: usb: smsc95xx: use phy_do_ioctl_running function

The smsc95xx_ioctl function behaves identically to the phy_do_ioctl_running function. Remove it and use the phy_do_ioctl_running function directly instead.

Signed-off-by Ethan Nelson-Moore <[email protected]>
---
 drivers/net/usb/smsc95xx.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)
drivers/net/usb/smsc95xx.c +1 -9
index de733e0488bf..c65402d850c9 100644
@@ -854,14 +854,6 @@ static const struct ethtool_ops smsc95xx_ethtool_ops = {
 	.set_pauseparam	= smsc95xx_set_pauseparam,
 };
 
-static int smsc95xx_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd)
-{
-	if (!netif_running(netdev))
-		return -EINVAL;
-
-	return phy_mii_ioctl(netdev->phydev, rq, cmd);
-}
-
 static void smsc95xx_init_mac_address(struct usbnet *dev)
 {
 	u8 addr[ETH_ALEN];

@@ -1139,7 +1131,7 @@ static const struct net_device_ops smsc95xx_netdev_ops = {
 	.ndo_get_stats64	= dev_get_tstats64,
 	.ndo_set_mac_address 	= eth_mac_addr,
 	.ndo_validate_addr	= eth_validate_addr,
-	.ndo_eth_ioctl		= smsc95xx_ioctl,
+	.ndo_eth_ioctl		= phy_do_ioctl_running,
 	.ndo_set_rx_mode	= smsc95xx_set_multicast,
 	.ndo_set_features	= smsc95xx_set_features,
 };
Signature · 1 line
2.43.0
CI Applied
#2 lore raw
In reply to Ethan Nelson-Moore
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Sat, 24 Jan 2026 00:07:51 -0800 you wrote:

The smsc95xx_ioctl function behaves identically to the phy_do_ioctl_running function. Remove it and use the phy_do_ioctl_running function directly instead.

Signed-off-by Ethan Nelson-Moore <[email protected]>
---
 drivers/net/usb/smsc95xx.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

Here is the summary with links:
- [net-next] net: usb: smsc95xx: use phy_do_ioctl_running function

    https://git.kernel.org/netdev/net-next/c/2dd698f68e3c

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html