Skip to contentSkip to conversation

mm-damon-lru_sort-add-monitoring-intervals-auto-tuning-parameter.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Jan 27

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm/damon/lru_sort: add monitoring intervals auto-tuning parameter
has been removed from the -mm tree. Its filename was
mm-damon-lru_sort-add-monitoring-intervals-auto-tuning-parameter.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: SeongJae Park <[email protected]>
Subject: mm/damon/lru_sort: add monitoring intervals auto-tuning parameter
Date: Tue, 13 Jan 2026 07:27:15 -0800

DAMON monitoring intervals tuning was crucial for every DAMON use case. Now there are a tuning guideline and an automated intervals tuning feature. DAMON_LRU_SORT is still using manual control of intervals. Add a module parameter for utilizing the auto-tuning feature with a suggested auto-tuning parameters.

Cc David Hildenbrand <[email protected]>
Cc Jonathan Corbet <[email protected]>
Cc Liam Howlett <[email protected]>
Cc Lorenzo Stoakes <[email protected]>
Cc Michal Hocko <[email protected]>
Cc Mike Rapoport <[email protected]>
Cc Suren Baghdasaryan <[email protected]>
Cc Vlastimil Babka <[email protected]>

---

 mm/damon/lru_sort.c |   30 +++++++++++++++++++++++++++---
 1 file changed, 27 insertions(+), 3 deletions(-)
mm/damon/lru_sort.c renamed from mm/damon/lru_sort.c~mm-damon-lru_sort-add-monitoring-intervals-auto-tuning-parameter +27 -3
@@ -56,6 +56,20 @@ static unsigned long active_mem_bp __rea
 module_param(active_mem_bp, ulong, 0600);
 
 /*
+ * Auto-tune monitoring intervals.
+ *
+ * If this parameter is set as ``Y``, DAMON_LRU_SORT automatically tunes
+ * DAMON's sampling and aggregation intervals.  The auto-tuning aims to capture
+ * meaningful amount of access events in each DAMON-snapshot, while keeping the
+ * sampling interval 5 milliseconds in minimum, and 10 seconds in maximum.
+ * Setting this as ``N`` disables the auto-tuning.
+ *
+ * Disabled by default.
+ */
+static bool autotune_monitoring_intervals __read_mostly;
+module_param(autotune_monitoring_intervals, bool, 0600);
+
+/*
  * Filter [non-]young pages accordingly for LRU [de]prioritizations.
  *
  * If this is set, check page level access (youngness) once again before each
@@ -268,6 +282,7 @@ static int damon_lru_sort_apply_paramete
 {
 	struct damon_ctx *param_ctx;
 	struct damon_target *param_target;
+	struct damon_attrs attrs;
 	struct damos *hot_scheme, *cold_scheme;
 	unsigned int hot_thres, cold_thres;
 	int err;
@@ -290,18 +305,27 @@ static int damon_lru_sort_apply_paramete
 		goto out;
 	}
 
-	err = damon_set_attrs(param_ctx, &damon_lru_sort_mon_attrs);
+	attrs = damon_lru_sort_mon_attrs;
+	if (autotune_monitoring_intervals) {
+		attrs.sample_interval = 5000;
+		attrs.aggr_interval = 100000;
+		attrs.intervals_goal.access_bp = 40;
+		attrs.intervals_goal.aggrs = 3;
+		attrs.intervals_goal.min_sample_us = 5000;
+		attrs.intervals_goal.max_sample_us = 10 * 1000 * 1000;
+	}
+	err = damon_set_attrs(param_ctx, &attrs);
 	if (err)
 		goto out;
 
 	err = -ENOMEM;
-	hot_thres = damon_max_nr_accesses(&damon_lru_sort_mon_attrs) *
+	hot_thres = damon_max_nr_accesses(&attrs) *
 		hot_thres_access_freq / 1000;
 	hot_scheme = damon_lru_sort_new_hot_scheme(hot_thres);
 	if (!hot_scheme)
 		goto out;
 
-	cold_thres = cold_min_age / damon_lru_sort_mon_attrs.aggr_interval;
+	cold_thres = cold_min_age / attrs.aggr_interval;
 	cold_scheme = damon_lru_sort_new_cold_scheme(cold_thres);
 	if (!cold_scheme) {
 		damon_destroy_scheme(hot_scheme);

_

Patches currently in -mm which might be from [email protected] are

selftests-damon-sysfs_memcg_path_leaksh-use-kmemleak.patch selftests-damon-wss_estimation-test-for-up-to-160-mib-working-set-size.patch selftests-damon-access_memory-add-repeat-mode.patch selftests-damon-wss_estimation-ensure-number-of-collected-wss.patch selftests-damon-wss_estimation-deduplicate-failed-samples-output.patch mm-damon-remove-damon_operations-cleanup.patch mm-damon-core-cleanup-targets-and-regions-at-once-on-kdamond-termination.patch mm-damon-core-cancel-damos_walk-before-damon_ctx-kdamond-reset.patch mm-damon-core-process-damon_call_control-requests-on-a-local-list.patch mm-damon-document-damon_call_control-dealloc_on_cancel-repeat-behavior.patch mm-damon-core-rename-damos_filter_out-to-damos_core_filter_out.patch mm-damon-rename-damon_min_region-to-damon_min_region_sz.patch mm-damon-rename-min_sz_region-of-damon_ctx-to-min_region_sz.patch docs-mm-damon-index-simplify-the-intro.patch docs-mm-damon-design-link-repology-instead-of-fedora-package.patch docs-mm-damon-design-document-damon-sample-modules.patch docs-mm-damon-design-add-reference-to-damon_stat-usage.patch docs-admin-guide-mm-damon-usage-introduce-damon-modules-at-the-beginning.patch docs-admin-guide-mm-damon-usage-update-stats-update-process-for-refresh_ms.patch docs-mm-damon-maintainer-profile-fix-wrong-maitnainers-section-name.patch docs-mm-damon-maintainer-profile-remove-damon-tests-perf-suggestion.patch maple_tree-start-using-maple-copy-node-for-destination-fix.patch