selftests/liveupdate: Cleanup kernel optio CONFIG_LIVEUPDATE_TEST
Subsystems (2)
PATCH 1/1 selftests/liveupdate: Cleanup kernel optio CONFIG_LIVEUPDATE_TEST
The kernel option CONFIG_LIVEUPDATE_TEST does not exist currently. Remove it.
No functional changes.
--- tools/testing/selftests/liveupdate/config | 1 - 1 file changed, 1 deletion(-)
tools/testing/selftests/liveupdate/config +0 -1
@@ -5,7 +5,6 @@ CONFIG_KEXEC_HANDOVER_ENABLE_DEFAULT=y CONFIG_KEXEC_HANDOVER_DEBUGFS=y CONFIG_KEXEC_HANDOVER_DEBUG=y CONFIG_LIVEUPDATE=y -CONFIG_LIVEUPDATE_TEST=y CONFIG_MEMFD_CREATE=y CONFIG_TMPFS=y CONFIG_SHMEM=y
Signature · 1 line
2.52.0
Quoted 2 lines · Zhu Yanjun
The kernel option
CONFIG_LIVEUPDATE_TESTdoes not exist currently. Remove it.
In kernel 6.19-rc7, this kernel option still exists in the file
tools/testing/selftests/liveupdate/config. Thus I send out this commit to remove it.
Zhu Yanjun
Quoted 20 lines
No functional changes.
Signed-off-by Zhu Yanjun <[email protected]>--- tools/testing/selftests/liveupdate/config | 1 - 1 file changed, 1 deletion(-)tools/testing/selftests/liveupdate/config +0
-1@@ -5,7 +5,6 @@ CONFIG_KEXEC_HANDOVER_ENABLE_DEFAULT=y CONFIG_KEXEC_HANDOVER_DEBUGFS=y CONFIG_KEXEC_HANDOVER_DEBUG=y CONFIG_LIVEUPDATE=y -CONFIG_LIVEUPDATE_TEST=y CONFIG_MEMFD_CREATE=y CONFIG_TMPFS=y CONFIG_SHMEM=y
Signature · 2 lines
Best Regards, Yanjun.Zhu
Pratyush Yadav
maintainerQuoted 8 lines · Zhu Yanjun
Quoted 2 lines · Zhu Yanjun
The kernel option
CONFIG_LIVEUPDATE_TESTdoes not exist currently. Remove it.In kernel 6.19-rc7, this kernel option still exists in the file
tools/testing/selftests/liveupdate/config. Thus I send out this commit to remove it.
Yes, but the patch to add the config is in mm-nonmm-unstable. I am not sure if this worth the churn of removing this and re-adding it when that patch lands later. Do you see a real problem with this?
Quoted 1 line
[...]
Signature · 2 lines
Regards, Pratyush Yadav
Quoted 5 lines · Pratyush Yadav
Quoted 3 lines · Zhu Yanjun
Quoted 2 lines · Zhu Yanjun
The kernel option
CONFIG_LIVEUPDATE_TESTdoes not exist currently. Remove it.
Quoted 7 lines
Quoted 4 lines
In kernel 6.19-rc7, this kernel option still exists in the file
tools/testing/selftests/liveupdate/config. Thus I send out this commit to remove it.Yes, but the patch to add the config is in mm-nonmm-unstable. I am not sure if this worth the churn of removing this and re-adding it when that patch lands later. Do you see a real problem with this?
Thanks for the feedback.
I understand that the patch adding this functionality is currently in mm-nonmm-unstable. My concern was primarily adhering to the documentation, which suggests keeping the kernel configs pruned of unused options to avoid confusion for those running selftests.
However, I see your point regarding the churn. If you prefer, we can wait until the mm-nonmm-unstable branch is merged into the mainline. Once that happens, if this option remains truly redundant or if the implementation changes, I can resubmit the cleanup then.
Does that sound like a reasonable compromise to you?
Best regards,
Yanjun.Zhu
Quoted 3 lines
[...]
Pratyush Yadav
maintainerQuoted 20 lines · Yanjun.Zhu
Quoted 5 lines · Pratyush Yadav
Quoted 3 lines · Zhu Yanjun
Quoted 2 lines · Zhu Yanjun
The kernel option
CONFIG_LIVEUPDATE_TESTdoes not exist currently. Remove it.Quoted 7 lines
Quoted 4 lines
In kernel 6.19-rc7, this kernel option still exists in the file
tools/testing/selftests/liveupdate/config. Thus I send out this commit to remove it.Yes, but the patch to add the config is in mm-nonmm-unstable. I am not sure if this worth the churn of removing this and re-adding it when that patch lands later. Do you see a real problem with this?
Thanks for the feedback.
I understand that the patch adding this functionality is currently in mm-nonmm-unstable. My concern was primarily adhering to the documentation, which suggests keeping the kernel configs pruned of unused options to avoid confusion for those running selftests.
Quoted 6 lines
However, I see your point regarding the churn. If you prefer, we can wait until the mm-nonmm-unstable branch is merged into the mainline. Once that happens, if this option remains truly redundant or if the implementation changes, I can resubmit the cleanup then.
Does that sound like a reasonable compromise to you?
Yes, sounds good. And even though I don't recommend taking this patch right now, the effort to keep things clean is much appreciated!
Signature · 2 lines
Regards, Pratyush Yadav