Skip to contentSkip to conversation

gpib: remove unnecessary module_init/exit functions

PATCH In review Ethan Nelson-Moore 1 participant 2 messages Jan 31 GPIB drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpib: remove unnecessary module_init/exit functions

Two GPIB drivers have unnecessary empty module_init and module_exit functions. Remove them. Note that if a module_init function exists, a module_exit function must also exist; otherwise, the module cannot be unloaded.

---
 drivers/gpib/nec7210/nec7210.c | 12 ------------
 drivers/gpib/tms9914/tms9914.c | 13 -------------
 2 files changed, 25 deletions(-)
drivers/gpib/nec7210/nec7210.c +0 -12
index bbf39367f5e4..f15d38dfa4cc 100644
@@ -1107,15 +1107,3 @@ void nec7210_locking_iomem_write_byte(struct nec7210_priv *priv, u8 data,
 	spin_unlock_irqrestore(&priv->register_page_lock, flags);
 }
 EXPORT_SYMBOL(nec7210_locking_iomem_write_byte);
-
-static int __init nec7210_init_module(void)
-{
-	return 0;
-}
-
-static void __exit nec7210_exit_module(void)
-{
-}
-
-module_init(nec7210_init_module);
-module_exit(nec7210_exit_module);
drivers/gpib/tms9914/tms9914.c +0 -13
index 72a11596a35e..1411297e6217 100644
@@ -899,16 +899,3 @@ void tms9914_iomem_write_byte(struct tms9914_priv *priv, u8 data, unsigned int r
 		udelay(1);
 }
 EXPORT_SYMBOL_GPL(tms9914_iomem_write_byte);
-
-static int __init tms9914_init_module(void)
-{
-	return 0;
-}
-
-static void __exit tms9914_exit_module(void)
-{
-}
-
-module_init(tms9914_init_module);
-module_exit(tms9914_exit_module);
-
Signature · 1 line
2.43.0
#1 lore raw
Quoted 4 lines · Ethan Nelson-Moore

Two GPIB drivers have unnecessary empty module_init and module_exit functions. Remove them. Note that if a module_init function exists, a module_exit function must also exist; otherwise, the module cannot be unloaded.

Sorry, I accidentally sent this again since it was still in my folder of patches to send. It's the same as the first patch.

Ethan