Skip to contentSkip to conversation

sound: wcd-mbhc-v2: remove unnecessary module_init/exit functions

PATCH In review Ethan Nelson-Moore 3 participants 4 messages Jan 31 – Feb 2

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sound: wcd-mbhc-v2: remove unnecessary module_init/exit functions

The wcd-mbhc-v2 driver has unnecessary empty module_init and module_exit functions. Remove them. Note that if a module_init function exists, a module_exit function must also exist; otherwise, the module cannot be unloaded.

---
 sound/soc/codecs/wcd-mbhc-v2.c | 12 ------------
 1 file changed, 12 deletions(-)
sound/soc/codecs/wcd-mbhc-v2.c +0 -12
index 26ebcdadeb7d..0c842aaa7eec 100644
@@ -1631,17 +1631,5 @@ void wcd_mbhc_deinit(struct wcd_mbhc *mbhc)
 }
 EXPORT_SYMBOL(wcd_mbhc_deinit);
 
-static int __init mbhc_init(void)
-{
-	return 0;
-}
-
-static void __exit mbhc_exit(void)
-{
-}
-
-module_init(mbhc_init);
-module_exit(mbhc_exit);
-
 MODULE_DESCRIPTION("wcd MBHC v2 module");
 MODULE_LICENSE("GPL");
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Ethan Nelson-Moore

The wcd-mbhc-v2 driver has unnecessary empty module_init and module_exit functions. Remove them. Note that if a module_init function exists, a module_exit function must also exist; otherwise, the module cannot be unloaded.

---
 sound/soc/codecs/wcd-mbhc-v2.c | 12 ------------
 1 file changed, 12 deletions(-)
Quoted 1 line
Signature · 2 lines
With best wishes
Dmitry
maintainer
#2 lore raw
In reply to Ethan Nelson-Moore
Quoted 4 lines · Ethan Nelson-Moore

The wcd-mbhc-v2 driver has unnecessary empty module_init and module_exit functions. Remove them. Note that if a module_init function exists, a module_exit function must also exist; otherwise, the module cannot be unloaded.

Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.

maintainer
#3 lore raw
In reply to Ethan Nelson-Moore
Quoted 6 lines · Ethan Nelson-Moore

The wcd-mbhc-v2 driver has unnecessary empty module_init and module_exit functions. Remove them. Note that if a module_init function exists, a module_exit function must also exist; otherwise, the module cannot be unloaded.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] sound: wcd-mbhc-v2: remove unnecessary module_init/exit functions

      commit: 090c8844e5d454a898183ec4a7be8a75681ed262

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark