mux: core: fix reference count leak in mux_chip_register()
PATCH 1/1 mux: core: fix reference count leak in mux_chip_register()
Once mux_chip_alloc() is called, the underlying struct device is initialized via device_initialize(), and its reference count is set to 1. Any error path occurring after this point must call put_device() to ensure proper cleanup of the device and its associated resources.
Currently, if mux_control_set() fails or if device_add() fails, the function returns an error code directly. This leaves the mux_chip structure and its internal device's memory leaking, as the release callback is never triggered.
Fix this by ensuring that put_device() is called on all error paths within mux_chip_register().
--- drivers/mux/core.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/mux/core.c +7 -2
@@ -173,14 +173,19 @@ int mux_chip_register(struct mux_chip *mux_chip) ret =mux_control_set (mux, mux->idle_state);if (ret <0 ) {dev_err (&mux_chip->dev,"unable to set idle state\n" ); -return ret; + goto err_put_device; } } ret =device_add (&mux_chip->dev); -if (ret <0 ) +if (ret <0 ) {dev_err (&mux_chip->dev,"device_add failed in %s: %d\n" , __func__, ret); + goto err_put_device; + } + +err_put_device: +put_device (&mux_chip->dev);return ret; }EXPORT_SYMBOL_GPL (mux_chip_register);
Signature · 1 line
2.43.0
Hi!
Quoted 4 lines · Salah Triki
Once
mux_chip_alloc()is called, the underlyingstruct deviceis initialized viadevice_initialize(), and its reference count is set to 1. Any error path occurring after this point must callput_device()to ensure proper cleanup of the device and its associated resources.
This patch is broken. NACK.
The put_device() call that you seem to think is missing is found in the mux_chip_free() function, which is what should be called to clean up after (a successful) mux_chip_alloc().
If there really is a leak somewhere, the real problem is a missing call to mux_chip_free(), not a missing put_device() in mux_chip_register(). Adding a put_device() in mux_chip_register() leads to too many calls to put_device().
Cheers,
Peter
Quoted 9 lines · Peter Rosin
Hi!
This patch is broken. NACK.
The
put_device()call that you seem to think is missing is found in themux_chip_free()function, which is what should be called to clean up after (a successful)mux_chip_alloc().
Quoted 7 lines
If there really is a leak somewhere, the real problem is a missing call to
mux_chip_free(), not a missingput_device()inmux_chip_register(). Adding aput_device()inmux_chip_register()leads to too many calls toput_device().Cheers,
Peter
Thanks for the clarification, that makes sense. I'll drop this patch.
Best regards,
Salah