Skip to contentSkip to conversation

crypto: testmgr - Add test vectors for authenc(hmac(md5),cbc(des3_ede))

PATCH In review Aleksander Jan Bajkowski 2 participants 5 messages Feb 1 – Feb 7

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: testmgr - Add test vectors for authenc(hmac(md5),cbc(des3_ede))

Test vector was generated using a software implementation and then double checked using a hardware implementation on NXP P2020 (talitos). The encryption part is identical to authenc(hmac(sha1),cbc(des3_ede)), only HMAC is different.

---
 crypto/testmgr.c |  7 ++++++
 crypto/testmgr.h | 59 ++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 66 insertions(+)
crypto/testmgr.c +7 -0
index f3e068382073..0fef46c35367 100644
@@ -4086,6 +4086,13 @@ static const struct alg_test_desc alg_test_descs[] = {
 		.suite = {
 			.aead = __VECS(hmac_md5_aes_cbc_tv_temp)
 		}
+	}, {
+		.alg = "authenc(hmac(md5),cbc(des3_ede))",
+		.generic_driver = "authenc(hmac-md5-lib,cbc(des3_ede-generic))",
+		.test = alg_test_aead,
+		.suite = {
+			.aead = __VECS(hmac_md5_des3_ede_cbc_tv_temp)
+		}
 	}, {
 		.alg = "authenc(hmac(md5),ecb(cipher_null))",
 		.generic_driver = "authenc(hmac-md5-lib,ecb-cipher_null)",
crypto/testmgr.h +59 -0

65 lines not on this page · raw message

Signature · 1 line
2.47.3
maintainer
#1 lore raw
Quoted 10 lines · Aleksander Jan Bajkowski

Test vector was generated using a software implementation and then double checked using a hardware implementation on NXP P2020 (talitos). The encryption part is identical to authenc(hmac(sha1),cbc(des3_ede)), only HMAC is different.

---
 crypto/testmgr.c |  7 ++++++
 crypto/testmgr.h | 59 ++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 66 insertions(+)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#2 lore raw

Hi Herbert,

Quoted 6 lines · Herbert Xu
Quoted 5 lines · Aleksander Jan Bajkowski

Test vector was generated using a software implementation and then double checked using a hardware implementation on NXP P2020 (talitos). The encryption part is identical to authenc(hmac(sha1),cbc(des3_ede)), only HMAC is different.

Quoted 6 lines
Quoted 5 lines
---
  crypto/testmgr.c |  7 ++++++
  crypto/testmgr.h | 59 ++++++++++++++++++++++++++++++++++++++++++++++++
  2 files changed, 66 insertions(+)

Patch applied. Thanks.

While resolving the conflict, the entry was added in the wrong place. As a
result, the test manager complains about sorting:
[    0.050891] testmgr: alg_test_descs entries in wrong order: 'authenc(hmac(md5),ecb(cipher_null))' before 'authenc(hmac(md5),cbc(des3_ede))'

Should I send a patch to fix the sorting? Or would you prefer to replace the patch in your tree and apply [1] first, then [2]? That way there should be no conflicts.

1. https://patchwork.kernel.org/project/linux-crypto/patch/[email protected]/
2. https://patchwork.kernel.org/project/linux-crypto/patch/[email protected]/

Best regards,
Aleksander

maintainer
#3 lore raw
Quoted 6 lines · Aleksander Jan Bajkowski

While resolving the conflict, the entry was added in the wrong place. As a result, the test manager complains about sorting:
[    0.050891] testmgr: alg_test_descs entries in wrong order:
'authenc(hmac(md5),ecb(cipher_null))' before 'authenc(hmac(md5),cbc(des3_ede))'

Thanks for the heads up. I've just pushed out a fix, can you please double-check?

Cheers,

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#4 lore raw
Quoted 8 lines · Herbert Xu
Quoted 5 lines · Aleksander Jan Bajkowski

While resolving the conflict, the entry was added in the wrong place. As a result, the test manager complains about sorting:
[    0.050891] testmgr: alg_test_descs entries in wrong order:
'authenc(hmac(md5),ecb(cipher_null))' before 'authenc(hmac(md5),cbc(des3_ede))'

Thanks for the heads up. I've just pushed out a fix, can you please double-check?

It's fine now. Thanks.

Quoted 2 lines

Cheers,