staging: media: atomisp: remove functions doing ftrace like logging
Subsystems (4)
PATCH 1/1 staging: media: atomisp: remove functions doing ftrace like logging
Remove ia_css_debug_dtrace() calls which only log function entry. ftrace should be used instead.
Signed-off-by Adarsh Das <[email protected]>
--- .../media/atomisp/pci/ia_css_isp_configs.c | 26 ------------------- 1 file changed, 26 deletions(-)
drivers/staging/media/atomisp/pci/ia_css_isp_configs.c +0 -26
@@ -18,8 +18,6 @@ int ia_css_configure_iterator(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;
@@ -41,8 +39,6 @@ int ia_css_configure_copy_output(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;
@@ -66,8 +62,6 @@ int ia_css_configure_crop(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;
@@ -89,8 +83,6 @@ int ia_css_configure_fpn(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;
@@ -111,8 +103,6 @@ int ia_css_configure_dvs(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;
@@ -133,8 +123,6 @@ int ia_css_configure_qplane(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;
@@ -156,8 +144,6 @@ int ia_css_configure_output0(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;
@@ -179,8 +165,6 @@ int ia_css_configure_output1(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;
@@ -202,8 +186,6 @@ int ia_css_configure_output(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;
@@ -225,8 +207,6 @@ int ia_css_configure_raw(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;
@@ -248,8 +228,6 @@ int ia_css_configure_tnr(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;
@@ -271,8 +249,6 @@ int ia_css_configure_ref(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;
@@ -294,8 +270,6 @@ int ia_css_configure_vf(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;
Signature · 1 line
2.52.0
Quoted 3 lines · Adarsh Das
Remove
ia_css_debug_dtrace()calls which only log function entry. ftrace should be used instead.
LGTM,
Reviewed-by Andy Shevchenko <[email protected]>
Signature · 2 lines
With Best Regards, Andy Shevchenko
Hi,
Quoted 4 lines · Adarsh Das
Remove
ia_css_debug_dtrace()calls which only log function entry. ftrace should be used instead.Signed-off-by Adarsh Das <[email protected]>
Thanks, patch looks good to me:
Reviewed-by Hans de Goede <[email protected]>
Regards,
Hans
Quoted 125 lines
--- .../media/atomisp/pci/ia_css_isp_configs.c | 26 ------------------- 1 file changed, 26 deletions(-)drivers/staging/media/atomisp/pci/ia_css_isp_configs.c +0
-26@@ -18,8 +18,6 @@ int ia_css_configure_iterator(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;@@ -41,8 +39,6 @@ int ia_css_configure_copy_output(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;@@ -66,8 +62,6 @@ int ia_css_configure_crop(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;@@ -89,8 +83,6 @@ int ia_css_configure_fpn(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;@@ -111,8 +103,6 @@ int ia_css_configure_dvs(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;@@ -133,8 +123,6 @@ int ia_css_configure_qplane(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;@@ -156,8 +144,6 @@ int ia_css_configure_output0(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;@@ -179,8 +165,6 @@ int ia_css_configure_output1(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;@@ -202,8 +186,6 @@ int ia_css_configure_output(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;@@ -225,8 +207,6 @@ int ia_css_configure_raw(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;@@ -248,8 +228,6 @@ int ia_css_configure_tnr(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;@@ -271,8 +249,6 @@ int ia_css_configure_ref(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;@@ -294,8 +270,6 @@ int ia_css_configure_vf(const struct ia_css_binary *binary,unsigned int offset =0 ;unsigned int size =0 ; -ia_css_debug_dtrace (IA_CSS_DEBUG_TRACE_PRIVATE ,"%s:\n" , __func__); -if (!binary->info->mem_offsets.offsets.config)return 0 ;