tools/power/acpi: Replace unsafe strcat with strncat in apfiles.c
Subsystems (2)
PATCH 1/1 tools/power/acpi: Replace unsafe strcat with strncat in apfiles.c
Replace unsafe strcat() calls with strncat() in apfiles.c to prevent potential buffer overflow vulnerabilities when constructing filenames. The strncat() function performs bounds checking to ensure the destination buffer is not overflowed.
No functional change.
Signed-off-by Sumeet Pawnikar <[email protected]>
--- tools/power/acpi/tools/acpidump/apfiles.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
tools/power/acpi/tools/acpidump/apfiles.c +4 -2
@@ -131,10 +131,12 @@ int ap_write_to_binary_file(struct acpi_table_header *table, u32 instance)if (instance >0 ) {snprintf (instance_str,sizeof (instance_str),"%u" , instance); -strcat (filename, instance_str); +strncat (filename, instance_str, +sizeof (filename) -strlen (filename) -1 ); } -strcat (filename,FILE_SUFFIX_BINARY_TABLE ); +strncat (filename,FILE_SUFFIX_BINARY_TABLE , +sizeof (filename) -strlen (filename) -1 );if (gbl_verbose_mode) { fprintf(stderr,
Signature · 1 line
2.43.0