Skip to contentSkip to conversation

phy: renesas: rcar-gen3-usb2: add regulator dependency

PATCH Applied Arnd Bergmann 3 participants 3 messages Feb 2 – Feb 4 Generic PHY framework

lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 phy: renesas: rcar-gen3-usb2: add regulator dependency

From: Arnd Bergmann <[email protected]>

The driver start registering a regulator, but can still be enabled even when it is unable to call into the regulator subsystem:

aarch64-linux-ld: drivers/phy/renesas/phy-rcar-gen3-usb2.o: in function `rcar_gen3_phy_usb2_probe':
phy-rcar-gen3-usb2.c:(.text+0x2884): undefined reference to `devm_regulator_register'

Add a Kconfig dependency to avoid this configuration.

Fixes b6d7dd157763 ("phy: renesas: rcar-gen3-usb2: Add regulator for OTG VBUS control")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/phy/renesas/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/phy/renesas/Kconfig +1 -0
index d217c630b2fd..90a9ca2db7fc 100644
@@ -29,6 +29,7 @@ config PHY_RCAR_GEN3_USB2
 	depends on ARCH_RENESAS
 	depends on EXTCON || !EXTCON # if EXTCON=m, this cannot be built-in
 	depends on USB_SUPPORT
+	depends on REGULATOR
 	select GENERIC_PHY
 	select MULTIPLEXER
 	select USB_COMMON
Signature · 1 line
2.39.5
Tested-by on v1 1/1
#1 lore raw
Quoted 6 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The driver start registering a regulator, but can still be enabled even when it is unable to call into the regulator subsystem:

Quoted 6 lines

aarch64-linux-ld: drivers/phy/renesas/phy-rcar-gen3-usb2.o: in function `rcar_gen3_phy_usb2_probe':
phy-rcar-gen3-usb2.c:(.text+0x2884): undefined reference to `devm_regulator_register'

Add a Kconfig dependency to avoid this configuration.

Fixes b6d7dd157763 ("phy: renesas: rcar-gen3-usb2: Add regulator for OTG VBUS control")
Tested-by Tommaso Merciai <[email protected]>
Quoted 20 lines
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/phy/renesas/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/phy/renesas/Kconfig +1 -0
index d217c630b2fd..90a9ca2db7fc 100644
@@ -29,6 +29,7 @@ config PHY_RCAR_GEN3_USB2
 	depends on ARCH_RENESAS
 	depends on EXTCON || !EXTCON # if EXTCON=m, this cannot be built-in
 	depends on USB_SUPPORT
+	depends on REGULATOR
 	select GENERIC_PHY
 	select MULTIPLEXER
 	select USB_COMMON
Signature · 1 line
2.39.5

Thanks & Regards,
Tommaso

maintainer Applied
#2 lore raw
In reply to Arnd Bergmann
Quoted 8 lines · Arnd Bergmann

The driver start registering a regulator, but can still be enabled even when it is unable to call into the regulator subsystem:

aarch64-linux-ld: drivers/phy/renesas/phy-rcar-gen3-usb2.o: in function `rcar_gen3_phy_usb2_probe':
phy-rcar-gen3-usb2.c:(.text+0x2884): undefined reference to `devm_regulator_register'

[...]

Applied, thanks!

[1/1] phy: renesas: rcar-gen3-usb2: add regulator dependency

      commit: 3a03a0e47cf2e0ec7ce7ca9e0bf4c59ec537ad09

Best regards,

Signature · 1 line
~Vinod