Skip to contentSkip to conversation

staging: greybus: added comment to mutex declaration in fw-management.c

PATCH In review Rachit Dhar 2 participants 5 messages Feb 3 – Feb 4 4 messages not in the archive

Subsystems (4)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH v2 1/4 staging: greybus: added comment to mutex declaration in fw-management.c

---------- Forwarded message ---------
From: Rachit Dhar <[email protected]>
Date: Tue, Feb 3, 2026 at 6:02 PM
Subject: [PATCH v2 1/4] staging: greybus: added comment to mutex declaration in fw-management.c
To:
Cc: Rachit Dhar <[email protected]>, Viresh Kumar <[email protected]>, Johan Hovold <[email protected]>, Alex Elder <[email protected]>, Greg Kroah-Hartman <[email protected]>

Added comment to mutex declaration, to resolve a checkpatch.pl check.

---
 drivers/staging/greybus/fw-management.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/staging/greybus/fw-management.c
index 152949c23d65..07a0e6b63cf3 100644

drivers/staging/greybus/fw-management.c +1 -1
@@ -28,7 +28,7 @@ struct fw_mgmt {
 
        /* Common id-map for interface and backend firmware requests */
        struct ida              id_map;
-       struct mutex            mutex;
+       struct mutex            mutex; /* protects fw_mgmt->disabled,

and serializes ioctl */

        struct completion       completion;
        struct cdev             cdev;
        struct device           *class_device;

--
2.43.0

#2 lore raw

These forwarded patches are corrupted and can't be applied.

regards,
dan carpenter

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw

PATCH v2 2/4 staging: greybus: fixed styling issue in fw-management.c

---------- Forwarded message ---------
From: Rachit Dhar <[email protected]>
Date: Tue, Feb 3, 2026 at 6:02 PM
Subject: [PATCH v2 2/4] staging: greybus: fixed styling issue in fw-management.c To:
Cc: Rachit Dhar <[email protected]>, Viresh Kumar <[email protected]>, Johan Hovold <[email protected]>, Alex Elder <[email protected]>, Greg Kroah-Hartman <[email protected]>

Fixed a styling issue highlighted by checkpatch.pl.

---
 drivers/staging/greybus/fw-management.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/staging/greybus/fw-management.c
index 07a0e6b63cf3..cf917ddb79c4 100644

drivers/staging/greybus/fw-management.c +0 -0
@@ -434,7 +434,8 @@ static int fw_mgmt_ioctl(struct fw_mgmt *fw_mgmt,

unsigned int cmd,
return -EFAULT;

ret = fw_mgmt_load_and_validate_operation(fw_mgmt,
- intf_load.load_method, intf_load.firmware_tag);
+ intf_load.load_method,
+

intf_load.firmware_tag);
                if (ret)
                        return ret;

--
2.43.0

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw

PATCH v2 3/4 staging: greybus: resolved checkpatch checks for raw.c

---------- Forwarded message ---------
From: Rachit Dhar <[email protected]>
Date: Tue, Feb 3, 2026 at 6:02 PM
Subject: [PATCH v2 3/4] staging: greybus: resolved checkpatch checks for raw.c To:
Cc: Rachit Dhar <[email protected]>, Johan Hovold <[email protected]>, Alex Elder <[email protected]>, Greg Kroah-Hartman <[email protected]>

Added comment to mutex declaration, to resolve checkpatch.pl check.

---
 drivers/staging/greybus/raw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/greybus/raw.c +1 -1
index 71de6776739c..4f217f20f1c0 100644
@@ -20,7 +20,7 @@ struct gb_raw {
 
        struct list_head list;
        int list_data;
-       struct mutex list_lock;
+       struct mutex list_lock; /* protects gb_raw->list and

gb_raw->list_data */

        dev_t dev;
        struct cdev cdev;
        struct device *device;

--
2.43.0

A message that is not in the archive (sent off-list or not yet received): [email protected]

#8 lore raw

PATCH v2 4/4 staging: greybus: resolved checkpatch checks for light.c

---------- Forwarded message ---------
From: Rachit Dhar <[email protected]>
Date: Tue, Feb 3, 2026 at 6:03 PM
Subject: [PATCH v2 4/4] staging: greybus: resolved checkpatch checks for light.c To:
Cc: Rachit Dhar <[email protected]>, Rui Miguel Silva <[email protected]>, Johan Hovold <[email protected]>, Alex Elder <[email protected]>, Greg Kroah-Hartman <[email protected]>

Added comment to mutex declarations, to resolve checkpatch.pl checks.

---
 drivers/staging/greybus/light.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/greybus/light.c +2 -2
index e509fdc715db..1f2faa6d545d 100644
@@ -37,7 +37,7 @@ struct gb_channel {
        bool                            releasing;
        bool                            strobe_state;
        bool                            active;
-       struct mutex                    lock;
+       struct mutex                    lock; /* protects gb_channel->active */
 };
 
 struct gb_light {
@@ -59,7 +59,7 @@ struct gb_lights {
        struct gb_connection    *connection;
        u8                      lights_count;
        struct gb_light         *lights;
-       struct mutex            lights_lock;
+       struct mutex            lights_lock; /* protects gb_lights->lights */
 };
 
 static void gb_lights_channel_free(struct gb_channel *channel);

--
2.43.0