Skip to contentSkip to conversation

staging: greybus: fixed styling issue in fw-management.c

PATCH Superseded Rachit Dhar 2 participants 4 messages Feb 4 – Feb 23

Subsystems (3)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 2/4 staging: greybus: fixed styling issue in fw-management.c

Fixed a styling issue highlighted by checkpatch.pl.

---
 drivers/staging/greybus/fw-management.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/greybus/fw-management.c +2 -1
index 07a0e6b63cf3..cf917ddb79c4 100644
@@ -434,7 +434,8 @@ static int fw_mgmt_ioctl(struct fw_mgmt *fw_mgmt, unsigned int cmd,
 			return -EFAULT;
 
 		ret = fw_mgmt_load_and_validate_operation(fw_mgmt,
-				intf_load.load_method, intf_load.firmware_tag);
+							  intf_load.load_method,
+							  intf_load.firmware_tag);
 		if (ret)
 			return ret;
 
Signature · 1 line
2.43.0
#1 lore raw
Quoted 1 line · Rachit Dhar

Fixed a styling issue highlighted by checkpatch.pl.

What specific style issue was fixed? Please be specific.

Also, your patches were not correctly linked together. Please use something like 'git send-email' to send them all at once. Otherwise they get lost and out-of-order as you can see in the email archives on lore.kernel.org.

thanks,

greg k-h

#2 lore raw
Quoted 7 lines · Greg Kroah-Hartman

What specific style issue was fixed? Please be specific.

Also, your patches were not correctly linked together. Please use something like 'git send-email' to send them all at once. Otherwise they get lost and out-of-order as you can see in the email archives on lore.kernel.org.

The style issue fixed was for the following checkpatch check:

CHECK: Alignment should match open parenthesis #437: FILE: drivers/staging/greybus/fw-management.c:437:
+ ret = fw_mgmt_load_and_validate_operation(fw_mgmt,
+ intf_load.load_method, intf_load.firmware_tag);

Thanks for pointing out the issue of out-of-order patches. I did use git send-email, but did so for each patch separately, which might have led to this. If I should send another patch series to correct this, please let me know.

Thanks,
Rachit

#3 lore raw
Quoted 17 lines · Rachit Dhar
Quoted 7 lines · Greg Kroah-Hartman

What specific style issue was fixed? Please be specific.

Also, your patches were not correctly linked together. Please use something like 'git send-email' to send them all at once. Otherwise they get lost and out-of-order as you can see in the email archives on lore.kernel.org.

The style issue fixed was for the following checkpatch check:

CHECK: Alignment should match open parenthesis #437: FILE: drivers/staging/greybus/fw-management.c:437:

(quoted diff) +2 -0
+               ret = fw_mgmt_load_and_validate_operation(fw_mgmt,
+                               intf_load.load_method, intf_load.firmware_tag);
Quoted 4 lines

Thanks for pointing out the issue of out-of-order patches. I did use git send-email, but did so for each patch separately, which might have led to this. If I should send another patch series to correct this, please let me know.

I can't take these as-is, so yes, please rebase and resend the remaining ones.

thanks,

greg k-h