Skip to contentSkip to conversation

mm/slub: zero-initialize slab object extensions to fix KMSAN

PATCH In review Osama Abdelkader 2 participants 2 messages Feb 4

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/slub: zero-initialize slab object extensions to fix KMSAN

KMSAN reports uninitialized reads in __memcg_slab_free_hook when freeing sigqueue objects. Although kmalloc_nolock(__GFP_ZERO) and kcalloc_node normally zero memory, some allocation paths (fallbacks, early boot, reused slabs, or races) may leave objcg undefined.

Explicitly memset the obj_exts array after allocation to guarantee no uninitialized reads in __memcg_slab_free_hook and preserve correct memcg accounting.

---
 mm/slub.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
mm/slub.c +11 -1
index f77b7407c51b..e66d17ee7fa8 100644
@@ -2123,7 +2123,17 @@ int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s,
 		vec = kcalloc_node(objects, sizeof(struct slabobj_ext), gfp,
 				   slab_nid(slab));
 	}
-	if (!vec) {
+	/*
+	 * Explicitly zero the obj_exts array to ensure KMSAN recognizes it
+	 * as initialized. Although kmalloc_nolock and kcalloc_node normally
+	 * zero memory, KMSAN may not track this initialization in all cases,
+	 * especially during early boot or with certain allocation paths.
+	 * This explicit memset ensures KMSAN sees the initialization and
+	 * prevents uninitialized value warnings when accessing objcg fields.
+	 */
+	if (vec)
+		memset(vec, 0, objects * sizeof(*vec));
+	else {
 		/*
 		 * Try to mark vectors which failed to allocate.
 		 * If this operation fails, there may be a racing process
Signature · 1 line
2.43.0
#1 lore raw
Quoted 23 lines · Osama Abdelkader

KMSAN reports uninitialized reads in __memcg_slab_free_hook when freeing sigqueue objects. Although kmalloc_nolock(__GFP_ZERO) and kcalloc_node normally zero memory, some allocation paths (fallbacks, early boot, reused slabs, or races) may leave objcg undefined.

Explicitly memset the obj_exts array after allocation to guarantee no uninitialized reads in __memcg_slab_free_hook and preserve correct memcg accounting.

---
 mm/slub.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
mm/slub.c +0 -0
index f77b7407c51b..e66d17ee7fa8 100644
@@ -2123,7 +2123,17 @@ int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s,
 		vec = kcalloc_node(objects, sizeof(struct slabobj_ext), gfp,
 				   slab_nid(slab));

mm/slub.c int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, · line 2133

Quoted 10 lines
mm/slub.c +8 -1
 	}
-	if (!vec) {
+	/*
+	 * Explicitly zero the obj_exts array to ensure KMSAN recognizes it
+	 * as initialized. Although kmalloc_nolock and kcalloc_node normally
+	 * zero memory, KMSAN may not track this initialization in all cases,
+	 * especially during early boot or with certain allocation paths.
+	 * This explicit memset ensures KMSAN sees the initialization and
+	 * prevents uninitialized value warnings when accessing objcg fields.
+	 */

This explanation makes no sense to me. The kcalloc or kmalloc with __GFP_ZERO above has just cleared the object, and this is just clearing it again. It didn't happen sometimes in the past where KMSAN wouldn't track this.

The bug must have a different explanation, such as getting an invalid pointer to kmem_cache_free(). Too bad it doesn't report any details about the address.

Quoted 6 lines
mm/slub.c +3 -0
+	if (vec)
+		memset(vec, 0, objects * sizeof(*vec));
+	else {
 		/*
 		 * Try to mark vectors which failed to allocate.
 		 * If this operation fails, there may be a racing process