Skip to contentSkip to conversation

media: iris: fix QCOM_MDT_LOADER dependency

PATCH In review Arnd Bergmann 4 participants 4 messages Feb 5 – Mar 2

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: iris: fix QCOM_MDT_LOADER dependency

From: Arnd Bergmann <[email protected]>

When build-testined with CONFIG_QCOM_MDT_LOADER=m and VIDEO_QCOM_IRIS=y, the kernel fails to link:

x86_64-linux-ld: drivers/media/platform/qcom/iris/iris_firmware.o: in function `iris_fw_load':
iris_firmware.c:(.text+0xb0): undefined reference to qcom_mdt_get_size' iris_firmware.c:(.text+0xfd): undefined reference to qcom_mdt_load'

The problem is the conditional 'select' statement. Change this to make the driver built-in here regardless of CONFIG_ARCH_QCOM.

---
 drivers/media/platform/qcom/iris/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/qcom/iris/Kconfig +1 -1
index 3c803a05305a..5498f48362d1 100644
@@ -3,7 +3,7 @@ config VIDEO_QCOM_IRIS
         depends on VIDEO_DEV
         depends on ARCH_QCOM || COMPILE_TEST
         select V4L2_MEM2MEM_DEV
-        select QCOM_MDT_LOADER if ARCH_QCOM
+        select QCOM_MDT_LOADER
         select QCOM_SCM
         select VIDEOBUF2_DMA_CONTIG
         help
Signature · 1 line
2.39.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

When build-testined with CONFIG_QCOM_MDT_LOADER=m and VIDEO_QCOM_IRIS=y, the kernel fails to link:

x86_64-linux-ld: drivers/media/platform/qcom/iris/iris_firmware.o: in function `iris_fw_load':
iris_firmware.c:(.text+0xb0): undefined reference to qcom_mdt_get_size' iris_firmware.c:(.text+0xfd): undefined reference to qcom_mdt_load'

Quoted 5 lines

The problem is the conditional 'select' statement. Change this to make the driver built-in here regardless of CONFIG_ARCH_QCOM.

---

I see that drm/msm (+Rob) does that too, but perhaps for a reason (old I.MX platforms with Adreno)

Konrad

Reviewed-by on v1 1/1
#2 lore raw
In reply to Arnd Bergmann
Quoted 31 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

When build-testined with CONFIG_QCOM_MDT_LOADER=m and VIDEO_QCOM_IRIS=y, the kernel fails to link:

x86_64-linux-ld: drivers/media/platform/qcom/iris/iris_firmware.o: in function `iris_fw_load':
iris_firmware.c:(.text+0xb0): undefined reference to qcom_mdt_get_size' iris_firmware.c:(.text+0xfd): undefined reference to qcom_mdt_load'

The problem is the conditional 'select' statement. Change this to make the driver built-in here regardless of CONFIG_ARCH_QCOM.

---
  drivers/media/platform/qcom/iris/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/qcom/iris/Kconfig +1 -2
index 3c803a05305a..5498f48362d1 100644
@@ -3,7 +3,7 @@ config VIDEO_QCOM_IRIS
          depends on VIDEO_DEV
          depends on ARCH_QCOM || COMPILE_TEST
          select V4L2_MEM2MEM_DEV
-        select QCOM_MDT_LOADER if ARCH_QCOM
+        select QCOM_MDT_LOADER
          select QCOM_SCM
          select VIDEOBUF2_DMA_CONTIG
          help
--
Quoted 2 lines

2.39.5

maintainer Reviewed-by on v1 1/1
#3 lore raw
In reply to Arnd Bergmann
Quoted 22 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

When build-testined with CONFIG_QCOM_MDT_LOADER=m and VIDEO_QCOM_IRIS=y, the kernel fails to link:

x86_64-linux-ld: drivers/media/platform/qcom/iris/iris_firmware.o: in function `iris_fw_load':
iris_firmware.c:(.text+0xb0): undefined reference to qcom_mdt_get_size' iris_firmware.c:(.text+0xfd): undefined reference to qcom_mdt_load'

The problem is the conditional 'select' statement. Change this to make the driver built-in here regardless of CONFIG_ARCH_QCOM.

---
 drivers/media/platform/qcom/iris/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/qcom/iris/Kconfig +0 -0
index 3c803a05305a..5498f48362d1 100644

drivers/media/platform/qcom/iris/Kconfig config VIDEO_QCOM_IRIS · line 9

Quoted 8 lines
drivers/media/platform/qcom/iris/Kconfig +1 -1
@@ -3,7 +3,7 @@ config VIDEO_QCOM_IRIS
         depends on VIDEO_DEV
         depends on ARCH_QCOM || COMPILE_TEST
         select V4L2_MEM2MEM_DEV
-        select QCOM_MDT_LOADER if ARCH_QCOM
+        select QCOM_MDT_LOADER
         select QCOM_SCM
         select VIDEOBUF2_DMA_CONTIG
         help

Thanks,
Dikshita