KVM: arm64: vgic: Handle const qualifier from clusters allocation type
PATCH 1/1 KVM: arm64: vgic: Handle const qualifier from clusters allocation type
In preparation for making the kmalloc family of allocators type aware, we need to make sure that the returned type from the allocation matches the type of the variable being assigned. (Before, the allocator would always return "void *", which can be implicitly cast to any pointer type.)
The assigned type is "struct gic_kvm_info", but the returned type, while matching, is const qualified. To get them exactly matching, just use the dereferenced pointer for the sizeof().
---
Cc: Marc Zyngier <[email protected]>
Cc: Oliver Upton <[email protected]>
Cc: Joey Gouly <[email protected]>
Cc: Suzuki K Poulose <[email protected]>
Cc: Zenghui Yu <[email protected]>
Cc: Catalin Marinas <[email protected]>
Cc: Will Deacon <[email protected]>
Cc: Alexander Potapenko <[email protected]>
Cc: <[email protected]>
Cc: <[email protected]>
--- arch/arm64/kvm/vgic/vgic-init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/kvm/vgic/vgic-init.c +1 -1
@@ -654,7 +654,7 @@ static struct gic_kvm_info *gic_kvm_info;void __init vgic_set_kvm_info (const struct gic_kvm_info *info) {BUG_ON (gic_kvm_info !=NULL ); - gic_kvm_info =kmalloc (sizeof (*info),GFP_KERNEL ); + gic_kvm_info =kmalloc (sizeof (*gic_kvm_info),GFP_KERNEL );if (gic_kvm_info) *gic_kvm_info = *info; }
Signature · 1 line
2.34.1
Oops, bad Subject... sending v2
Quoted 41 lines · Kees Cook
In preparation for making the kmalloc family of allocators type aware, we need to make sure that the returned type from the allocation matches the type of the variable being assigned. (Before, the allocator would always return "void *", which can be implicitly cast to any pointer type.)
The assigned type is "struct
gic_kvm_info", but the returned type, while matching, is const qualified. To get them exactly matching, just use the dereferenced pointer for thesizeof().Signed-off-by Kees Cook <[email protected]>---
Cc: Marc Zyngier <[email protected]>
Cc: Oliver Upton <[email protected]>
Cc: Joey Gouly <[email protected]>
Cc: Suzuki K Poulose <[email protected]>
Cc: Zenghui Yu <[email protected]>
Cc: Catalin Marinas <[email protected]>
Cc: Will Deacon <[email protected]>
Cc: Alexander Potapenko <[email protected]>
Cc: <[email protected]>
Cc: <[email protected]>--- arch/arm64/kvm/vgic/vgic-init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/kvm/vgic/vgic-init.c +1
-1@@ -654,7 +654,7 @@ static struct gic_kvm_info *gic_kvm_info;void __init vgic_set_kvm_info (const struct gic_kvm_info *info) {BUG_ON (gic_kvm_info !=NULL ); - gic_kvm_info =kmalloc (sizeof (*info),GFP_KERNEL ); + gic_kvm_info =kmalloc (sizeof (*gic_kvm_info),GFP_KERNEL );if (gic_kvm_info) *gic_kvm_info = *info; }Signature · 1 line
2.34.1
Signature · 1 line
Kees Cook