Skip to contentSkip to conversation

ext2: remove stale TODO about kmap

PATCH In review Milos Nikic 2 participants 3 messages Feb 7 – Feb 27 ext2 file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ext2: remove stale TODO about kmap

The TODO comment in the file header asking to get rid of kmap() is outdated. The code has already been converted to use the folio API (specifically kmap_local_folio).

Remove the stale comment to reflect the current state of the code.

---
 fs/ext2/namei.c | 2 --
 1 file changed, 2 deletions(-)
fs/ext2/namei.c +0 -2
index bde617a66cec..3ab23de558fb 100644
@@ -14,8 +14,6 @@
  *
  * The only non-static object here is ext2_dir_inode_operations.
  *
- * TODO: get rid of kmap() use, add readahead.
- *
  * Copyright (C) 1992, 1993, 1994, 1995
  * Remy Card ([email protected])
  * Laboratoire MASI - Institut Blaise Pascal
Signature · 1 line
2.52.0
#1 lore raw

Hi Jan,

Just a friendly ping on this patch now that a few weeks have passed. Let me know if you need any changes!

Thanks,
Milos

#2 lore raw

Hi!

Quoted 2 lines · Milos Nikic

Just a friendly ping on this patch now that a few weeks have passed. Let me know if you need any changes!

Thanks for reminder. I usually merge only important fixes while the merge window is open (as I want to base a branch with non-critical stuff on top of rc1 or later). But now is the right time so I've picked up this patch to my tree. Thanks!

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR