Skip to contentSkip to conversation

staging: rtl8723bs: remove hardcoded dead debug code

PATCH In review Sajja Easwar Sai 3 participants 3 messages Feb 7 – Feb 23

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 staging: rtl8723bs: remove hardcoded dead debug code

The debug code is guarded by a constant false condition and is never executed. Remove it to simplify the code. This also removes the now unused variable 'pattrib'.

---
v3:
- Removed incorrect Reported-by and Closes tags.
- Fixed name casing in Signed-off-by to use Title Case.
- Added blank line before return statement.
- Included this version history.

v2:
- Fixed build warnings found in v1.

 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 9 ---------
 1 file changed, 9 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +0 -9
index ac49bfbaa..b61841bf1 100644
@@ -1849,7 +1849,6 @@ unsigned int OnAction_ht(struct adapter *padapter, union recv_frame *precv_frame
 unsigned int OnAction_sa_query(struct adapter *padapter, union recv_frame *precv_frame)
 {
 	u8 *pframe = precv_frame->u.hdr.rx_data;
-	struct rx_pkt_attrib *pattrib = &precv_frame->u.hdr.attrib;
 	struct mlme_ext_priv *pmlmeext = &(padapter->mlmeextpriv);
 	unsigned short tid;
 
@@ -1865,14 +1864,6 @@ unsigned int OnAction_sa_query(struct adapter *padapter, union recv_frame *precv
 	default:
 		break;
 	}
-	if (0) {
-		int pp;
-
-		netdev_dbg(padapter->pnetdev, "pattrib->pktlen = %d =>", pattrib->pkt_len);
-		for (pp = 0; pp < pattrib->pkt_len; pp++)
-			pr_cont(" %02x ", pframe[pp]);
-		pr_cont("\n");
-	}
 
 	return _SUCCESS;
 }
Signature · 1 line
2.53.0