staging: vme_user: reorder NULL check after kzalloc in fake_crcsr_init
PATCH 1/1 staging: vme_user: reorder NULL check after kzalloc in fake_crcsr_init
Move the NULL check for bridge->crcsr_kernel before its use in fake_ptr_to_pci(). While fake_ptr_to_pci() is a simple cast that handles NULL safely, using a value before validating it is a bad pattern that static analyzers flag and could become a real issue if fake_ptr_to_pci() changes in the future.
--- drivers/staging/vme_user/vme_fake.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vme_user/vme_fake.c +1 -1
@@ -1029,9 +1029,9 @@ static int fake_crcsr_init(struct vme_bridge *fake_bridge)/* Allocate mem for CR/CSR image */ bridge->crcsr_kernel =kzalloc (VME_CRCSR_BUF_SIZE ,GFP_KERNEL ); - bridge->crcsr_bus =fake_ptr_to_pci (bridge->crcsr_kernel);if (!bridge->crcsr_kernel)return -ENOMEM ; + bridge->crcsr_bus =fake_ptr_to_pci (bridge->crcsr_kernel); vstat =fake_slot_get (fake_bridge);
Signature · 1 line
2.43.0
Quoted 7 lines · Artem Lytkin
Move the NULL check for
bridge->crcsr_kernelbefore its use infake_ptr_to_pci(). Whilefake_ptr_to_pci()is a simple cast that handles NULL safely, using a value before validating it is a bad pattern that static analyzers flag and could become a real issue iffake_ptr_to_pci()changes in the future.Signed-off-by Artem Lytkin <[email protected]>
LGTM.
Next time, in your subject line, it's standard practice to end function names with () to make it clear you're talking about a function.
Thanks,
ET
Greg Kroah-Hartman
maintainerQuoted 16 lines · Artem Lytkin
Move the NULL check for
bridge->crcsr_kernelbefore its use infake_ptr_to_pci(). Whilefake_ptr_to_pci()is a simple cast that handles NULL safely, using a value before validating it is a bad pattern that static analyzers flag and could become a real issue iffake_ptr_to_pci()changes in the future.Signed-off-by Artem Lytkin <[email protected]>--- drivers/staging/vme_user/vme_fake.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/vme_user/vme_fake.c +0
-0
drivers/staging/vme_user/vme_fake.c static int fake_crcsr_init(struct vme_bridge *fake_bridge) · line 1034
Quoted 7 lines
drivers/staging/vme_user/vme_fake.c +1
-1@@ -1029,9 +1029,9 @@ static int fake_crcsr_init(struct vme_bridge *fake_bridge)/* Allocate mem for CR/CSR image */ bridge->crcsr_kernel =kzalloc (VME_CRCSR_BUF_SIZE ,GFP_KERNEL ); - bridge->crcsr_bus =fake_ptr_to_pci (bridge->crcsr_kernel);if (!bridge->crcsr_kernel)return -ENOMEM ; + bridge->crcsr_bus =fake_ptr_to_pci (bridge->crcsr_kernel);
As this isn't actually a bugfix, and if an automated tool can't handle something as simple as this it's really broken, I think we should just leave this alone for now.
thanks,
greg k-h