staging: rtl8723bs: simplify boolean test in rtw_btcoex_MediaStatusNotify
PATCH v2 1/2 staging: rtl8723bs: simplify boolean test in rtw_btcoex_MediaStatusNotify
Remove unnecessary comparison to true and move logical operator to the end of the previous line.
--- drivers/staging/rtl8723bs/core/rtw_btcoex.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_btcoex.c +2 -2
@@ -10,8 +10,8 @@void rtw_btcoex_MediaStatusNotify (struct adapter *padapter,u8 media_status) { -if ((media_status ==RT_MEDIA_CONNECT ) - && (check_fwstate (&padapter->mlmepriv,WIFI_AP_STATE ) == true)) { +if ((media_status ==RT_MEDIA_CONNECT ) && +check_fwstate (&padapter->mlmepriv,WIFI_AP_STATE )) {rtw_hal_set_hwreg (padapter,HW_VAR_DL_RSVD_PAGE ,NULL ); }
Signature · 1 line
2.52.0
PATCH v2 2/2 staging: rtl8723bs: remove extra blank lines in rtw_btcoex.c
Remove unnecessary double blank lines between variable declarations and code.
--- drivers/staging/rtl8723bs/core/rtw_btcoex.c | 2 -- 1 file changed, 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_btcoex.c +0 -2
@@ -54,7 +54,6 @@ void rtw_btcoex_LPS_Enter(struct adapter *padapter)struct pwrctrl_priv *pwrpriv;u8 lps_val; - pwrpriv =adapter_to_pwrctl (padapter); pwrpriv->bpower_saving = true;
@@ -66,7 +65,6 @@ void rtw_btcoex_LPS_Leave(struct adapter *padapter) {struct pwrctrl_priv *pwrpriv; - pwrpriv =adapter_to_pwrctl (padapter);if (pwrpriv->pwr_mode !=PS_MODE_ACTIVE ) {
Signature · 1 line
2.52.0
Re: [PATCH v2 2/2] staging: rtl8723bs: remove extra blank lines in rtw_btcoex.c
Quoted 4 lines · Azamat Rakhim
Remove unnecessary double blank lines between variable declarations and code.
Signed-off-by Azamat Rakhim <[email protected]>
LGTM.
Thanks,
ET
Quoted 4 lines · Azamat Rakhim
Remove unnecessary comparison to true and move logical operator to the end of the previous line.
Signed-off-by Azamat Rakhim <[email protected]>
LGTM.
Thanks,
ET
Greg KH
maintainerQuoted 27 lines · Azamat Rakhim
Remove unnecessary comparison to true and move logical operator to the end of the previous line.
Signed-off-by Azamat Rakhim <[email protected]>--- drivers/staging/rtl8723bs/core/rtw_btcoex.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/rtl8723bs/core/rtw_btcoex.c +2
-2@@ -10,8 +10,8 @@void rtw_btcoex_MediaStatusNotify (struct adapter *padapter,u8 media_status) { -if ((media_status ==RT_MEDIA_CONNECT ) - && (check_fwstate (&padapter->mlmepriv,WIFI_AP_STATE ) == true)) { +if ((media_status ==RT_MEDIA_CONNECT ) && +check_fwstate (&padapter->mlmepriv,WIFI_AP_STATE )) {rtw_hal_set_hwreg (padapter,HW_VAR_DL_RSVD_PAGE ,NULL ); }Signature · 1 line
2.52.0
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot